code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

chore(qa): verify-issue-1290 bundle for hub wrap labels #1306

Merged
PlasticDigits merged 3 commits from issue/1302 into main 2026-09-21 08:28:53 +00:00
Conversation 5 Commits 3 Files changed 11 +401 -20
PlasticDigits commented 2026-09-21 06:37:43 +00:00
Owner
Copy link

Summary

Leftover wiring for hub wrap cLUNC vs CEX LUNC after !1290 / #1240 (issue #1306, Q22 / B1290):

  • ADR 0009 (Status Proposed [#1306]), architecture #dex-hub-wrap-labels, Q22 table, README index
  • make verify-issue-1290 + aliases make verify-issue-1302 and make verify-issue-1306; Cloud Agent + Frontend help lines
  • scripts/qa/verify-issue-1290.sh: leftover #1306 header, free_tcp_port 30129, full B1290-4 eight-file greps
  • Crosslinks: docs/testing.md, AGENTS.md, docs/frontend.md, PROTOCOL_STATS / PROTOCOL_HUB skills

Related closed !1302 sketch, !1290, and #1240. Does not Fixes #1290. Does not Closes #1302. Production /protocol glance remains #1305 leftover 1.

Acceptance criteria

ID Status
B1290-1 Child verify-issue-1240 + aliases verify-issue-1302 / verify-issue-1306
B1290-2 hubPriceTicker Vitest step
B1290-3 Playwright 5 workers, port 30129, free_tcp_port
B1290-4 Eight-file grep step (slice-0 docs on MR)
B1290-5 No product/indexer delta
B1290-6 No Fixes #1290 / Closes #1302 on this PR
B1290-7 No node_modules gitlink, no hook-test edits
B1290-8 Leftover-complete wiring MR (not skip-E2E alone)

Validation

  • VERIFY_ISSUE_1290_SKIP_E2E=1 make verify-issue-1306 — B1290-4 greps + skip-E2E path PASS on gate-impl VM (2d4e8b64).
  • Child 1240 Vitest + hubPriceTicker — not run on impl VM (no nvm / frontend-dapp/node_modules; environment gap).
  • Playwright protocol-page — skipped via VERIFY_ISSUE_1290_SKIP_E2E=1 (required implement check per ADR; CI/provisioned agent should run full make verify-issue-1290).

Gaps

  • Dev machine or CI with Node 24 + npm ci should run full bundle without SKIP_E2E.
  • Production /protocol visual QA: #1305 leftover 1 (not #1306 close gate).

Related #1306

## Summary Leftover wiring for hub wrap **cLUNC** vs CEX **LUNC** after !1290 / #1240 (issue **#1306**, **Q22** / **B1290**): - ADR **0009** (Status **Proposed [#1306]**), architecture `#dex-hub-wrap-labels`, **Q22** table, README index - `make verify-issue-1290` + aliases `make verify-issue-1302` and `make verify-issue-1306`; Cloud Agent + Frontend `help` lines - `scripts/qa/verify-issue-1290.sh`: leftover **#1306** header, `free_tcp_port` **30129**, full **B1290-4** eight-file greps - Crosslinks: `docs/testing.md`, `AGENTS.md`, `docs/frontend.md`, PROTOCOL_STATS / PROTOCOL_HUB skills Related closed !1302 sketch, !1290, and #1240. Does not `Fixes #1290`. Does not `Closes #1302`. Production `/protocol` glance remains #1305 leftover 1. ## Acceptance criteria | ID | Status | |----|--------| | **B1290-1** | Child `verify-issue-1240` + aliases `verify-issue-1302` / `verify-issue-1306` | | **B1290-2** | `hubPriceTicker` Vitest step | | **B1290-3** | Playwright 5 workers, port 30129, `free_tcp_port` | | **B1290-4** | Eight-file grep step (slice-0 docs on MR) | | **B1290-5** | No product/indexer delta | | **B1290-6** | No `Fixes #1290` / `Closes #1302` on this PR | | **B1290-7** | No node_modules gitlink, no hook-test edits | | **B1290-8** | Leftover-complete wiring MR (not skip-E2E alone) | ## Validation - `VERIFY_ISSUE_1290_SKIP_E2E=1 make verify-issue-1306` — **B1290-4** greps + skip-E2E path **PASS** on gate-impl VM (`2d4e8b64`). - Child **1240** Vitest + `hubPriceTicker` — **not run** on impl VM (no nvm / `frontend-dapp/node_modules`; environment gap). - Playwright protocol-page — skipped via `VERIFY_ISSUE_1290_SKIP_E2E=1` (required implement check per ADR; CI/provisioned agent should run full `make verify-issue-1290`). ## Gaps - Dev machine or CI with Node 24 + `npm ci` should run full bundle without `SKIP_E2E`. - Production `/protocol` visual QA: #1305 leftover 1 (not #1306 close gate). Related #1306
chore(qa): wire verify-issue-1290 bundle for hub wrap labels (#1302)
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
50eb149f12 
Add ADR 0009, Q22/B1290 docs, Makefile alias verify-issue-1302, full
B1290-4 crosslinks, free_tcp_port 30129, and leftover #1302 naming in
the QA script. Related !1290 / #1240.
PlasticDigits commented 2026-09-21 06:37:54 +00:00
Author
Owner
Copy link

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue
PlasticDigits commented 2026-09-21 06:43:07 +00:00
Author
Owner
Copy link

cl8y-agent-control: queued design_author job d94a690a-6707-404e-abc6-6f014b53aa5b (not executed; no Hetzner VM).

cl8y-agent-control: queued `design_author` job `d94a690a-6707-404e-abc6-6f014b53aa5b` (not executed; no Hetzner VM).
chore(qa): retarget verify-issue-1290 bundle to leftover #1306
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
2d4e8b6423 
Align ADR 0009 / Q22 with Proposed #1306 status, add verify-issue-1306
alias and help lines, and complete B1290-4 crosslinks after design review.

Co-authored-by: Cursor <cursoragent@cursor.com>
PlasticDigits commented 2026-09-21 08:22:51 +00:00
Author
Owner
Copy link

AC review B1290-1–B1290-8 PASS (docs/Makefile/QA wiring only; no product/indexer delta; no Fixes #1290 / Closes #1302). Production /protocol glance stays #1305 leftover 1.

Conflict with !1310 is expected on Makefile help lines and docs/qa-invariants.md Q21 vs Q22. Merge order: !1309 (CODEOWNERS) then !1310 (product) then this PR rebased onto main, keeping both verify-issue-1308 and verify-issue-1290/1302/1306, Q21 = #1308 payload, Q22 = hub wrap leftover.

AC review B1290-1–B1290-8 PASS (docs/Makefile/QA wiring only; no product/indexer delta; no `Fixes #1290` / `Closes #1302`). Production `/protocol` glance stays #1305 leftover 1. Conflict with !1310 is expected on `Makefile` help lines and `docs/qa-invariants.md` Q21 vs Q22. Merge order: !1309 (CODEOWNERS) then !1310 (product) then this PR rebased onto `main`, keeping both `verify-issue-1308` and `verify-issue-1290`/`1302`/`1306`, Q21 = #1308 payload, Q22 = hub wrap leftover.
Merge origin/main into issue/1302.
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
19ffad024b 
Keep both Makefile help targets (1308 payload and 1290/1302/1306 hub wrap).
Q21 is Lunc Dash payload; Q22 is hub wrap leftover.
PlasticDigits commented 2026-09-21 08:28:07 +00:00
Author
Owner
Copy link

Rebased onto main after !1309 and !1310. Conflicts in Makefile (help lines) and docs/qa-invariants.md (Q21 vs Q22). Resolution keeps both verify-issue-1308 and verify-issue-1290/1302/1306. Q21 = Lunc Dash payload (!1310); Q22 = hub wrap leftover.

Local: VERIFY_ISSUE_1290_SKIP_E2E=1 make verify-issue-1306 PASS (child 1240 + hubPriceTicker + B1290-4). make verify-issue-1308 PASS including children 519/554/1279. Waiting Woodpecker on the merge head, then fj pr merge.

Rebased onto `main` after !1309 and !1310. Conflicts in `Makefile` (help lines) and `docs/qa-invariants.md` (Q21 vs Q22). Resolution keeps both `verify-issue-1308` and `verify-issue-1290`/`1302`/`1306`. Q21 = Lunc Dash payload (!1310); Q22 = hub wrap leftover. Local: `VERIFY_ISSUE_1290_SKIP_E2E=1 make verify-issue-1306` PASS (child 1240 + hubPriceTicker + B1290-4). `make verify-issue-1308` PASS including children 519/554/1279. Waiting Woodpecker on the merge head, then `fj pr merge`.
PlasticDigits deleted branch issue/1302 2026-09-21 08:28:53 +00:00
PlasticDigits commented 2026-09-21 08:30:13 +00:00
Author
Owner
Copy link

Merged after conflict resolution with !1310. Local make verify-issue-1290 4/4 including Playwright protocol-page 13/13 at 5 workers. Production /protocol glance stays #1305 leftover 1. Coolify + Lunc Dash device leftover is #1311.

Merged after conflict resolution with !1310. Local `make verify-issue-1290` 4/4 including Playwright protocol-page 13/13 at 5 workers. Production `/protocol` glance stays #1305 leftover 1. Coolify + Lunc Dash device leftover is [#1311](https://git.cl8y.com/code/cl8y-dex-terraclassic/issues/1311).
Sign in to join this conversation.
Reviewers
No reviewers
code/maintainers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1306
No description provided.