code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

fix(frontend): Lunc Dash WalletConnect pair on mobile never lists dex.cl8y.com #1310

Merged
PlasticDigits merged 3 commits from issue/1308 into main 2026-09-21 08:24:43 +00:00
Conversation 2 Commits 3 Files changed 11 +185 -17
PlasticDigits commented 2026-09-21 07:51:07 +00:00
Owner
Copy link

Summary

  • Fix buildLuncDashDeepLink to emit luncdash://wallet_connect?payload=<encoded wc:> with a parseable payload query key (was double-encoding the whole payload=… string, which Lunc Dash could not consume).
  • Add parseLuncDashDeepLinkPayload plus regression tests; update pairing modal expectation.
  • Add make verify-issue-1308 (Vitest + docs + children 519/554), Q21 / L1308 in docs/qa-invariants.md, and playbook crosslinks.

Fixes #1308

Acceptance criteria

AC Status
AC1 Mobile pairing sheet (no QR) Covered by existing WC-M1 tests (#519/#554); unchanged behavior
AC2 Open Lunc Dash → terra1… Device after Coolify deploy
AC3 Wallet lists dex.cl8y.com Device after Coolify deploy
AC4 Copy raw wc: Unchanged (CopyButton on payload.uri)
AC5 Desktop QR Unchanged (WC-M2)
AC6 Cancel / stacking Unchanged (WC-M8–M9); #554 green
AC7 Swap approve/reject Device after AC2
AC8 Terms hint Unchanged (WC-M12); #554 green

Validation

  • make verify-issue-1308 (green in worktree)
  • Includes verify-issue-519 and verify-issue-554

Gaps / follow-up

  • Production device QA on dex.cl8y.com (AC2–AC3, AC7) requires Coolify frontend cut after merge.
  • VERIFY1308_DEVICE_COMPLETE=1 intentionally fails in verify script (same pattern as #1279 leftover).
  • No live log review for this frontend-only URI fix.
## Summary - Fix `buildLuncDashDeepLink` to emit `luncdash://wallet_connect?payload=<encoded wc:>` with a parseable **`payload` query key** (was double-encoding the whole `payload=…` string, which Lunc Dash could not consume). - Add `parseLuncDashDeepLinkPayload` plus regression tests; update pairing modal expectation. - Add `make verify-issue-1308` (Vitest + docs + children 519/554), **Q21** / **L1308** in `docs/qa-invariants.md`, and playbook crosslinks. Fixes #1308 ## Acceptance criteria | AC | Status | |----|--------| | AC1 Mobile pairing sheet (no QR) | Covered by existing WC-M1 tests (#519/#554); unchanged behavior | | AC2 Open Lunc Dash → terra1… | Device after Coolify deploy | | AC3 Wallet lists dex.cl8y.com | Device after Coolify deploy | | AC4 Copy raw wc: | Unchanged (CopyButton on payload.uri) | | AC5 Desktop QR | Unchanged (WC-M2) | | AC6 Cancel / stacking | Unchanged (WC-M8–M9); #554 green | | AC7 Swap approve/reject | Device after AC2 | | AC8 Terms hint | Unchanged (WC-M12); #554 green | ## Validation - make verify-issue-1308 (green in worktree) - Includes verify-issue-519 and verify-issue-554 ## Gaps / follow-up - Production device QA on dex.cl8y.com (AC2–AC3, AC7) requires Coolify frontend cut after merge. - VERIFY1308_DEVICE_COMPLETE=1 intentionally fails in verify script (same pattern as #1279 leftover). - No live log review for this frontend-only URI fix.
fix(frontend): Lunc Dash WalletConnect payload query for mobile pairing
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
5289960ccc 
Use a real payload query key in buildLuncDashDeepLink so Lunc Dash can
consume same-device links on dex.cl8y.com. Add verify-issue-1308 and Q21.

Fixes #1308
Merge origin/main into issue/1308.
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
5b9f4cf30d 
Keep cl8y-pm leftover docs with the Lunc Dash payload query. Point
verify-issue-1308 at the pairing modal .tsx file and parse payload
via URLSearchParams.
Merge origin/main into issue/1308.
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
723cdf2f5d 
Pick up CODEOWNERS removal from #1309 so the branch is not outdated.
PlasticDigits commented 2026-09-21 08:24:12 +00:00
Author
Owner
Copy link

Merge blocked with HTTP 405 after !1309: branch protection block_on_outdated_branch (not force_merge). Merged origin/main into issue/1308 (CODEOWNERS delete only). Waiting on Woodpecker on the new head, then retry fj pr merge.

Merge blocked with HTTP 405 after !1309: branch protection `block_on_outdated_branch` (not `force_merge`). Merged `origin/main` into `issue/1308` (CODEOWNERS delete only). Waiting on Woodpecker on the new head, then retry `fj pr merge`.
PlasticDigits deleted branch issue/1308 2026-09-21 08:24:43 +00:00
PlasticDigits commented 2026-09-21 08:30:15 +00:00
Author
Owner
Copy link

Merged. Device leftover after Coolify (AC2/AC3/AC7) tracked on #1311 because Fixes #1308 closed the implement ticket.

Merged. Device leftover after Coolify (AC2/AC3/AC7) tracked on [#1311](https://git.cl8y.com/code/cl8y-dex-terraclassic/issues/1311) because `Fixes #1308` closed the implement ticket.
Sign in to join this conversation.
Reviewers
No reviewers
code/maintainers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1310
No description provided.