code/cl8y-dex-terraclassic
4
0
Fork 0
Code Issues 35 Pull requests 6 Projects Releases Packages Wiki Activity

ops: post-merge leftover after PRs 1302-1304 #1305

New issue
Closed
opened 2026-09-21 06:14:44 +00:00 by PlasticDigits · 4 comments
PlasticDigits commented 2026-09-21 06:14:44 +00:00
Owner
Copy link

Tracking leftover ops after merging PRs 1302–1304 onto origin/main (729b097f).

Merged

PR Linked Note
1302 #1290 / #1240 make verify-issue-1290 bundle (P1240 + hubPriceTicker + Playwright)
1303 #1277 / #1292 trader lifetime heal from swap_events (migrate + gated poller before D5)
1304 #1303 / #1277 sqlx 0.8 &mut **tx so apply_trader_lifetime_heal_tx compiles

Woodpecker ci/woodpecker/pr/woodpecker and ci/woodpecker/push/woodpecker succeeded. Local gitleaks clean.

Workstation verify (this merge)

  • make verify-issue-1290 4/4 including Playwright protocol-page (--workers=5)
  • make verify-issue-1277 6/6 after #1304 (docs, code, I10 rolling+heal, #577 decay, #548 catalog, api_traders)
  • #1303 as merged did not compile (Executor not implemented for &mut Transaction); fixed in #1304

Leftover (this issue)

  1. Coolify /protocol visual (#1290 AC): hub <dt> cUSTC / USD + cLUNC / USD vs oracle tabs USTC / LUNC / vFDUSD (selected tab not VFDUSD).
  2. Coolify indexer migrate: apply 20260921130000_traders_lifetime_heal_from_swaps after the #1277 widen + #1263 30d versions already listed on #1300. Confirm _sqlx_migrations then D5 refresh / heal no-op or log.
  3. ADR 0008 collision: do not merge origin/cac-design-issue-1300, origin/cac-design-issue-1302, or origin/cac-design-issue-1277 as-is. Other workers; 0005 is protocol-fee; two branches both want 0008. Re-slot if a design ADR is still needed.
  4. Optional I10: USD-only lifetime skew does not re-trip the poller gate (gate is trades+raw only).
  5. Merge recipe: .* @code/maintainers CODEOWNERS + block_on_official_review_requests makes fj pr merge return HTTP 405 until the team self-request is dismissed. Dismiss then fj pr merge. Do not force_merge (docs/runbooks/forgejo-pr-merge.md). #1302/#1303 were merged with force_merge before this was followed; both commits are ancestors of origin/main. #1304 used dismiss + normal merge.

Sister leftover for PRs 1287–1298 remains #1300.

Tracking leftover ops after merging PRs **1302–1304** onto `origin/main` (`729b097f`). ## Merged | PR | Linked | Note | |----|--------|------| | 1302 | #1290 / #1240 | `make verify-issue-1290` bundle (P1240 + hubPriceTicker + Playwright) | | 1303 | #1277 / #1292 | trader lifetime heal from `swap_events` (migrate + gated poller before D5) | | 1304 | #1303 / #1277 | sqlx 0.8 `&mut **tx` so `apply_trader_lifetime_heal_tx` compiles | Woodpecker `ci/woodpecker/pr/woodpecker` and `ci/woodpecker/push/woodpecker` succeeded. Local gitleaks clean. ## Workstation verify (this merge) - [x] `make verify-issue-1290` 4/4 including Playwright `protocol-page` (`--workers=5`) - [x] `make verify-issue-1277` 6/6 **after #1304** (docs, code, I10 rolling+heal, #577 decay, #548 catalog, `api_traders`) - [x] #1303 as merged did **not** compile (`Executor` not implemented for `&mut Transaction`); fixed in #1304 ## Leftover (this issue) 1. **Coolify `/protocol` visual** (#1290 AC): hub `<dt>` `cUSTC / USD` + `cLUNC / USD` vs oracle tabs `USTC` / `LUNC` / `vFDUSD` (selected tab not `VFDUSD`). 2. **Coolify indexer migrate**: apply `20260921130000_traders_lifetime_heal_from_swaps` after the #1277 widen + #1263 30d versions already listed on #1300. Confirm `_sqlx_migrations` then D5 refresh / heal no-op or log. 3. **ADR 0008 collision**: do **not** merge `origin/cac-design-issue-1300`, `origin/cac-design-issue-1302`, or `origin/cac-design-issue-1277` as-is. Other workers; `0005` is protocol-fee; two branches both want `0008`. Re-slot if a design ADR is still needed. 4. **Optional I10**: USD-only lifetime skew does not re-trip the poller gate (gate is trades+raw only). 5. **Merge recipe**: `.* @code/maintainers` CODEOWNERS + `block_on_official_review_requests` makes `fj pr merge` return HTTP 405 until the team self-request is dismissed. Dismiss then `fj pr merge`. Do not `force_merge` (`docs/runbooks/forgejo-pr-merge.md`). #1302/#1303 were merged with `force_merge` before this was followed; both commits **are** ancestors of `origin/main`. #1304 used dismiss + normal merge. Sister leftover for PRs 1287–1298 remains **#1300**.
PlasticDigits commented 2026-09-21 06:37:33 +00:00
Author
Owner
Copy link

cl8y-agent-control: queued design_author job 7e99e9de-e820-4832-b906-baade8f9bb09 (not executed; no Hetzner VM).

cl8y-agent-control: queued `design_author` job `7e99e9de-e820-4832-b906-baade8f9bb09` (not executed; no Hetzner VM).
PlasticDigits commented 2026-09-21 06:46:45 +00:00
Author
Owner
Copy link

Leftover ops (complete)

Coolify leftover for this ticket is done. Indexer and frontend are on origin/main 729b097f.

Indexer

  • GET /health → status=ok, git_sha=729b097f5fe1f52565740a4207a6703efc646b8a
  • Healthy boot implies sqlx 20260921120000 / 20260921120001 / 20260921130000 applied (dirty migrate would fail start)
  • GET /api/v1/protocol/top-pairs → HTTP 200, 5 economic rows (UST1/cUSTC, UST1/USTR, cLUNC/cUSTC, CL8Y-cb/cUSTC, CL8Y-cb/cLUNC)
  • ?limit=6 → HTTP 400 Invalid limit, expected 5

Frontend /protocol

Playwright against production passed:

  • Hub <dt>: cUSTC / USD and cLUNC / USD (mixed case; not flattened CUSTC)
  • Oracle tabs: USTC (selected), LUNC, vFDUSD (not VFDUSD)

Local make verify-issue-1290 still has one Playwright tick-overlap fail (YY-MM monthly x-axis). That is not this Coolify leftover.

Closing this issue. Chain leftover (pair wasm 1.17.0, AC1 gas, Lunc Dash device QA) stays on #1300 / #1234 / #1264 / #1279.

## Leftover ops (complete) Coolify leftover for this ticket is done. Indexer and frontend are on origin/main `729b097f`. ### Indexer - `GET /health` → `status=ok`, `git_sha=729b097f5fe1f52565740a4207a6703efc646b8a` - Healthy boot implies sqlx `20260921120000` / `20260921120001` / `20260921130000` applied (dirty migrate would fail start) - `GET /api/v1/protocol/top-pairs` → HTTP 200, 5 economic rows (UST1/cUSTC, UST1/USTR, cLUNC/cUSTC, CL8Y-cb/cUSTC, CL8Y-cb/cLUNC) - `?limit=6` → HTTP 400 `Invalid limit, expected 5` ### Frontend `/protocol` Playwright against production passed: - Hub `<dt>`: `cUSTC / USD` and `cLUNC / USD` (mixed case; not flattened `CUSTC`) - Oracle tabs: `USTC` (selected), `LUNC`, `vFDUSD` (not `VFDUSD`) Local `make verify-issue-1290` still has one Playwright tick-overlap fail (`YY-MM` monthly x-axis). That is not this Coolify leftover. Closing this issue. Chain leftover (pair wasm 1.17.0, AC1 gas, Lunc Dash device QA) stays on #1300 / #1234 / #1264 / #1279.
PlasticDigits 2026-09-21 06:46:53 +00:00
  • closed this issue
  • removed the
    ready
         label
PlasticDigits commented 2026-09-21 07:13:36 +00:00
Author
Owner
Copy link

Reopened as a leftover precondition. The 06:46 close comment (top-pairs + /health SHA) is #1300 / ADR 0006, not leftover-complete for this card. Leftover-complete still records on #1305 after ADR 0010 operator evidence.

Reopened as a leftover precondition. The 06:46 close comment (`top-pairs` + `/health` SHA) is #1300 / ADR 0006, not leftover-complete for this card. Leftover-complete still records on #1305 after ADR 0010 operator evidence.
PlasticDigits commented 2026-09-21 08:30:11 +00:00
Author
Owner
Copy link

PRs 1306 / 1309 / 1310 are on origin/main (0d6eaeee). Catch-all CODEOWNERS is gone (this issue leftover 5). New leftover for Coolify frontend + Lunc Dash device AC after !1310 closed #1308: #1311. This ticket still owns leftover 1 (/protocol visual) and leftover 2 (indexer migrate). Do not merge cac-design-issue-1300 / 1302 / 1306 as-is (leftover 3).

PRs **1306 / 1309 / 1310** are on `origin/main` (`0d6eaeee`). Catch-all CODEOWNERS is gone (this issue leftover 5). New leftover for Coolify frontend + Lunc Dash device AC after !1310 closed #1308: [#1311](https://git.cl8y.com/code/cl8y-dex-terraclassic/issues/1311). This ticket still owns leftover 1 (`/protocol` visual) and leftover 2 (indexer migrate). Do not merge `cac-design-issue-1300` / `1302` / `1306` as-is (leftover 3).
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/tokio-util-0.x-lockfile
renovate/thiserror-2.x-lockfile
renovate/serde_json-1.x-lockfile
renovate/serde-monorepo
renovate/libc-0.x-lockfile
renovate/chrono-0.x-lockfile
cac-design-issue-1206
cac-design-issue-1317
cac-design-issue-1316
cac-design-issue-1311
cac-design-issue-1300
cac-design-issue-1306
cac-design-issue-1305
cac-design-issue-1302
cac-design-issue-1277
No results found.
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:implement
Queue implement gate

  
agent:implement
Queue implement gate

  
agent:open_issues

   
agent:ready

   
agent:research

   
agent:security_audit

   
agent:verify

   
architecture
Architecture

  
backend
API and services

  
blocker:hybrid
Blocks hybrid launch

  
blocker:launch
Blocks launch

  
blocker:limit-orders
Blocks limits launch

  
blocker:v2
Blocks v2

  
block:log_only

   
block:security

   
bug

   
ci

   
contracts
Smart contracts

  
correctness

   
deploy

   
dev

   
devops

   
docs

   
documentation

   
duplicate

   
e2e

   
enhancement

   
epic
Epic

  
feature

   
frontend

   
functional-completion
Functional

  
gas

   
good first issue

   
governance

   
help wanted

   
high-risk

   
hooks

   
hybrid
Hybrid swaps

  
indexer
Indexer

  
infra
CI/CD

  
infrastructure

   
integrators

   
invalid

   
launch-blocker

   
limit-orders
Limit orders

  
localnet

   
localterra

   
low priority

   
missing-implementation
Implementation

  
needs-design
Design decision required

  
ops

   
performance
  
priority
high

  
priority
medium

  
product

   
qa

   
QA

   
question

   
ready
Definition of Ready

  
ready
Definition of Ready

  
research

   
scripts

   
security
Security

  
security-hardening
Security hardening

  
smartcontracts

   
tech-debt

   
testing
Testing

  
ux

   
UX

   
v2
Pool-only swaps

  
verification

   
wontfix
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic#1305
No description provided.