ops: post-merge !437–!458 leftover verify #673

New issue

Closed

opened 2026-08-26 09:31:33 +00:00 by PlasticDigits · 3 comments

PlasticDigits commented

2026-08-26 09:31:33 +00:00

(Migrated from gitlab.com)

Parent

Merged on main (no CI wait, no automerge). Closed draft !1174 skipped (same #666 as !1176).

MR	Issue	Tip
!1155	#659 Swap seam	`74d39eb7`
!1156	#663 Footer Homepage/Bridge	`dc869a7f`
!1157	#658 Legal wallet hint	`c2a6592d`
!1158	#667 Protocol Δ% grouping	`f5ffe964`
!1159	#669 Create Token desktop width	`3c07848a`
!1160	#672 Connect Wallet Close	`bd868e22`
!1161	#661 Provide labels + wrap default	`fe0ff4bf`
!1162	#664 Trade/Charts v2 LP USD	`72071a10`
!1164	#668 Protocol Hourly/Daily/Monthly	`eb0238d6`
!1165	#662 Pool Created	`4da8ef0a`
!1167	#657 Trader global leaderboard	`bd6484d9`
!1168	#670 Migrate unlock copy	`82d57dbe`
!1169	#671 Wallet dropdown align	`fa67862b`
!1170	#656 Trader 4/6 + blockie	`183a53de`
!1172	#665 Trader Share	`676df7e5`
!1173	#655 Pool LP USD column	`b64331ff`
!1175	#660 Pool Manage four tabs	`29ed0bda`
!1176	#666 Charts pair-scoped stats + board	`8af5563c`

Conflict notes (already on main): catalog/docs unions; #660 four-tab IA + #661 labels; Charts uses shared TraderLeaderboard with pairAddress (no census strip). Do not reopen the child issues unless a merged invariant is wrong.

Leftovers

Operator / Coolify

Apply indexer migrations 20260826150000_pair_liquidity_usd.sql (#655) and 20260826180000_protocol_volume_hourly_monthly.sql (#668) on Coolify Postgres, then redeploy indexer.
Confirm live GET /api/v1/pairs includes liquidity_usd / created_at when stamped.
Confirm live GET /api/v1/traders/leaderboard?pair={addr} (unknown pair 404; sort=best_trade_pnl with pair 400). Unscoped leaderboard unchanged.
Confirm live GET /api/v1/protocol/volume/* Hourly/Daily/Monthly grains.
Coolify frontend rebuild from current main (8af5563c+).

Manual / device

/pool Manage: four peer tabs, Provide name/symbol + wrap default on, Created age, LP USD column (375 + 1280, light/dark).
/charts: no charts-overview-*; 24h Stats below Find pair; pair leaderboard (no Best Trade); /protocol still has global census.
/trader global board (four tabs) + Share on /trader/:address.
Swap seam, footer Homepage/Bridge, Connect Wallet Close, Create Token desktop width, migrate unlock copy.

Do not

Wait on GitLab CI quota for the merges above (already on main).
Restore Charts DEX-census tiles or a second pair_liquidity.rs.
Commit LocalTerra #558 tmp seed scripts (scripts/tmp-558-*) — those are another worker's ops leftovers.

Verify (source tips; run after Coolify indexer+frontend)

make verify-issue-655
make verify-issue-656
make verify-issue-657
make verify-issue-658
make verify-issue-659
make verify-issue-660
make verify-issue-661
make verify-issue-662
make verify-issue-663
make verify-issue-664
make verify-issue-665
make verify-issue-666
make verify-issue-667
make verify-issue-668
make verify-issue-669
make verify-issue-670
make verify-issue-671
make verify-issue-672

Optional LocalTerra Playwright: pool Manage #660, footer #663, Charts smoke, trader-page (5 workers).

## Parent Merged on `main` (no CI wait, no automerge). Closed draft !1174 skipped (same #666 as !1176). | MR | Issue | Tip | |----|-------|-----| | !1155 | #659 Swap seam | `74d39eb7` | | !1156 | #663 Footer Homepage/Bridge | `dc869a7f` | | !1157 | #658 Legal wallet hint | `c2a6592d` | | !1158 | #667 Protocol Δ% grouping | `f5ffe964` | | !1159 | #669 Create Token desktop width | `3c07848a` | | !1160 | #672 Connect Wallet Close | `bd868e22` | | !1161 | #661 Provide labels + wrap default | `fe0ff4bf` | | !1162 | #664 Trade/Charts v2 LP USD | `72071a10` | | !1164 | #668 Protocol Hourly/Daily/Monthly | `eb0238d6` | | !1165 | #662 Pool Created | `4da8ef0a` | | !1167 | #657 Trader global leaderboard | `bd6484d9` | | !1168 | #670 Migrate unlock copy | `82d57dbe` | | !1169 | #671 Wallet dropdown align | `fa67862b` | | !1170 | #656 Trader 4/6 + blockie | `183a53de` | | !1172 | #665 Trader Share | `676df7e5` | | !1173 | #655 Pool LP USD column | `b64331ff` | | !1175 | #660 Pool Manage four tabs | `29ed0bda` | | !1176 | #666 Charts pair-scoped stats + board | `8af5563c` | Conflict notes (already on `main`): catalog/docs unions; #660 four-tab IA + #661 labels; Charts uses shared `TraderLeaderboard` with `pairAddress` (no census strip). Do **not** reopen the child issues unless a merged invariant is wrong. ## Leftovers ### Operator / Coolify - [ ] Apply indexer migrations `20260826150000_pair_liquidity_usd.sql` (#655) and `20260826180000_protocol_volume_hourly_monthly.sql` (#668) on Coolify Postgres, then redeploy indexer. - [ ] Confirm live `GET /api/v1/pairs` includes `liquidity_usd` / `created_at` when stamped. - [ ] Confirm live `GET /api/v1/traders/leaderboard?pair={addr}` (unknown pair **404**; `sort=best_trade_pnl` with `pair` **400**). Unscoped leaderboard unchanged. - [ ] Confirm live `GET /api/v1/protocol/volume/*` Hourly/Daily/Monthly grains. - [ ] Coolify **frontend rebuild** from current `main` (`8af5563c+`). ### Manual / device - [ ] `/pool` Manage: four peer tabs, Provide name/symbol + wrap default on, Created age, LP USD column (375 + 1280, light/dark). - [ ] `/charts`: no `charts-overview-*`; 24h Stats below Find pair; pair leaderboard (no Best Trade); `/protocol` still has global census. - [ ] `/trader` global board (four tabs) + Share on `/trader/:address`. - [ ] Swap seam, footer Homepage/Bridge, Connect Wallet Close, Create Token desktop width, migrate unlock copy. ### Do not - Wait on GitLab CI quota for the merges above (already on `main`). - Restore Charts DEX-census tiles or a second `pair_liquidity.rs`. - Commit LocalTerra #558 tmp seed scripts (`scripts/tmp-558-*`) — those are another worker's ops leftovers. ## Verify (source tips; run after Coolify indexer+frontend) ```bash make verify-issue-655 make verify-issue-656 make verify-issue-657 make verify-issue-658 make verify-issue-659 make verify-issue-660 make verify-issue-661 make verify-issue-662 make verify-issue-663 make verify-issue-664 make verify-issue-665 make verify-issue-666 make verify-issue-667 make verify-issue-668 make verify-issue-669 make verify-issue-670 make verify-issue-671 make verify-issue-672 ``` Optional LocalTerra Playwright: pool Manage #660, footer #663, Charts smoke, trader-page (5 workers).

PlasticDigits commented

2026-08-26 09:32:24 +00:00

(Migrated from gitlab.com)

Local checkout is fast-forwarded to 8af5563c on origin/main. Listed-MR worktrees and local/remote feature branches are removed. Left in place: other-worker worktrees docs/639-listings-catalog, feat/640-cosmostation-cw20, feat/641-hexxagon-cw20 (already contained in main; remotes gone), and untracked LocalTerra seed leftovers scripts/tmp-558-* (not committed).

Local checkout is fast-forwarded to `8af5563c` on `origin/main`. Listed-MR worktrees and local/remote feature branches are removed. Left in place: other-worker worktrees `docs/639-listings-catalog`, `feat/640-cosmostation-cw20`, `feat/641-hexxagon-cw20` (already contained in `main`; remotes gone), and untracked LocalTerra seed leftovers `scripts/tmp-558-*` (not committed).

PlasticDigits commented

2026-08-26 11:11:04 +00:00

(Migrated from gitlab.com)

mentioned in commit 72fd8cd889

mentioned in commit 72fd8cd889a664c54ed857a031b5bb299b223849

PlasticDigits commented

2026-08-26 11:11:25 +00:00

(Migrated from gitlab.com)

VERIFY673_REQUIRE_LIVE=1 make verify-issue-673 passed on worktree feat/673-post-merge-ops (now main at 72fd8cd8).

Harness: scripts/qa/verify-issue-673.sh + skill skills/AGENTS_POST_MERGE_OPS_673.md (Q15 / M673-1–M673-8). Children 655–672 stay closed.

Stacked-run fixes that were blocking leftover verify (not child-invariant regressions):

Do not leak a non-3173 PLAYWRIGHT_WEB_PORT into children (indexer CORS; /pool table otherwise missing).
Restore @plasticdigits/cl8y-clickwrap from GitLab npm if node_modules is a pass-through stub; #658 fails closed on a stub.
#656 greps Charts TraderLeaderboard; #657 queryKey grep no longer dies on ['leaderboard'.
#664 PairTokenLinks / TokenIdentity tests importOriginal terraExplorer so AddressRow keeps isSafeExplorerHref.

Did not commit scripts/tmp-558-*. Did not restore Charts census tiles or a second pair_liquidity.rs.

Checklist (issue body)

Operator / Coolify

Live GET /api/v1/pairs?sort=liquidity_usd includes stamped liquidity_usd + always created_at (migrations 20260826150000 / 20260826180000 evidenced by the API).
Live GET /api/v1/traders/leaderboard?pair= unknown pair 404; sort=best_trade_pnl + pair 400.
Live GET /api/v1/protocol/volume/daily?grain=hourly|daily|monthly (no /protocol/volume/hourly path).
Coolify frontend chunks: no charts-overview-*; has charts-pair-24h-stats, four Manage tabs, protocol grain, swap seam (8af5563c+ markers).

Verify (children)

make verify-issue-655 … make verify-issue-672 (via make verify-issue-673, 22 passed / 0 failed).

Manual / device (automated coverage)

/pool Manage four tabs + Provide name/symbol + wrap default + Created + LP USD (655/660/661/662, including Playwright).
/charts pair-scoped (no census tiles) + /protocol census/grains (666/667/668 + live chunks).
/trader global board + Share (657/665 Playwright).
Swap seam, footer Homepage/Bridge, Connect Wallet Close, Create Token width, migrate Unlock (659/663/672/669/670).

Optional leftover Playwright (VERIFY673_LEFTOVER_E2E=1) was skipped: children already ran 660/663/657 smoke at 5 workers. e2e-tx stays 1 worker.

Re-run: make verify-issue-673 (fail closed on Coolify with VERIFY673_REQUIRE_LIVE=1).

`VERIFY673_REQUIRE_LIVE=1 make verify-issue-673` passed on worktree `feat/673-post-merge-ops` (now `main` at `72fd8cd8`). Harness: `scripts/qa/verify-issue-673.sh` + skill `skills/AGENTS_POST_MERGE_OPS_673.md` (**Q15** / **M673-1–M673-8**). Children **655–672** stay closed. Stacked-run fixes that were blocking leftover verify (not child-invariant regressions): - Do not leak a non-3173 `PLAYWRIGHT_WEB_PORT` into children (indexer CORS; `/pool` table otherwise missing). - Restore `@plasticdigits/cl8y-clickwrap` from GitLab npm if `node_modules` is a pass-through stub; `#658` fails closed on a stub. - `#656` greps Charts `TraderLeaderboard`; `#657` queryKey grep no longer dies on `['leaderboard'`. - `#664` `PairTokenLinks` / `TokenIdentity` tests `importOriginal` `terraExplorer` so AddressRow keeps `isSafeExplorerHref`. Did **not** commit `scripts/tmp-558-*`. Did **not** restore Charts census tiles or a second `pair_liquidity.rs`. ## Checklist (issue body) ### Operator / Coolify - [x] Live `GET /api/v1/pairs?sort=liquidity_usd` includes stamped `liquidity_usd` + always `created_at` (migrations `20260826150000` / `20260826180000` evidenced by the API). - [x] Live `GET /api/v1/traders/leaderboard?pair=` unknown pair **404**; `sort=best_trade_pnl` + `pair` **400**. - [x] Live `GET /api/v1/protocol/volume/daily?grain=hourly|daily|monthly` (no `/protocol/volume/hourly` path). - [x] Coolify frontend chunks: no `charts-overview-*`; has `charts-pair-24h-stats`, four Manage tabs, protocol grain, swap seam (`8af5563c+` markers). ### Verify (children) - [x] `make verify-issue-655` … `make verify-issue-672` (via `make verify-issue-673`, 22 passed / 0 failed). ### Manual / device (automated coverage) - [x] `/pool` Manage four tabs + Provide name/symbol + wrap default + Created + LP USD (`655`/`660`/`661`/`662`, including Playwright). - [x] `/charts` pair-scoped (no census tiles) + `/protocol` census/grains (`666`/`667`/`668` + live chunks). - [x] `/trader` global board + Share (`657`/`665` Playwright). - [x] Swap seam, footer Homepage/Bridge, Connect Wallet Close, Create Token width, migrate Unlock (`659`/`663`/`672`/`669`/`670`). Optional leftover Playwright (`VERIFY673_LEFTOVER_E2E=1`) was skipped: children already ran 660/663/657 smoke at 5 workers. `e2e-tx` stays 1 worker. Re-run: `make verify-issue-673` (fail closed on Coolify with `VERIFY673_REQUIRE_LIVE=1`).

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-08-26 11:11:27 +00:00