fix(frontend): align connected wallet dropdown icon+label rows (#671) #1169

Merged
PlasticDigits merged 2 commits from feat/671-wallet-dropdown-align into main 2026-08-26 08:34:24 +00:00
PlasticDigits commented 2026-08-26 07:16:51 +00:00 (Migrated from gitlab.com)

Summary

  • Own horizontal flex on .wallet-menu-item so Copy / explorer / switch / Portfolio / Trader / Disconnect are icon-left + label on one row (no stacked glyphs).
  • Wallet header AddressRow uses truncated nowrap (full bech32 stays in title / copy / explorer). showFull + break-all remains for Pool / Protocol.
  • Defense-in-depth: isSafeExplorerHref omits javascript: / data:; traderProfilePath only for valid terra bech32.
  • Invariants W671-1–W671-8 in docs/frontend.md + skills/AGENTS_FRONTEND_WALLET_CHIP.md. make verify-issue-671.

Closes #671

Test plan

  • make verify-issue-671 (Vitest + CSS/docs grep + Playwright geometry, 5 workers, no e2e-tx)
  • make lint-frontend (no new errors)
  • Reviewer: connect wallet → open header chip → every action is one horizontal row; header address is truncated, not a mid-wrapped 44-char underline
  • Copy still writes full bech32; View on explorer still noopener; Switch wallet still opens Connect Wallet
  • Phone (~390) and desktop; light + dark
## Summary - Own horizontal flex on `.wallet-menu-item` so Copy / explorer / switch / Portfolio / Trader / Disconnect are icon-left + label on one row (no stacked glyphs). - Wallet header `AddressRow` uses truncated `nowrap` (full bech32 stays in `title` / copy / explorer). `showFull` + `break-all` remains for Pool / Protocol. - Defense-in-depth: `isSafeExplorerHref` omits `javascript:` / `data:`; `traderProfilePath` only for valid `terra` bech32. - Invariants **W671-1–W671-8** in `docs/frontend.md` + `skills/AGENTS_FRONTEND_WALLET_CHIP.md`. `make verify-issue-671`. Closes #671 ## Test plan - [x] `make verify-issue-671` (Vitest + CSS/docs grep + Playwright geometry, 5 workers, no `e2e-tx`) - [x] `make lint-frontend` (no new errors) - [ ] Reviewer: connect wallet → open header chip → every action is one horizontal row; header address is truncated, not a mid-wrapped 44-char underline - [ ] Copy still writes full bech32; View on explorer still `noopener`; Switch wallet still opens Connect Wallet - [ ] Phone (~390) and desktop; light + dark
PlasticDigits commented 2026-08-26 08:34:15 +00:00 (Migrated from gitlab.com)

added 37 commits

  • 756acf1e...82d57dbe - 36 commits from branch main
  • c7b888ff - Merge origin/main into branch for !1169

Compare with previous version

added 37 commits <ul><li>756acf1e...82d57dbe - 36 commits from branch <code>main</code></li><li>c7b888ff - Merge origin/main into branch for !1169</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/451/diffs?diff_id=1984484912&start_sha=756acf1edc4ccb95b5e8854bdc6c08cc4729e88a)
PlasticDigits commented 2026-08-26 08:34:16 +00:00 (Migrated from gitlab.com)

mentioned in commit c7b888ff56

mentioned in commit c7b888ff56cc8d6f63668a24307fd8db060a9292
PlasticDigits commented 2026-08-26 08:34:25 +00:00 (Migrated from gitlab.com)

mentioned in commit fa67862b24

mentioned in commit fa67862b24705fb8ab552ba33e6b910d2e1a2624
PlasticDigits (Migrated from gitlab.com) merged commit fa67862b24 into main 2026-08-26 08:34:25 +00:00
PlasticDigits commented 2026-08-26 09:31:03 +00:00 (Migrated from gitlab.com)

mentioned in issue #671

mentioned in issue #671
PlasticDigits commented 2026-08-26 09:31:37 +00:00 (Migrated from gitlab.com)

mentioned in issue #673

mentioned in issue #673
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!1169
No description provided.