feat(frontend): show Charts trader leaderboard on /trader (#657) #1167

Merged

PlasticDigits merged 2 commits from feat/657-trader-leaderboard into main

2026-08-26 08:25:06 +00:00

PlasticDigits commented

2026-08-26 07:13:14 +00:00

(Migrated from gitlab.com)

Summary

Extract the Charts trader leaderboard into shared TraderLeaderboard (getLeaderboard(sort, 20), query key ['leaderboard', sort], USD Volume via formatIndexedVolumeUsd).
Mount it as the last /trader and /trader/:address page section (empty lookup, 404, and profile outage included). /portfolio is unchanged.
Document invariants TL-1–TL-10, skill AGENTS_FRONTEND_TRADER_LEADERBOARD.md, and make verify-issue-657.

Closes #657

Test plan

Vitest: TraderLeaderboard.test.tsx, TraderPage.test.tsx, ChartsPage.test.tsx (#553), PortfolioPage.test.tsx (no board)
make verify-issue-657 (docs/skills, chrome nesting, Playwright e2e/trader-page.spec.ts)
Manual: /trader empty lookup — Leaderboard below empty prompt, above legal footer
Manual: /trader/:address found — board below Trade History
Manual: 404 + indexer outage — board still visible; profile banner/RetryError unchanged
Volume tab compact USD (no raw T); unpriced —; idle $0
P&L tabs: Best Trade / Most Profit / Most Loss
Light + dark; ~375px horizontal scroll; last rows not under mobile nav
/portfolio has no leaderboard

## Summary - Extract the Charts trader leaderboard into shared `TraderLeaderboard` (`getLeaderboard(sort, 20)`, query key `['leaderboard', sort]`, USD Volume via `formatIndexedVolumeUsd`). - Mount it as the **last** `/trader` and `/trader/:address` page section (empty lookup, 404, and profile outage included). `/portfolio` is unchanged. - Document invariants **TL-1–TL-10**, skill `AGENTS_FRONTEND_TRADER_LEADERBOARD.md`, and `make verify-issue-657`. Closes #657 ## Test plan - [x] Vitest: `TraderLeaderboard.test.tsx`, `TraderPage.test.tsx`, `ChartsPage.test.tsx` (#553), `PortfolioPage.test.tsx` (no board) - [x] `make verify-issue-657` (docs/skills, chrome nesting, Playwright `e2e/trader-page.spec.ts`) - [ ] Manual: `/trader` empty lookup — Leaderboard below empty prompt, above legal footer - [ ] Manual: `/trader/:address` found — board below Trade History - [ ] Manual: 404 + indexer outage — board still visible; profile banner/RetryError unchanged - [ ] Volume tab compact USD (no raw `T`); unpriced `—`; idle `$0` - [ ] P&L tabs: Best Trade / Most Profit / Most Loss - [ ] Light + dark; ~375px horizontal scroll; last rows not under mobile nav - [ ] `/portfolio` has no leaderboard

PlasticDigits commented

2026-08-26 08:25:03 +00:00

(Migrated from gitlab.com)

mentioned in commit c014fb54ce

mentioned in commit c014fb54cea284335368c982f7935c4935b2087b

PlasticDigits commented

2026-08-26 08:25:03 +00:00

(Migrated from gitlab.com)

added 30 commits

52fbb428...4da8ef0a - 29 commits from branch main
c014fb54 - Merge origin/main into branch for !1167

Compare with previous version

added 30 commits <ul><li>52fbb428...4da8ef0a - 29 commits from branch <code>main</code></li><li>c014fb54 - Merge origin/main into branch for !1167</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/449/diffs?diff_id=1984461773&start_sha=52fbb4286c95699d2ccec11f848037087c8bd8c9)

PlasticDigits commented

2026-08-26 08:25:06 +00:00

(Migrated from gitlab.com)

mentioned in commit bd6484d95d

mentioned in commit bd6484d95d85344ad2513bb7f2d80e4e403ab645