fix(frontend): make Connect Wallet dismissible with labeled Close (#672) #1160

Merged

PlasticDigits merged 2 commits from fix/672-wallet-modal-dismiss into main

2026-08-26 08:13:05 +00:00

PlasticDigits commented

2026-08-26 07:00:43 +00:00

(Migrated from gitlab.com)

Summary

Shared Modal dismisses from the portal root (dimmed page), shows a labeled Close control, pins the header, and scrolls the body so the X is not clipped on short viewports.
Header Connect Wallet toggles closed (or cancels an in-flight connect). Risk acknowledgement stays dismissible={false} (#138). Pairing stack z-[10001] is unchanged (#554).
Invariants D1–D9 documented in docs/frontend.md and skills/AGENTS_FRONTEND_WALLET_CONNECT_MODAL.md. make verify-issue-672.

Closes #672

Test plan

make lint-frontend and make verify-issue-672
Open Connect Wallet from the header on / — labeled Close visible at ~375px and ~1280px, dark and light
Click dimmed page (any side) — dialog unmounts (wallet-connect-modal-portal gone)
Escape closes; Tab stays in the dialog
Click a wallet row / Install — dialog stays
Header Connect Wallet while open closes; second click reopens
Start WalletConnect — Close / backdrop / pairing Cancel / header Cancel clear isConnecting
First-visit risk ack: no Close, backdrop and Escape do nothing
After close, Swap Pay amount and token pickers receive clicks

## Summary - Shared `Modal` dismisses from the portal root (dimmed page), shows a labeled **Close** control, pins the header, and scrolls the body so the X is not clipped on short viewports. - Header **Connect Wallet** toggles closed (or cancels an in-flight connect). Risk acknowledgement stays `dismissible={false}` ([#138](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/138)). Pairing stack `z-[10001]` is unchanged ([#554](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/554)). - Invariants **D1–D9** documented in `docs/frontend.md` and `skills/AGENTS_FRONTEND_WALLET_CONNECT_MODAL.md`. `make verify-issue-672`. Closes #672 ## Test plan - [ ] `make lint-frontend` and `make verify-issue-672` - [ ] Open Connect Wallet from the header on `/` — labeled **Close** visible at ~375px and ~1280px, dark and light - [ ] Click dimmed page (any side) — dialog unmounts (`wallet-connect-modal-portal` gone) - [ ] Escape closes; Tab stays in the dialog - [ ] Click a wallet row / **Install** — dialog stays - [ ] Header **Connect Wallet** while open closes; second click reopens - [ ] Start WalletConnect — Close / backdrop / pairing Cancel / header Cancel clear `isConnecting` - [ ] First-visit risk ack: no Close, backdrop and Escape do nothing - [ ] After close, Swap Pay amount and token pickers receive clicks

PlasticDigits commented

2026-08-26 07:03:07 +00:00

(Migrated from gitlab.com)

mentioned in issue #672

PlasticDigits commented

2026-08-26 08:12:57 +00:00

(Migrated from gitlab.com)

mentioned in commit 0abef946b0

mentioned in commit 0abef946b089046c6c1344993075850e4098738b

PlasticDigits commented

2026-08-26 08:12:58 +00:00

(Migrated from gitlab.com)

added 15 commits

1ba8c8cf...3c07848a - 14 commits from branch main
0abef946 - Merge origin/main into branch for !1160

Compare with previous version

added 15 commits <ul><li>1ba8c8cf...3c07848a - 14 commits from branch <code>main</code></li><li>0abef946 - Merge origin/main into branch for !1160</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/442/diffs?diff_id=1984431034&start_sha=1ba8c8cf7cfe19f5352c00dd7c14368422a7855d)

PlasticDigits commented

2026-08-26 08:13:04 +00:00

(Migrated from gitlab.com)

mentioned in commit bd868e228e

mentioned in commit bd868e228e4d9f4bdb8b884784d6f23ab593240a