Verify #323: fix Phase 8 schema links in agent-phases #493

2026-06-14T12:02:20Z

PlasticDigits commented

2026-06-14 12:02:20 +00:00

(Migrated from gitlab.com)

Summary

Verification of GitLab #323 found one remaining defect: Phase 8 in docs/agent-phases.md linked to ../../schemas/ (parent of repo) instead of ../schemas/ from docs/. This MR fixes those two retired-phase cross-links.

All other #323 acceptance items already pass on main (Phase 14 ci.md pointer, timearena_bot rename, invariants CI-local matrix, vesting removal notes).

Verification checklist (#323)

Acceptance item	Command / check	Result
No stale Phase 14 "propose workflow" prompt	`grep -i 'propose workflow' docs/agent-phases.md` (empty); Phase 14 points to `docs/testing/ci.md`	PASS
Retired phases have no broken links	Phase 7 links: `product/arena-v2.md`, `onchain/treasury-contracts.md` exist; Phase 8 `../schemas/archive/`, `../schemas/CHANGELOG.md` exist after fix	PASS (fixed by this MR)
Invariants doc reflects current registry (no vesting)	`rg DoubPresaleVesting indexer/address-registry.megaeth-mainnet.json` (empty); CI-local matrix present at invariants L11–24	PASS
Bot package/import names consistent with `bots/timearena/`	`timearena_bot` package, `timearena-bot` CLI, `bots-timearena-test` CI job; `start-local-anvil-stack.sh` imports `timearena_bot.swarm_runner`	PASS
`rg timecurve_bot` only in migration/CHANGELOG	`rg timecurve_bot` → `bots/timearena/CHANGELOG.md` + invariants legacy-alias note only	PASS
`pytest` in `bots/timearena/`	`cd bots/timearena && .venv/bin/pytest tests -v` → 18 passed	PASS
Doc anchor gate	`bash scripts/check-doc-anchors.sh`	PASS
Retired-term / timecurve satellite gates	`bash scripts/check-doc-retired-terms.sh` · `bash scripts/check-doc-timecurve-satellite.sh`	PASS

Note

Low Risk
Documentation-only link path correction with no runtime or security impact.

Overview
Corrects Phase 8 retired-phase cross-links in docs/agent-phases.md: historical schema paths now use ../schemas/ instead of ../../schemas/, so they resolve to repo-root schemas/ from docs/ rather than pointing outside the repository.

This closes the remaining #323 checklist item for retired-phase links; no behavior, CI, or code changes.

^{Reviewed by Cursor Bugbot for commit 88a1c405a4. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary Verification of GitLab #323 found one remaining defect: Phase 8 in `docs/agent-phases.md` linked to `../../schemas/` (parent of repo) instead of `../schemas/` from `docs/`. This MR fixes those two retired-phase cross-links. All other #323 acceptance items already pass on `main` (Phase 14 ci.md pointer, timearena_bot rename, invariants CI-local matrix, vesting removal notes). ## Verification checklist (#323) | Acceptance item | Command / check | Result | |-----------------|-----------------|--------| | No stale Phase 14 "propose workflow" prompt | `grep -i 'propose workflow' docs/agent-phases.md` (empty); Phase 14 points to `docs/testing/ci.md` | **PASS** | | Retired phases have no broken links | Phase 7 links: `product/arena-v2.md`, `onchain/treasury-contracts.md` exist; Phase 8 `../schemas/archive/`, `../schemas/CHANGELOG.md` exist after fix | **PASS** (fixed by this MR) | | Invariants doc reflects current registry (no vesting) | `rg DoubPresaleVesting indexer/address-registry.megaeth-mainnet.json` (empty); CI-local matrix present at invariants L11–24 | **PASS** | | Bot package/import names consistent with `bots/timearena/` | `timearena_bot` package, `timearena-bot` CLI, `bots-timearena-test` CI job; `start-local-anvil-stack.sh` imports `timearena_bot.swarm_runner` | **PASS** | | `rg timecurve_bot` only in migration/CHANGELOG | `rg timecurve_bot` → `bots/timearena/CHANGELOG.md` + invariants legacy-alias note only | **PASS** | | `pytest` in `bots/timearena/` | `cd bots/timearena && .venv/bin/pytest tests -v` → 18 passed | **PASS** | | Doc anchor gate | `bash scripts/check-doc-anchors.sh` | **PASS** | | Retired-term / timecurve satellite gates | `bash scripts/check-doc-retired-terms.sh` · `bash scripts/check-doc-timecurve-satellite.sh` | **PASS** |  --- > [!NOTE] > **Low Risk** > Documentation-only link path correction with no runtime or security impact. > > **Overview** > Corrects **Phase 8** retired-phase cross-links in `docs/agent-phases.md`: historical schema paths now use `../schemas/` instead of `../../schemas/`, so they resolve to repo-root `schemas/` from `docs/` rather than pointing outside the repository. > > This closes the remaining #323 checklist item for retired-phase links; no behavior, CI, or code changes. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 88a1c405a434e551b63dbaaabdd0d4e539311315. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

project_80561744_bot_5118c68a88bff95eacb6ab1c47c19cae commented

2026-06-14 12:03:29 +00:00

(Migrated from gitlab.com)

changed the description

project_80561744_bot_5118c68a88bff95eacb6ab1c47c19cae commented

2026-06-14 12:03:34 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-14 12:05:00 +00:00

(Migrated from gitlab.com)

Security review — MR !493

Commit reviewed: 88a1c405a434e551b63dbaaabdd0d4e539311315

Scope: docs/agent-phases.md — Phase 8 retired-phase cross-links corrected from ../../schemas/ to ../schemas/ (two markdown href targets).

Method: Inspected full MR diff; traced whether changed paths introduce injection, authz, SSRF, secret exposure, path traversal, or EVM/contract attack surface. No prior security-review threads on this MR.

Outcome: FINDINGS: 0 medium+

Security review: no medium+ findings on this diff.

Rationale: Change is documentation-only (relative markdown links). Links resolve to in-repo schemas/archive/ and schemas/CHANGELOG.md from docs/; no executable code, CI config, indexer/frontend handlers, shell invocation, or smart-contract logic is modified. Attacker-controlled input does not reach any sink via this change.

Inline threads: None (no findings to anchor).

## Security review — MR !493 **Commit reviewed:** `88a1c405a434e551b63dbaaabdd0d4e539311315` **Scope:** `docs/agent-phases.md` — Phase 8 retired-phase cross-links corrected from `../../schemas/` to `../schemas/` (two markdown href targets). **Method:** Inspected full MR diff; traced whether changed paths introduce injection, authz, SSRF, secret exposure, path traversal, or EVM/contract attack surface. No prior security-review threads on this MR. **Outcome:** **FINDINGS: 0** medium+ Security review: **no medium+ findings** on this diff. **Rationale:** Change is documentation-only (relative markdown links). Links resolve to in-repo `schemas/archive/` and `schemas/CHANGELOG.md` from `docs/`; no executable code, CI config, indexer/frontend handlers, shell invocation, or smart-contract logic is modified. Attacker-controlled input does not reach any sink via this change. **Inline threads:** None (no findings to anchor).

PlasticDigits commented

2026-06-14 12:09:05 +00:00

(Migrated from gitlab.com)

mentioned in commit ee36ffe698

mentioned in commit ee36ffe698ff4051686fe05f7691c9c3feaf69c9

PlasticDigits (Migrated from gitlab.com) merged commit ee36ffe698 into main

2026-06-14 12:09:05 +00:00

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega!493

Rows
Columns