code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

Clean up agent phases, invariants doc, and rename bots to timearena #323

New issue
Closed
opened 2026-06-13 07:34:28 +00:00 by PlasticDigits · 10 comments
PlasticDigits commented 2026-06-13 07:34:28 +00:00 (Migrated from gitlab.com)

Parent

Gap analysis follow-up from #309.

Current codebase

Agent phases:

  • docs/agent-phases.md Phase 14 still says "propose workflow" — docs/testing/ci.md exists. Approved: remove stale Phase 14 prompt.
  • Phases 7–8 retired; Phase 7 links missing docs/product/rabbit-treasury.md. Approved: cleanup retired phase references.

Invariants doc: docs/testing/invariants-and-business-logic.md ~800 lines; no CI-vs-local matrix; stale DoubPresaleVesting / INV-INDEXER-112 entries. Approved: cleanup.

Bots naming drift:

  • Directory: bots/timearena/
  • Python package: bots/timearena/src/timecurve_bot/
  • PyPI/CLI: timecurve-bot in pyproject.toml
  • CI job: bots-timecurve-test in .github/workflows/unit-tests.yml
  • Stack: start-local-anvil-stack.sh imports timecurve_bot.swarm_runner

Approved: rename to consistent timearena naming.

Why needed

Approved housekeeping from gap analysis — reduces agent confusion and drift.

Constraints / guardrails

  • Use existing rename scripts: scripts/rename-timecurve-to-timearena.py, scripts/cleanup-timecurve-identifiers.py where applicable.
  • Update INV-BOTS-245-TIMEARENA after rename.
  • Phase removal: keep historical note, delete copy-paste agent prompts only.

Relevant files

  • docs/agent-phases.md
  • docs/testing/invariants-and-business-logic.md
  • bots/timearena/pyproject.toml, bots/timearena/src/timecurve_bot/
  • .github/workflows/unit-tests.yml
  • scripts/start-local-anvil-stack.sh, scripts/anvil-export-bot-env.sh
  • docs/testing/ci.md

Recommended direction

  1. Remove Phase 14 agent prompt; add pointer to existing ci.md. Clean Phase 7–8 dead links.
  2. Prune invariants: remove vesting, add CI-local matrix table, split oversized sections if needed.
  3. Rename Python package timecurve_bot → timearena_bot (or timearena); update imports, CI job name, CLI entrypoint.

Acceptance criteria

  • No stale Phase 14 "propose workflow" prompt.
  • Retired phases have no broken links.
  • Invariants doc reflects current registry (no vesting).
  • Bot package/import names consistent with bots/timearena/.

Test plan

  • cd bots/timearena && pytest
  • .github/workflows/unit-tests.yml bots job equivalent locally
  • bash scripts/check-doc-anchors.sh

Attack / abuse test plan

  • N/A.

Verification criteria

  • rg timecurve_bot only in migration/CHANGELOG unless intentional alias.
  • pytest passes in bots/timearena/.
## Parent Gap analysis follow-up from [#309](https://gitlab.com/PlasticDigits/yieldomega/-/issues/309). ## Current codebase **Agent phases:** - `docs/agent-phases.md` Phase 14 still says "propose workflow" — `docs/testing/ci.md` exists. Approved: **remove** stale Phase 14 prompt. - Phases 7–8 retired; Phase 7 links missing `docs/product/rabbit-treasury.md`. Approved: cleanup retired phase references. **Invariants doc:** `docs/testing/invariants-and-business-logic.md` ~800 lines; no CI-vs-local matrix; stale `DoubPresaleVesting` / `INV-INDEXER-112` entries. Approved: cleanup. **Bots naming drift:** - Directory: `bots/timearena/` - Python package: `bots/timearena/src/timecurve_bot/` - PyPI/CLI: `timecurve-bot` in `pyproject.toml` - CI job: `bots-timecurve-test` in `.github/workflows/unit-tests.yml` - Stack: `start-local-anvil-stack.sh` imports `timecurve_bot.swarm_runner` Approved: rename to consistent `timearena` naming. ## Why needed Approved housekeeping from gap analysis — reduces agent confusion and drift. ## Constraints / guardrails - Use existing rename scripts: `scripts/rename-timecurve-to-timearena.py`, `scripts/cleanup-timecurve-identifiers.py` where applicable. - Update `INV-BOTS-245-TIMEARENA` after rename. - Phase removal: keep historical note, delete copy-paste agent prompts only. ## Relevant files - `docs/agent-phases.md` - `docs/testing/invariants-and-business-logic.md` - `bots/timearena/pyproject.toml`, `bots/timearena/src/timecurve_bot/` - `.github/workflows/unit-tests.yml` - `scripts/start-local-anvil-stack.sh`, `scripts/anvil-export-bot-env.sh` - `docs/testing/ci.md` ## Recommended direction 1. Remove Phase 14 agent prompt; add pointer to existing `ci.md`. Clean Phase 7–8 dead links. 2. Prune invariants: remove vesting, add CI-local matrix table, split oversized sections if needed. 3. Rename Python package `timecurve_bot` → `timearena_bot` (or `timearena`); update imports, CI job name, CLI entrypoint. ## Acceptance criteria - [ ] No stale Phase 14 "propose workflow" prompt. - [ ] Retired phases have no broken links. - [ ] Invariants doc reflects current registry (no vesting). - [ ] Bot package/import names consistent with `bots/timearena/`. ## Test plan - `cd bots/timearena && pytest` - `.github/workflows/unit-tests.yml` bots job equivalent locally - `bash scripts/check-doc-anchors.sh` ## Attack / abuse test plan - N/A. ## Verification criteria - `rg timecurve_bot` only in migration/CHANGELOG unless intentional alias. - `pytest` passes in `bots/timearena/`.
PlasticDigits commented 2026-06-13 07:34:44 +00:00 (Migrated from gitlab.com)

mentioned in issue #309

mentioned in issue #309
PlasticDigits commented 2026-06-13 12:53:08 +00:00 (Migrated from gitlab.com)

mentioned in commit 1beabde51d

mentioned in commit 1beabde51ddec893a13d43e41a632225eb07c89a
PlasticDigits commented 2026-06-13 12:53:27 +00:00 (Migrated from gitlab.com)

mentioned in merge request !467

mentioned in merge request !467
PlasticDigits commented 2026-06-13 14:09:46 +00:00 (Migrated from gitlab.com)

mentioned in commit 0954d46b30

mentioned in commit 0954d46b3045684de79504123cfe94457bf954f7
PlasticDigits commented 2026-06-14 02:49:16 +00:00 (Migrated from gitlab.com)

mentioned in merge request !478

mentioned in merge request !478
PlasticDigits commented 2026-06-14 02:54:54 +00:00 (Migrated from gitlab.com)

mentioned in commit 5b3bff3869

mentioned in commit 5b3bff3869aec46afa1bb8718b6d47500ebbfad8
PlasticDigits commented 2026-06-14 05:39:16 +00:00 (Migrated from gitlab.com)

mentioned in merge request !487

mentioned in merge request !487
PlasticDigits commented 2026-06-14 12:02:54 +00:00 (Migrated from gitlab.com)

mentioned in merge request !493

mentioned in merge request !493
PlasticDigits commented 2026-06-14 12:09:05 +00:00 (Migrated from gitlab.com)

mentioned in commit ee36ffe698

mentioned in commit ee36ffe698ff4051686fe05f7691c9c3feaf69c9
PlasticDigits commented 2026-06-14 12:14:34 +00:00 (Migrated from gitlab.com)

Verification — issue #323 (PASS)

Verified Clean up agent phases, invariants doc, and rename bots to timearena on main at verify time. No repo changes required; no MR opened.

Acceptance criteria

Criterion Result How verified
No stale Phase 14 "propose workflow" prompt PASS docs/agent-phases.md Phase 14 points to docs/testing/ci.md + testing/strategy.md; no "propose workflow" copy-paste prompt (rg 'propose workflow' → empty)
Retired phases have no broken links PASS Phase 7 links product/arena-v2.md#retired-surfaces + onchain/treasury-contracts.md (no missing rabbit-treasury.md); Phase 8 links schemas/archive/ + schemas/CHANGELOG.md; bash scripts/check-doc-anchors.sh → OK (77 invariants + 13 arena-views anchors)
Invariants doc reflects current registry (no vesting) PASS docs/testing/invariants-and-business-logic.md has CI-vs-local matrix (§11); INV-BOTS-245-TIMEARENA names timearena_bot / timearena-bot / bots-timearena-test; DoubPresaleVesting only in removal invariants (INV-REMOVAL-243, INV-INDEXER-319-REGISTRY-VESTING); indexer/address-registry.megaeth-mainnet.json has no vesting entry
Bot package/import names consistent with bots/timearena/ PASS Package bots/timearena/src/timearena_bot/; pyproject.toml → timearena-bot CLI; .github/workflows/unit-tests.yml job bots-timearena-test; scripts/start-local-anvil-stack.sh imports timearena_bot.swarm_runner

Test plan

Command Result
cd bots/timearena && python3 -m venv .venv && .venv/bin/pip install -e ".[dev]" && .venv/bin/pytest tests -v PASS — 18 passed
CI bots job equivalent (same install + pytest) PASS — matches .github/workflows/unit-tests.yml bots-timearena-test
bash scripts/check-doc-anchors.sh PASS
bash scripts/check-doc-retired-terms.sh PASS
bash scripts/check-doc-timecurve-satellite.sh PASS

Verification criteria

Check Result
rg timecurve_bot only in migration/CHANGELOG unless intentional alias PASS — hits: bots/timearena/CHANGELOG.md (migration note) + docs/testing/invariants-and-business-logic.md (explicit legacy-alias sentence per INV-DOCS-284)
pytest in bots/timearena/ PASS — 18/18

Closing as verified on main.

## Verification — issue #323 (PASS) Verified **Clean up agent phases, invariants doc, and rename bots to timearena** on `main` at verify time. No repo changes required; no MR opened. ### Acceptance criteria | Criterion | Result | How verified | |-----------|--------|--------------| | No stale Phase 14 "propose workflow" prompt | **PASS** | `docs/agent-phases.md` Phase 14 points to `docs/testing/ci.md` + `testing/strategy.md`; no "propose workflow" copy-paste prompt (`rg 'propose workflow'` → empty) | | Retired phases have no broken links | **PASS** | Phase 7 links `product/arena-v2.md#retired-surfaces` + `onchain/treasury-contracts.md` (no missing `rabbit-treasury.md`); Phase 8 links `schemas/archive/` + `schemas/CHANGELOG.md`; `bash scripts/check-doc-anchors.sh` → OK (77 invariants + 13 arena-views anchors) | | Invariants doc reflects current registry (no vesting) | **PASS** | `docs/testing/invariants-and-business-logic.md` has CI-vs-local matrix (§11); `INV-BOTS-245-TIMEARENA` names `timearena_bot` / `timearena-bot` / `bots-timearena-test`; `DoubPresaleVesting` only in removal invariants (`INV-REMOVAL-243`, `INV-INDEXER-319-REGISTRY-VESTING`); `indexer/address-registry.megaeth-mainnet.json` has no vesting entry | | Bot package/import names consistent with `bots/timearena/` | **PASS** | Package `bots/timearena/src/timearena_bot/`; `pyproject.toml` → `timearena-bot` CLI; `.github/workflows/unit-tests.yml` job `bots-timearena-test`; `scripts/start-local-anvil-stack.sh` imports `timearena_bot.swarm_runner` | ### Test plan | Command | Result | |---------|--------| | `cd bots/timearena && python3 -m venv .venv && .venv/bin/pip install -e ".[dev]" && .venv/bin/pytest tests -v` | **PASS** — 18 passed | | CI bots job equivalent (same install + pytest) | **PASS** — matches `.github/workflows/unit-tests.yml` `bots-timearena-test` | | `bash scripts/check-doc-anchors.sh` | **PASS** | | `bash scripts/check-doc-retired-terms.sh` | **PASS** | | `bash scripts/check-doc-timecurve-satellite.sh` | **PASS** | ### Verification criteria | Check | Result | |-------|--------| | `rg timecurve_bot` only in migration/CHANGELOG unless intentional alias | **PASS** — hits: `bots/timearena/CHANGELOG.md` (migration note) + `docs/testing/invariants-and-business-logic.md` (explicit legacy-alias sentence per `INV-DOCS-284`) | | `pytest` in `bots/timearena/` | **PASS** — 18/18 | Closing as verified on `main`.
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-06-14 12:14:35 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
cac-design-issue-544
renovate/configure
No results found.
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega#323
No description provided.