Arena #303 follow-up: docs, skills, frontend TWAP spend tests #450

Merged
PlasticDigits merged 1 commit from local1/303-impl-followup into main 2026-06-09 07:38:37 +00:00
PlasticDigits commented 2026-06-09 07:13:57 +00:00 (Migrated from gitlab.com)

Follow-up to merged !447


Note

Low Risk
Documentation and unit-test coverage only; no contract or runtime frontend behavior changes in this diff.

Overview
Follow-up to merged !447 for GitLab #303 (production charmPriceWad from Kumbaya V3 TWAP on MegaETH 4326, with ARENA_CHARM_PRICE_WAD override and fail-closed deploy; Anvil/DeployDev stay 1000e18).

Docs & agent guidance: Guardrails, play skills, and skills/README.md now spell out the prod vs dev price split and point at INV-TIME-ARENA-CHARM-TWAP-INIT, ArenaCharmPriceTwap.sol, and bash scripts/compute-arena-charm-price-twap.sh. invariants-and-business-logic.md adds anchor §303, ties INV-TIME-ARENA-DOUB-PRICE to TWAP init, and lists the new frontend tests as automated evidence. AGENTS.md fixes the commit-msg hook cross-reference (hook script + test script, not issue #303).

Frontend tests (no app logic changes in this diff): Vitest cases assert buy spend envelopes and reconcileFreshBuySizingFromReads behave correctly when charmPriceWad is TWAP-like (2500 DOUB/CHARM) instead of the dev default, via arenaV2SaleSessionBridge.test.ts and timeArenaBuySubmitSizing.test.ts.

Reviewed by Cursor Bugbot for commit 9390010dea. Bugbot is set up for automated code reviews on this repo. Configure here.

Follow-up to merged !447 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Documentation and unit-test coverage only; no contract or runtime frontend behavior changes in this diff. > > **Overview** > Follow-up to merged !447 for **GitLab #303** (production **`charmPriceWad`** from Kumbaya V3 TWAP on MegaETH **4326**, with **`ARENA_CHARM_PRICE_WAD`** override and fail-closed deploy; Anvil/DeployDev stay **`1000e18`**). > > **Docs & agent guidance:** Guardrails, play skills, and **`skills/README.md`** now spell out the prod vs dev price split and point at **`INV-TIME-ARENA-CHARM-TWAP-INIT`**, **`ArenaCharmPriceTwap.sol`**, and **`bash scripts/compute-arena-charm-price-twap.sh`**. **`invariants-and-business-logic.md`** adds anchor **§303**, ties **`INV-TIME-ARENA-DOUB-PRICE`** to TWAP init, and lists the new frontend tests as automated evidence. **`AGENTS.md`** fixes the commit-msg hook cross-reference (hook script + test script, not issue #303). > > **Frontend tests (no app logic changes in this diff):** Vitest cases assert buy spend envelopes and **`reconcileFreshBuySizingFromReads`** behave correctly when **`charmPriceWad`** is TWAP-like (**2500 DOUB/CHARM**) instead of the dev default, via **`arenaV2SaleSessionBridge.test.ts`** and **`timeArenaBuySubmitSizing.test.ts`**. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 9390010deac4984b1e139944d4c3e4c12945b608. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
project_80561744_bot_5118c68a88bff95eacb6ab1c47c19cae commented 2026-06-09 07:14:06 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
PlasticDigits commented 2026-06-09 07:14:13 +00:00 (Migrated from gitlab.com)

mentioned in issue #303

mentioned in issue #303
project_80561744_bot_5118c68a88bff95eacb6ab1c47c19cae commented 2026-06-09 07:14:17 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
PlasticDigits (Migrated from gitlab.com) merged commit eec8af160d into main 2026-06-09 07:38:37 +00:00
PlasticDigits commented 2026-06-09 07:38:38 +00:00 (Migrated from gitlab.com)

mentioned in commit eec8af160d

mentioned in commit eec8af160d7da6c8c78f5e4b6bcdd77d42b46813
PlasticDigits commented 2026-06-09 09:58:08 +00:00 (Migrated from gitlab.com)

mentioned in merge request !451

mentioned in merge request !451
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega!450
No description provided.