Verify #303: Arena TWAP charm price init #451

2026-06-09T09:57:48Z

PlasticDigits commented

2026-06-09 09:57:48 +00:00

(Migrated from gitlab.com)

QA verification for #303

Note

Low Risk
Mostly tests, docs, and E2E selectors; the sale-session RPC enablement only applies without an indexer URL and restores intended Anvil fallback behavior.

Overview
QA pass for GitLab #303 (production charmPriceWad from Kumbaya TWAP or ARENA_CHARM_PRICE_WAD, fail-closed off MegaETH).

Adds DeployProductionCharmPrice.t.sol so DeployProduction.run() reverts with DeployProduction: set ARENA_CHARM_PRICE_WAD when the override is zero on non-4326 (Anvil). Adds scripts/verify-arena-charm-twap.sh to run TWAP unit tests, MegaETH fork smoke, the ops dry-run script, and that deploy test in one gate. Invariant docs now cite those artifacts.

useArenaSaleSession turns the core display multicall back on when VITE_INDEXER_URL is unset (enabled: Boolean(tc) && !indexerOn) so Anvil E2E can read sale head over RPC; indexer-first behavior when the indexer URL is set is unchanged (#301). indexerFirstDisplay.test.ts matches that rule.

Anvil Playwright helpers/specs follow the unified rate-board pay picker (arena-simple-rate-pay-picker-trigger / portal options) and stable testids (arena-charm-cred-epoch, arena-simple-buy-preview).

^{Reviewed by Cursor Bugbot for commit d8775620e8. Bugbot is set up for automated code reviews on this repo. Configure here.}

QA verification for #303  --- > [!NOTE] > **Low Risk** > Mostly tests, docs, and E2E selectors; the sale-session RPC enablement only applies without an indexer URL and restores intended Anvil fallback behavior. > > **Overview** > QA pass for **GitLab #303** (production **`charmPriceWad`** from Kumbaya TWAP or **`ARENA_CHARM_PRICE_WAD`**, fail-closed off MegaETH). > > Adds **`DeployProductionCharmPrice.t.sol`** so **`DeployProduction.run()`** reverts with **`DeployProduction: set ARENA_CHARM_PRICE_WAD`** when the override is zero on non-4326 (Anvil). Adds **`scripts/verify-arena-charm-twap.sh`** to run TWAP unit tests, MegaETH fork smoke, the ops dry-run script, and that deploy test in one gate. Invariant docs now cite those artifacts. > > **`useArenaSaleSession`** turns the core display multicall back on when **`VITE_INDEXER_URL`** is unset (**`enabled: Boolean(tc) && !indexerOn`**) so Anvil E2E can read sale head over RPC; indexer-first behavior when the indexer URL is set is unchanged (**#301**). **`indexerFirstDisplay.test.ts`** matches that rule. > > Anvil Playwright helpers/specs follow the unified rate-board pay picker (**`arena-simple-rate-pay-picker-trigger`** / portal options) and stable testids (**`arena-charm-cred-epoch`**, **`arena-simple-buy-preview`**). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d8775620e8286006bef4184ef2acb8254974ce7f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

project_80561744_bot_5118c68a88bff95eacb6ab1c47c19cae commented

2026-06-09 09:57:57 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-09 09:58:08 +00:00

(Migrated from gitlab.com)

changed the description

project_80561744_bot_5118c68a88bff95eacb6ab1c47c19cae commented

2026-06-09 09:58:08 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-09 09:58:30 +00:00

(Migrated from gitlab.com)

mentioned in issue #303

PlasticDigits (Migrated from gitlab.com) closed this pull request

2026-06-09 11:40:26 +00:00

PlasticDigits commented

2026-06-11 05:44:54 +00:00

(Migrated from gitlab.com)

mentioned in commit 3db1539c92

mentioned in commit 3db1539c92025a37bf43705f5bc0f989c1d91e44

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega!451

Rows
Columns