docs: verify #300 prize routing — align stale 40/30/30 references #442

Merged

PlasticDigits merged 3 commits from cursor/gitlab-issue-verification-d696 into main 2026-06-08 05:30:40 +00:00

Conversation 8 Commits 3 Files changed 14 +24 -24

PlasticDigits commented 2026-06-07 12:12:26 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

Summary

Verification QA for GitLab #300 — Arena prize routing: 100% to podiums with 70/20/10 epoch tranches.

Implementation merged in 2398a6a (cursor/arena-prize-routing-300-957c). This MR updates stale 40/30/30 documentation that contradicted onchain behavior (security model rounding policy, QA checklists, invariants cross-links, agent guides).

Merge conflict resolution (latest): Merged current main (includes !444 §293 AUDIT copy). Three conflicts in arena-views.md, manual-qa-checklists.md §293, and frontend-content-audit.md — adopted canonical #300-linked wording from main while retaining this MR's broader 40/30/30 fixes across 13 other doc files.

Verification checklist (issue #300)

Acceptance item	Command / evidence	Result
Merge conflicts with main	git merge origin/main on cursor/gitlab-issue-verification-d696	PASS
Stale 40/30/30 refs removed	grep docs for 40/30/30 / 30% admin take (excl. intentional negatives)	PASS
Doc anchors	bash scripts/check-doc-anchors.sh	PASS
100% podium vaults; 0% admin on buy	forge test --match-test test_buy_routes_doub_split	PASS
25% per category (± remainder)	forge test --match-contract ArenaPrizeRouting	PASS (6/6)
70/20/10 epoch tranches	forge test --match-test test_buy_routes_epoch_tranches_worked_example	PASS
Docs + INV-ARENA-PRIZE-ROUTING-*	docs/testing/invariants-and-business-logic.md §300	PASS

Changes in this MR

• Replace obsolete 40/30/30 / 30% admin take copy with 100% podium · 25% × 4 · 70/20/10 epoch tranches · 0% admin on buys across security model, QA checklists, product vision, deployment guide, and agent phase docs.

Closes #300

## Summary Verification QA for [GitLab #300](https://gitlab.com/PlasticDigits/yieldomega/-/work_items/300) — Arena prize routing: **100% to podiums with 70/20/10 epoch tranches**. Implementation merged in `2398a6a` (`cursor/arena-prize-routing-300-957c`). This MR updates **stale 40/30/30 documentation** that contradicted onchain behavior (security model rounding policy, QA checklists, invariants cross-links, agent guides). **Merge conflict resolution (latest):** Merged current `main` (includes !444 §293 AUDIT copy). Three conflicts in `arena-views.md`, `manual-qa-checklists.md` §293, and `frontend-content-audit.md` — adopted canonical **#300-linked** wording from `main` while retaining this MR's broader 40/30/30 fixes across 13 other doc files. ## Verification checklist (issue #300) | Acceptance item | Command / evidence | Result | |-----------------|-------------------|--------| | Merge conflicts with `main` | `git merge origin/main` on `cursor/gitlab-issue-verification-d696` | **PASS** | | Stale 40/30/30 refs removed | grep docs for `40/30/30` / `30% admin take` (excl. intentional negatives) | **PASS** | | Doc anchors | `bash scripts/check-doc-anchors.sh` | **PASS** | | 100% podium vaults; 0% admin on buy | `forge test --match-test test_buy_routes_doub_split` | **PASS** | | 25% per category (± remainder) | `forge test --match-contract ArenaPrizeRouting` | **PASS** (6/6) | | 70/20/10 epoch tranches | `forge test --match-test test_buy_routes_epoch_tranches_worked_example` | **PASS** | | Docs + INV-ARENA-PRIZE-ROUTING-* | `docs/testing/invariants-and-business-logic.md` §300 | **PASS** | ## Changes in this MR - Replace obsolete **40/30/30** / **30% admin take** copy with **100% podium · 25% × 4 · 70/20/10 epoch tranches · 0% admin on buys** across security model, QA checklists, product vision, deployment guide, and agent phase docs. Closes #300

PlasticDigits commented 2026-06-07 12:12:39 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

mentioned in issue #300

mentioned in issue #300

ghost1 commented 2026-06-07 12:15:15 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

Security review

Commit reviewed: ab351709340874323f0e6d56cfc0686679d4b678
Scope: 16 documentation files only — alignment of stale 40/30/30 / 30% admin take copy with onchain #300 prize routing (100% podium · 25% × 4 · 70/20/10 epoch tranches · 0% admin on buys). No changes to contracts, indexer, frontend, scripts, or dependencies.

Method: Full MR diff review; traced security-relevant edits in docs/onchain/security-and-threat-model.md and docs/operations/deployment-guide.md against ArenaBuyRouting.sol (already merged in 2398a6a). Checked for injection, auth/authz, secret leakage, SSRF/XSS/deserialization, and supply-chain deltas — none applicable to this diff.

Outcome: FINDINGS: 0 medium+

This MR corrects documentation to match existing onchain behavior (e.g. rounding policy: category remainder → Time Booster; within-category remainder → +2 tranche; no AdminSellVault funding on buys). It does not alter runtime code paths, permissions, or trust boundaries.

Inline threads: None (no findings to anchor).

Prior review comments on this MR: none security-related.

## Security review **Commit reviewed:** `ab351709340874323f0e6d56cfc0686679d4b678` **Scope:** 16 documentation files only — alignment of stale **40/30/30** / **30% admin take** copy with onchain **#300** prize routing (100% podium · 25% × 4 · 70/20/10 epoch tranches · 0% admin on buys). No changes to contracts, indexer, frontend, scripts, or dependencies. **Method:** Full MR diff review; traced security-relevant edits in `docs/onchain/security-and-threat-model.md` and `docs/operations/deployment-guide.md` against `ArenaBuyRouting.sol` (already merged in `2398a6a`). Checked for injection, auth/authz, secret leakage, SSRF/XSS/deserialization, and supply-chain deltas — none applicable to this diff. **Outcome:** `FINDINGS: 0` medium+ This MR corrects documentation to match existing onchain behavior (e.g. rounding policy: category remainder → Time Booster; within-category remainder → +2 tranche; no AdminSellVault funding on buys). It does not alter runtime code paths, permissions, or trust boundaries. **Inline threads:** None (no findings to anchor). Prior review comments on this MR: none security-related.

ghost1 commented 2026-06-08 05:21:42 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

added 5 commits

• ab351709...c5859b48 - 4 commits from branch main
• feeadcfa - merge main: resolve arena-views.md conflict (keep #300 routing detail)

Compare with previous version

added 5 commits <ul><li>ab351709...c5859b48 - 4 commits from branch <code>main</code></li><li>feeadcfa - merge main: resolve arena-views.md conflict (keep #300 routing detail)</li></ul> [Compare with previous version](/PlasticDigits/yieldomega/-/merge_requests/72/diffs?diff_id=1838903490&start_sha=ab351709340874323f0e6d56cfc0686679d4b678)

PlasticDigits commented 2026-06-08 05:22:28 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

changed the description

changed the description

ghost1 commented 2026-06-08 05:29:51 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

added 4 commits

• feeadcfa...909d63d0 - 3 commits from branch main
• 6d823d57 - merge main: resolve §293 doc conflicts (adopt canonical #300 wording from !444)

Compare with previous version

added 4 commits <ul><li>feeadcfa...909d63d0 - 3 commits from branch <code>main</code></li><li>6d823d57 - merge main: resolve §293 doc conflicts (adopt canonical #300 wording from !444)</li></ul> [Compare with previous version](/PlasticDigits/yieldomega/-/merge_requests/72/diffs?diff_id=1838909986&start_sha=feeadcfa6f3d6d78bb7aa713b5b501d770bd917f)

PlasticDigits commented 2026-06-08 05:30:22 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

changed the description

changed the description

PlasticDigits commented 2026-06-08 05:30:40 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

mentioned in commit ddfaa01f4f

mentioned in commit ddfaa01f4f8edb9b6240ae9106d7498ac2fcaece

PlasticDigits (Migrated from gitlab.com) merged commit ddfaa01f4f into main 2026-06-08 05:30:40 +00:00

PlasticDigits commented 2026-06-08 08:45:13 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

mentioned in commit 212db1ea54

mentioned in commit 212db1ea54b83a791dc77898bdf36d64daf21420

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent:fix_bugfix

  

agent:fix_conflicts

  

agent:fix_security

  

agent:gap_analysis

  

agent:implement

  

agent:open_issues

  

agents

  

agent:security_audit

  

agent:verify

  

area

timecurve

  

arena

  

arena-v2

  

audit

  

block:feature_review

  

block:security

  

bug

  

contracts

  

design

  

devops

  

docs

Documentation

  

documentation

  

enhancement

  

epic

Epic / umbrella issue

  

feature

  

frontend

  

indexer

  

low priority

Low priority, investigate other issues first

  

megaeth

  

operations

  

ops

Deploy and operations

  

performance

  

QA

  

qa checklist

  

referrals

  

removal

Legacy removal

  

security

  

smart-contracts

  

tech-debt

  

testing

  

time-arena

TimeArena v2 revamp

  

timecurve

  

visual-qa

No labels

agent:fix_bugfix

agent:fix_conflicts

agent:fix_security

agent:gap_analysis

agent:implement

agent:open_issues

agents

agent:security_audit

agent:verify

area

timecurve

arena

arena-v2

audit

block:feature_review

block:security

bug

contracts

design

devops

docs

documentation

enhancement

epic

feature

frontend

indexer

low priority

megaeth

operations

ops

performance

QA

qa checklist

referrals

removal

security

smart-contracts

tech-debt

testing

time-arena

timecurve

visual-qa

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega!442

No description provided.