code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

Frontend UX: docs, invariants, and E2E coverage for redesign (#298) #439

Merged
PlasticDigits merged 2 commits from cursor/issue-298-frontend-ux-docs-e2e-0369 into main 2026-06-07 11:57:49 +00:00
Conversation 7 Commits 2 Files changed 11 +316 -4
PlasticDigits commented 2026-06-07 09:53:28 +00:00 (Migrated from gitlab.com)

Summary

Closes the documentation and verification gap for the cyberminimalist PvP command-console redesign (#298). Product mechanics remain canonical in docs/product/time-arena.md; this MR adds reviewer-ready UI copy/layout audit artifacts, consolidates invariants, updates manual QA, and refreshes Playwright selectors for the redesigned surfaces.

Merge conflict resolution: Merged main (includes #297 art/motion/audio) and kept both #297 and #298 invariant rows, manual QA sections, and guardrails cross-links.

Changes

  • New docs/testing/frontend-content-audit.md — page-by-page checklist for every routed surface (home, countdown, /arena, /arena/protocol, referrals, venues, 404, legacy redirects) with canonical TimeArena cross-links
  • Invariant INV-FRONTEND-298-UX-DOCS-E2E + manual QA §298
  • Crosslinks in arena-views.md, design.md, strategy.md, skills/README.md, guardrails skill
  • E2E — surface-shells.spec.ts updated for third-party venue + arena handoff copy; arena.spec.ts asserts Yield Omega branding
  • Unit test frontendContentAudit.test.ts guards audit doc completeness and E2E branding expectations

Acceptance checklist

Criterion Command / step Result
Merge conflicts resolved with main (#297 + #298 coexist) git merge origin/main on MR branch PASS
arena-views.md and design.md describe command-console layout Review §298 sections in both files PASS
Page-by-page content audit covers all routes docs/testing/frontend-content-audit.md + npm test -- frontendContentAudit.test.ts PASS
Manual QA updated for visual + mechanics smoke docs/testing/manual-qa-checklists.md#manual-qa-issue-298 PASS
npm run typecheck, lint, test cd frontend && npm run typecheck && npm run lint && npm test PASS
check-arena-naming.sh bash scripts/check-arena-naming.sh PASS
check-doc-anchors.sh bash scripts/check-doc-anchors.sh PASS
check-art-readme-consumers.sh (#297 from main) bash scripts/check-art-readme-consumers.sh PASS

Verification for 3rd parties

# Unit + static checks
cd frontend && npm run typecheck && npm run lint && npm test
bash scripts/check-arena-naming.sh
bash scripts/check-doc-anchors.sh
bash scripts/check-art-readme-consumers.sh

# Playwright (requires build first)
cd frontend && npm run build
cd frontend && CI=1 npm run test:e2e -- --workers=5 \
  e2e/arena.spec.ts e2e/home.spec.ts e2e/navigation.spec.ts \
  e2e/referrals-surface.spec.ts e2e/footer-site-links.spec.ts \
  e2e/launch-countdown.spec.ts e2e/surface-shells.spec.ts e2e/referral-path.spec.ts

Manual visual pass (optional): follow manual QA §298 with Rabby/Chromium per rabby-cloud-agent-qa.md.

Closes #298

## Summary Closes the documentation and verification gap for the cyberminimalist PvP command-console redesign ([#298](https://gitlab.com/PlasticDigits/yieldomega/-/issues/298)). Product mechanics remain canonical in `docs/product/time-arena.md`; this MR adds reviewer-ready UI copy/layout audit artifacts, consolidates invariants, updates manual QA, and refreshes Playwright selectors for the redesigned surfaces. **Merge conflict resolution:** Merged `main` (includes [#297](https://gitlab.com/PlasticDigits/yieldomega/-/issues/297) art/motion/audio) and kept both `#297` and `#298` invariant rows, manual QA sections, and guardrails cross-links. ### Changes - **New** `docs/testing/frontend-content-audit.md` — page-by-page checklist for every routed surface (home, countdown, `/arena`, `/arena/protocol`, referrals, venues, 404, legacy redirects) with canonical TimeArena cross-links - **Invariant** `INV-FRONTEND-298-UX-DOCS-E2E` + manual QA [§298](docs/testing/manual-qa-checklists.md#manual-qa-issue-298) - **Crosslinks** in `arena-views.md`, `design.md`, `strategy.md`, `skills/README.md`, guardrails skill - **E2E** — `surface-shells.spec.ts` updated for third-party venue + arena handoff copy; `arena.spec.ts` asserts **Yield Omega** branding - **Unit test** `frontendContentAudit.test.ts` guards audit doc completeness and E2E branding expectations ## Acceptance checklist | Criterion | Command / step | Result | |-----------|----------------|--------| | Merge conflicts resolved with `main` (#297 + #298 coexist) | `git merge origin/main` on MR branch | PASS | | `arena-views.md` and `design.md` describe command-console layout | Review §298 sections in both files | PASS | | Page-by-page content audit covers all routes | `docs/testing/frontend-content-audit.md` + `npm test -- frontendContentAudit.test.ts` | PASS | | Manual QA updated for visual + mechanics smoke | `docs/testing/manual-qa-checklists.md#manual-qa-issue-298` | PASS | | `npm run typecheck`, `lint`, `test` | `cd frontend && npm run typecheck && npm run lint && npm test` | PASS | | `check-arena-naming.sh` | `bash scripts/check-arena-naming.sh` | PASS | | `check-doc-anchors.sh` | `bash scripts/check-doc-anchors.sh` | PASS | | `check-art-readme-consumers.sh` (#297 from main) | `bash scripts/check-art-readme-consumers.sh` | PASS | ## Verification for 3rd parties ```bash # Unit + static checks cd frontend && npm run typecheck && npm run lint && npm test bash scripts/check-arena-naming.sh bash scripts/check-doc-anchors.sh bash scripts/check-art-readme-consumers.sh # Playwright (requires build first) cd frontend && npm run build cd frontend && CI=1 npm run test:e2e -- --workers=5 \ e2e/arena.spec.ts e2e/home.spec.ts e2e/navigation.spec.ts \ e2e/referrals-surface.spec.ts e2e/footer-site-links.spec.ts \ e2e/launch-countdown.spec.ts e2e/surface-shells.spec.ts e2e/referral-path.spec.ts ``` Manual visual pass (optional): follow [manual QA §298](docs/testing/manual-qa-checklists.md#manual-qa-issue-298) with Rabby/Chromium per [rabby-cloud-agent-qa.md](docs/testing/rabby-cloud-agent-qa.md). Closes #298
ghost1 commented 2026-06-07 09:56:01 +00:00 (Migrated from gitlab.com)

Security review

Commit reviewed: 2dad0292454b44f7fffcc059bacf57cd759f86d4
Scope: MR !439 — documentation, invariants, manual QA, and Playwright/unit test updates for the cyberminimalist frontend UX redesign (#298). No production application, indexer, or contract code changed.

Outcome: FINDINGS: 0 medium+

Summary

Reviewed all 11 changed files (316 insertions, 4 deletions):

Layer Files Security assessment
Docs frontend-content-audit.md, arena-views.md, design.md, manual-qa-checklists.md, invariants-and-business-logic.md, strategy.md, skills/README.md, guardrails skill Markdown-only; no secrets, credentials, or exploitable runtime behavior introduced
E2E tests arena.spec.ts, surface-shells.spec.ts Assertion/copy selector updates only; no auth bypass or injection surface
Unit test frontendContentAudit.test.ts Reads fixed repo-relative paths via __dirname; no attacker-controlled input

Checks performed

  • Traced all executable code changes for injection, XSS, SSRF, path traversal, authz bypass, and secret leakage — none applicable to this diff.
  • Scanned new audit doc for private keys, tokens, or credentials — none found (only public localStorage key name yieldomega.ref.v1 already documented in referrals product spec).
  • Verified no dependency or supply-chain changes in this MR.
  • No prior security-review inline threads on this MR to re-validate.

Inline threads: none (no medium+ findings).

Automated security review — Cursor Cloud Agent

## Security review **Commit reviewed:** `2dad0292454b44f7fffcc059bacf57cd759f86d4` **Scope:** MR !439 — documentation, invariants, manual QA, and Playwright/unit test updates for the cyberminimalist frontend UX redesign ([#298](https://gitlab.com/PlasticDigits/yieldomega/-/issues/298)). No production application, indexer, or contract code changed. **Outcome:** `FINDINGS: 0` medium+ ### Summary Reviewed all 11 changed files (316 insertions, 4 deletions): | Layer | Files | Security assessment | |-------|-------|-------------------| | Docs | `frontend-content-audit.md`, `arena-views.md`, `design.md`, `manual-qa-checklists.md`, `invariants-and-business-logic.md`, `strategy.md`, `skills/README.md`, guardrails skill | Markdown-only; no secrets, credentials, or exploitable runtime behavior introduced | | E2E tests | `arena.spec.ts`, `surface-shells.spec.ts` | Assertion/copy selector updates only; no auth bypass or injection surface | | Unit test | `frontendContentAudit.test.ts` | Reads fixed repo-relative paths via `__dirname`; no attacker-controlled input | ### Checks performed - Traced all executable code changes for injection, XSS, SSRF, path traversal, authz bypass, and secret leakage — none applicable to this diff. - Scanned new audit doc for private keys, tokens, or credentials — none found (only public localStorage key name `yieldomega.ref.v1` already documented in referrals product spec). - Verified no dependency or supply-chain changes in this MR. - No prior security-review inline threads on this MR to re-validate. **Inline threads:** none (no medium+ findings). --- *Automated security review — Cursor Cloud Agent*
ghost1 commented 2026-06-07 11:50:16 +00:00 (Migrated from gitlab.com)

added 9 commits

  • 2dad0292...a49b3dfb - 8 commits from branch main
  • 383b9794 - Merge origin/main into cursor/issue-298-frontend-ux-docs-e2e-0369

Compare with previous version

added 9 commits <ul><li>2dad0292...a49b3dfb - 8 commits from branch <code>main</code></li><li>383b9794 - Merge origin/main into cursor/issue-298-frontend-ux-docs-e2e-0369</li></ul> [Compare with previous version](/PlasticDigits/yieldomega/-/merge_requests/69/diffs?diff_id=1838486379&start_sha=2dad0292454b44f7fffcc059bacf57cd759f86d4)
PlasticDigits commented 2026-06-07 11:50:25 +00:00 (Migrated from gitlab.com)

changed the description

changed the description
PlasticDigits commented 2026-06-07 11:52:47 +00:00 (Migrated from gitlab.com)

cursor review verbose=true

cursor review verbose=true
ghost1 commented 2026-06-07 11:53:19 +00:00 (Migrated from gitlab.com)

Security review

Commit reviewed: 383b9794067e8326064ceeca264b6a5fadc5bd30
Scope: MR !439 — documentation, invariants, manual QA, and Playwright/unit test updates for the cyberminimalist frontend UX redesign (#298). Diff vs main is 11 files (316 insertions, 4 deletions); no production application, indexer, or contract code changed by this MR.

Outcome: FINDINGS: 0 medium+

Summary

Re-reviewed after merge of origin/main (383b979). MR-specific delta vs main is unchanged in security posture from prior review (2dad029): docs + test assertions only.

Layer Files Security assessment
Docs frontend-content-audit.md, arena-views.md, design.md, manual-qa-checklists.md, invariants-and-business-logic.md, strategy.md, skills/README.md, guardrails skill Markdown-only; no secrets, credentials, or exploitable runtime behavior introduced
E2E tests arena.spec.ts, surface-shells.spec.ts Assertion/copy selector updates only; no auth bypass or injection surface
Unit test frontendContentAudit.test.ts Reads fixed repo-relative paths via __dirname; no attacker-controlled input

Checks performed

  • Traced all executable code changes in the MR diff for injection, XSS, SSRF, path traversal, authz bypass, and secret leakage — none applicable.
  • Scanned new audit doc for private keys, tokens, or credentials — none found (only public localStorage key name yieldomega.ref.v1, already documented in referrals product spec).
  • Verified no dependency or supply-chain changes in this MR.
  • Prior review (2dad029) had zero medium+ findings; merge commit conflict resolution in shared doc files adds #298 sections only — no new attack surface.

Inline threads: none (no medium+ findings).

Automated security review — Cursor Cloud Agent

## Security review **Commit reviewed:** `383b9794067e8326064ceeca264b6a5fadc5bd30` **Scope:** MR !439 — documentation, invariants, manual QA, and Playwright/unit test updates for the cyberminimalist frontend UX redesign ([#298](https://gitlab.com/PlasticDigits/yieldomega/-/issues/298)). Diff vs `main` is 11 files (316 insertions, 4 deletions); no production application, indexer, or contract code changed by this MR. **Outcome:** `FINDINGS: 0` medium+ ### Summary Re-reviewed after merge of `origin/main` (`383b979`). MR-specific delta vs `main` is unchanged in security posture from prior review (`2dad029`): docs + test assertions only. | Layer | Files | Security assessment | |-------|-------|-------------------| | Docs | `frontend-content-audit.md`, `arena-views.md`, `design.md`, `manual-qa-checklists.md`, `invariants-and-business-logic.md`, `strategy.md`, `skills/README.md`, guardrails skill | Markdown-only; no secrets, credentials, or exploitable runtime behavior introduced | | E2E tests | `arena.spec.ts`, `surface-shells.spec.ts` | Assertion/copy selector updates only; no auth bypass or injection surface | | Unit test | `frontendContentAudit.test.ts` | Reads fixed repo-relative paths via `__dirname`; no attacker-controlled input | ### Checks performed - Traced all executable code changes in the MR diff for injection, XSS, SSRF, path traversal, authz bypass, and secret leakage — none applicable. - Scanned new audit doc for private keys, tokens, or credentials — none found (only public localStorage key name `yieldomega.ref.v1`, already documented in referrals product spec). - Verified no dependency or supply-chain changes in this MR. - Prior review (`2dad029`) had zero medium+ findings; merge commit conflict resolution in shared doc files adds #298 sections only — no new attack surface. **Inline threads:** none (no medium+ findings). --- *Automated security review — Cursor Cloud Agent*
PlasticDigits (Migrated from gitlab.com) merged commit 4d26577b8d into main 2026-06-07 11:57:49 +00:00
PlasticDigits commented 2026-06-07 11:58:18 +00:00 (Migrated from gitlab.com)

mentioned in commit 4d26577b8d

mentioned in commit 4d26577b8d332a76db37d773eee95bafaffee182
PlasticDigits commented 2026-06-08 08:45:13 +00:00 (Migrated from gitlab.com)

mentioned in commit 1c01c73b0f

mentioned in commit 1c01c73b0ff45082181cb8cc8fa7122ff6aa44f7
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega!439
No description provided.