docs(art): refresh stale TimeCurve consumer links in art README (#286) #418

Merged

PlasticDigits merged 1 commit from cursor/art-readme-consumer-links-f66a into main 2026-06-03 14:23:32 +00:00

Conversation 8 Commits 1 Files changed 7 +122 -48

PlasticDigits commented 2026-06-03 13:57:05 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

Summary

Fixes #286: frontend/public/art/README.md still linked deleted v1 TimeCurve pages (TimeCurvePage.tsx, TimeCurveArenaView.tsx, TimeCurveBranchPage.tsx) and wrong pages/ArenaSimplePage.tsx paths after #266.

• Re-point Used by columns to live Time Arena surfaces (pages/arena/*, TimeArenaPage).
• Correct renamed cutout filenames (cutout-bunny-girl-*, mascot-bag-bunny-pair.png, etc.).
• Mark unwired / legacy assets as staged or legacy per rg "/art/" frontend/src.
• Add scripts/check-art-readme-consumers.sh (INV-FRONTEND-286-ART-README) and CI gate (alongside existing #284 doc gate).
• Document invariant in docs/testing/invariants-and-business-logic.md, docs/frontend/design.md, guardrails skill.

Rebased onto main (resolved docs/testing/ci.md merge conflict — keeps both #284 and #286 gates).

Docs-only — no product behavior changes.

Acceptance checklist

Criterion	Command / step	Result
No links to deleted TimeCurve*.tsx / timeCurveArena/*	rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage' frontend/public/art/README.md	PASS (empty)
ArenaSimplePage links use pages/arena/ArenaSimplePage.tsx	rg -n 'pages/ArenaSimplePage\.tsx' frontend/public/art/README.md	PASS (empty)
Every linked ../../src/*.tsx path exists	bash scripts/check-art-readme-consumers.sh	PASS
CI doc gates (#284 + #286)	bash scripts/check-doc-timecurve-satellite.sh · bash scripts/check-art-readme-consumers.sh	PASS
No product behavior changes	Docs-only diff	PASS

Verification for 3rd parties

rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md
bash scripts/check-art-readme-consumers.sh
rg '/art/' frontend/src

Issue left open until MR merge.

## Summary Fixes [#286](https://gitlab.com/PlasticDigits/yieldomega/-/issues/286): `frontend/public/art/README.md` still linked deleted v1 TimeCurve pages (`TimeCurvePage.tsx`, `TimeCurveArenaView.tsx`, `TimeCurveBranchPage.tsx`) and wrong `pages/ArenaSimplePage.tsx` paths after [#266](https://gitlab.com/PlasticDigits/yieldomega/-/issues/266). - Re-point **Used by** columns to live Time Arena surfaces (`pages/arena/*`, `TimeArenaPage`). - Correct renamed cutout filenames (`cutout-bunny-girl-*`, `mascot-bag-bunny-pair.png`, etc.). - Mark unwired / legacy assets as _staged_ or _legacy_ per `rg "/art/" frontend/src`. - Add `scripts/check-art-readme-consumers.sh` (**INV-FRONTEND-286-ART-README**) and CI gate (alongside existing #284 doc gate). - Document invariant in `docs/testing/invariants-and-business-logic.md`, `docs/frontend/design.md`, guardrails skill. Rebased onto `main` (resolved `docs/testing/ci.md` merge conflict — keeps both #284 and #286 gates). Docs-only — no product behavior changes. ## Acceptance checklist | Criterion | Command / step | Result | |-----------|----------------|--------| | No links to deleted `TimeCurve*.tsx` / `timeCurveArena/*` | `rg -n 'TimeCurvePage\|TimeCurveArenaView\|TimeCurveBranchPage' frontend/public/art/README.md` | **PASS** (empty) | | `ArenaSimplePage` links use `pages/arena/ArenaSimplePage.tsx` | `rg -n 'pages/ArenaSimplePage\.tsx' frontend/public/art/README.md` | **PASS** (empty) | | Every linked `../../src/*.tsx` path exists | `bash scripts/check-art-readme-consumers.sh` | **PASS** | | CI doc gates (#284 + #286) | `bash scripts/check-doc-timecurve-satellite.sh` · `bash scripts/check-art-readme-consumers.sh` | **PASS** | | No product behavior changes | Docs-only diff | **PASS** | ## Verification for 3rd parties ```bash rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md bash scripts/check-art-readme-consumers.sh rg '/art/' frontend/src ``` Issue left **open** until MR merge.

PlasticDigits commented 2026-06-03 13:57:17 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

changed the description

changed the description

ghost1 commented 2026-06-03 14:01:18 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

Security review

Commit reviewed: eb332ba53d745840569b2976ddc82e5ce6431b2e
Scope: Docs-only MR — art README consumer link refresh (#286), new CI lint script scripts/check-art-readme-consumers.sh, workflow/doc/invariant updates. No application runtime, auth, or onchain code changes.

Outcome: FINDINGS: 0 medium+

Security review: no medium+ findings on this diff.

Review notes

• Changes are limited to markdown documentation, a read-only bash CI gate, and a single scripts-smoke workflow step.
• check-art-readme-consumers.sh reads a fixed README path, uses rg/-f existence checks only — no eval, network I/O, or secret handling. Path segments from markdown links are constrained to ../../src/... and used only for file existence validation in CI.
• No new dependencies, secrets, or user-facing executable code.

No inline finding threads (nothing to attach).

## Security review **Commit reviewed:** `eb332ba53d745840569b2976ddc82e5ce6431b2e` **Scope:** Docs-only MR — art README consumer link refresh (#286), new CI lint script `scripts/check-art-readme-consumers.sh`, workflow/doc/invariant updates. No application runtime, auth, or onchain code changes. **Outcome:** `FINDINGS: 0` medium+ Security review: no medium+ findings on this diff. ### Review notes - Changes are limited to markdown documentation, a read-only bash CI gate, and a single `scripts-smoke` workflow step. - `check-art-readme-consumers.sh` reads a fixed README path, uses `rg`/`-f` existence checks only — no eval, network I/O, or secret handling. Path segments from markdown links are constrained to `../../src/...` and used only for file existence validation in CI. - No new dependencies, secrets, or user-facing executable code. No inline finding threads (nothing to attach).

PlasticDigits commented 2026-06-03 14:10:15 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

changed the description

changed the description

ghost1 commented 2026-06-03 14:10:21 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

added 7 commits

• eb332ba5...0b2cbc02 - 6 commits from branch main
• 7669b1c6 - docs(art): refresh art README consumer links for Time Arena (#286)

Compare with previous version

added 7 commits <ul><li>eb332ba5...0b2cbc02 - 6 commits from branch <code>main</code></li><li>7669b1c6 - docs(art): refresh art README consumer links for Time Arena (#286)</li></ul> [Compare with previous version](/PlasticDigits/yieldomega/-/merge_requests/48/diffs?diff_id=1832565260&start_sha=eb332ba53d745840569b2976ddc82e5ce6431b2e)

ghost1 commented 2026-06-03 14:13:55 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

Security review (update)

Commit reviewed: 7669b1c6ec3b6a957a4c4661205cdc432f8a825e
Base: 0b2cbc0220a156d8d62bdf4e1eb2d9f198bef329
Scope: Docs-only MR — art README consumer link refresh (#286), new CI lint script scripts/check-art-readme-consumers.sh, workflow/doc/invariant updates. No application runtime, auth, indexer, contract, or onchain code changes.

Outcome: FINDINGS: 0 medium+

Security review: no medium+ findings on this diff.

Review notes

• Re-reviewed after rebase onto main; security-relevant delta is unchanged from prior review (eb332ba5).
• Changes are limited to markdown documentation, a read-only bash CI gate, and one scripts-smoke workflow step.
• check-art-readme-consumers.sh reads a fixed README path, uses rg and -f existence checks only — no eval, network I/O, secret handling, or user-controlled execution paths. Markdown link targets are constrained to ../../src/... and used only for file-existence validation in CI.
• No new dependencies, secrets, or user-facing executable code.

No inline finding threads (nothing to attach).

## Security review (update) **Commit reviewed:** `7669b1c6ec3b6a957a4c4661205cdc432f8a825e` **Base:** `0b2cbc0220a156d8d62bdf4e1eb2d9f198bef329` **Scope:** Docs-only MR — art README consumer link refresh ([#286](https://gitlab.com/PlasticDigits/yieldomega/-/issues/286)), new CI lint script `scripts/check-art-readme-consumers.sh`, workflow/doc/invariant updates. No application runtime, auth, indexer, contract, or onchain code changes. **Outcome:** `FINDINGS: 0` medium+ Security review: no medium+ findings on this diff. ### Review notes - Re-reviewed after rebase onto `main`; security-relevant delta is unchanged from prior review (`eb332ba5`). - Changes are limited to markdown documentation, a read-only bash CI gate, and one `scripts-smoke` workflow step. - `check-art-readme-consumers.sh` reads a fixed README path, uses `rg` and `-f` existence checks only — no `eval`, network I/O, secret handling, or user-controlled execution paths. Markdown link targets are constrained to `../../src/...` and used only for file-existence validation in CI. - No new dependencies, secrets, or user-facing executable code. No inline finding threads (nothing to attach).

PlasticDigits commented 2026-06-03 14:23:33 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

mentioned in commit fecfb2dbad

mentioned in commit fecfb2dbadf06e66d273605771fd9a351abe20de

PlasticDigits (Migrated from gitlab.com) merged commit fecfb2dbad into main 2026-06-03 14:23:33 +00:00

PlasticDigits commented 2026-06-03 14:24:38 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

mentioned in merge request !421

mentioned in merge request !421

PlasticDigits commented 2026-06-08 08:45:13 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

mentioned in commit 3957cb6ed4

mentioned in commit 3957cb6ed43b5fe427fd1f5e55d64d905a5ba37e

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent:fix_bugfix

  

agent:fix_conflicts

  

agent:fix_security

  

agent:gap_analysis

  

agent:implement

  

agent:open_issues

  

agents

  

agent:security_audit

  

agent:verify

  

area

timecurve

  

arena

  

arena-v2

  

audit

  

block:feature_review

  

block:security

  

bug

  

contracts

  

design

  

devops

  

docs

Documentation

  

documentation

  

enhancement

  

epic

Epic / umbrella issue

  

feature

  

frontend

  

indexer

  

low priority

Low priority, investigate other issues first

  

megaeth

  

operations

  

ops

Deploy and operations

  

performance

  

QA

  

qa checklist

  

referrals

  

removal

Legacy removal

  

security

  

smart-contracts

  

tech-debt

  

testing

  

time-arena

TimeArena v2 revamp

  

timecurve

  

visual-qa

No labels

agent:fix_bugfix

agent:fix_conflicts

agent:fix_security

agent:gap_analysis

agent:implement

agent:open_issues

agents

agent:security_audit

agent:verify

area

timecurve

arena

arena-v2

audit

block:feature_review

block:security

bug

contracts

design

devops

docs

documentation

enhancement

epic

feature

frontend

indexer

low priority

megaeth

operations

ops

performance

QA

qa checklist

referrals

removal

security

smart-contracts

tech-debt

testing

time-arena

timecurve

visual-qa

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega!418

No description provided.