code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

docs(art): refresh stale TimeCurvePage consumer links in public/art/README.md #286

New issue
Closed
opened 2026-06-03 13:41:13 +00:00 by PlasticDigits · 8 comments
PlasticDigits commented 2026-06-03 13:41:13 +00:00 (Migrated from gitlab.com)

Summary

frontend/public/art/README.md still documents asset consumers under removed TimeCurve v1 pages. After #266 (TimeCurvePage.tsx, timeCurveArena/TimeCurveArenaView.tsx, TimeCurveBranchPage.tsx deleted), those markdown links 404 in the repo and mislead contributors running art audits.

Discovered during agent verification of #266 (MR !412 follow-up).

Stale references (grep 2026-06-03)

Removed path Rows in art/README.md (approx.)
TimeCurvePage.tsx 9 cutout rows + 4 WarBow icon rows
TimeCurveArenaView.tsx 3 rows (tokens, conversion arrow)
TimeCurveBranchPage.tsx 2 rows (loading-mascot-ring)
Wrong ArenaSimplePage.tsx path Several rows point at ../../src/pages/ArenaSimplePage.tsx; file lives at ../../src/pages/arena/ArenaSimplePage.tsx

Expected direction

  1. Re-point “Used in” columns to current Arena surfaces, e.g.:
  2. Confirm each asset path with rg '/art/…' in frontend/src (source of truth).
  3. Drop prose that says “TimeCurve” where the product name is Time Arena (#266 naming).
  4. Optional: add a one-line note at top of README that v1 TimeCurve pages were retired (#266).

Acceptance criteria

  • No markdown links under frontend/public/art/README.md target deleted TimeCurve*.tsx / timeCurveArena/* files.
  • ArenaSimplePage links use pages/arena/ArenaSimplePage.tsx.
  • Spot-check: every linked .tsx path exists on main.
  • No new product behavior changes — docs-only.

Test plan

# Broken consumer links (should be empty after fix)
rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md

# Verify each unique ../../src/... link resolves
# (manual or small script)

Out of scope

  • Full timecurve-* CSS/class rename (#280).
  • Regenerating art assets.
## Summary [`frontend/public/art/README.md`](https://gitlab.com/PlasticDigits/yieldomega/-/blob/main/frontend/public/art/README.md) still documents asset consumers under **removed TimeCurve v1** pages. After [#266](https://gitlab.com/PlasticDigits/yieldomega/-/issues/266) (`TimeCurvePage.tsx`, `timeCurveArena/TimeCurveArenaView.tsx`, `TimeCurveBranchPage.tsx` deleted), those markdown links 404 in the repo and mislead contributors running art audits. Discovered during agent verification of #266 ([MR !412](https://gitlab.com/PlasticDigits/yieldomega/-/merge_requests/42) follow-up). ## Stale references (grep 2026-06-03) | Removed path | Rows in `art/README.md` (approx.) | |--------------|-----------------------------------| | `TimeCurvePage.tsx` | 9 cutout rows + 4 WarBow icon rows | | `TimeCurveArenaView.tsx` | 3 rows (tokens, conversion arrow) | | `TimeCurveBranchPage.tsx` | 2 rows (`loading-mascot-ring`) | | Wrong `ArenaSimplePage.tsx` path | Several rows point at `../../src/pages/ArenaSimplePage.tsx`; file lives at `../../src/pages/arena/ArenaSimplePage.tsx` | ## Expected direction 1. Re-point **“Used in”** columns to current Arena surfaces, e.g.: - [`TimeArenaPage.tsx`](frontend/src/pages/TimeArenaPage.tsx) - [`arena/ArenaSimplePage.tsx`](frontend/src/pages/arena/ArenaSimplePage.tsx), [`ArenaSimplePodiumSection.tsx`](frontend/src/pages/arena/ArenaSimplePodiumSection.tsx), WarBow/buy components under `frontend/src/pages/arena/` 2. Confirm each asset path with `rg '/art/…'` in `frontend/src` (source of truth). 3. Drop prose that says “TimeCurve” where the product name is **Time Arena** (#266 naming). 4. Optional: add a one-line note at top of README that v1 TimeCurve pages were retired ([#266](https://gitlab.com/PlasticDigits/yieldomega/-/issues/266)). ## Acceptance criteria - [ ] No markdown links under `frontend/public/art/README.md` target deleted `TimeCurve*.tsx` / `timeCurveArena/*` files. - [ ] `ArenaSimplePage` links use `pages/arena/ArenaSimplePage.tsx`. - [ ] Spot-check: every linked `.tsx` path exists on `main`. - [ ] No new product behavior changes — docs-only. ## Test plan ```bash # Broken consumer links (should be empty after fix) rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md # Verify each unique ../../src/... link resolves # (manual or small script) ``` ## Out of scope - Full `timecurve-*` CSS/class rename ([#280](https://gitlab.com/PlasticDigits/yieldomega/-/issues/280)). - Regenerating art assets.
PlasticDigits commented 2026-06-03 13:41:14 +00:00 (Migrated from gitlab.com)

marked as related to #266

marked as related to #266
ghost1 commented 2026-06-03 13:56:35 +00:00 (Migrated from gitlab.com)

mentioned in commit eb332ba53d745840569b2976ddc82e5ce6431b2e

mentioned in commit eb332ba53d745840569b2976ddc82e5ce6431b2e
PlasticDigits commented 2026-06-03 13:57:06 +00:00 (Migrated from gitlab.com)

mentioned in merge request !418

mentioned in merge request !418
ghost1 commented 2026-06-03 14:10:20 +00:00 (Migrated from gitlab.com)

mentioned in commit 7669b1c6ec

mentioned in commit 7669b1c6ec3b6a957a4c4661205cdc432f8a825e
PlasticDigits commented 2026-06-03 14:23:33 +00:00 (Migrated from gitlab.com)

mentioned in commit fecfb2dbad

mentioned in commit fecfb2dbadf06e66d273605771fd9a351abe20de
PlasticDigits commented 2026-06-03 14:44:48 +00:00 (Migrated from gitlab.com)

Verification (Cloud Agent) — all acceptance criteria PASS on main

No additional MR needed: implementation landed in 7669b1c (docs(art): refresh art README consumer links for Time Arena (#286), merged via cursor/art-readme-consumer-links-f66a).

Acceptance checklist

Criterion Command / step Result
No links to deleted TimeCurve*.tsx / timeCurveArena/* rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md PASS (empty)
ArenaSimplePage uses pages/arena/ArenaSimplePage.tsx rg 'ArenaSimplePage' frontend/public/art/README.md PASS (4 rows → ../../src/pages/arena/ArenaSimplePage.tsx)
Every linked ../../src/... path exists on main bash scripts/check-art-readme-consumers.sh PASS (31 consumer paths resolve)
Docs-only (no product behavior) diff scope of #286 merge PASS
Optional v1 retirement note at README top read frontend/public/art/README.md L7 PASS
Invariant + CI gate documented INV-FRONTEND-286-ART-README, docs/frontend/design.md, docs/testing/invariants-and-business-logic.md, .github/workflows/unit-tests.yml scripts-smoke PASS

Commands run (2026-06-03)

rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md
# (no output)

bash scripts/check-art-readme-consumers.sh
# [check-art-readme-consumers] OK — 31 consumer .tsx/.ts path(s), no stale TimeCurve links.

Third-party re-verify

bash scripts/check-art-readme-consumers.sh
rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md

Closing as satisfied on main — no open blockers.

## Verification (Cloud Agent) — all acceptance criteria **PASS** on `main` No additional MR needed: implementation landed in **7669b1c** (`docs(art): refresh art README consumer links for Time Arena (#286)`, merged via `cursor/art-readme-consumer-links-f66a`). ### Acceptance checklist | Criterion | Command / step | Result | |-----------|----------------|--------| | No links to deleted `TimeCurve*.tsx` / `timeCurveArena/*` | `rg -n 'TimeCurvePage\|TimeCurveArenaView\|TimeCurveBranchPage\|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md` | **PASS** (empty) | | `ArenaSimplePage` uses `pages/arena/ArenaSimplePage.tsx` | `rg 'ArenaSimplePage' frontend/public/art/README.md` | **PASS** (4 rows → `../../src/pages/arena/ArenaSimplePage.tsx`) | | Every linked `../../src/...` path exists on `main` | `bash scripts/check-art-readme-consumers.sh` | **PASS** (31 consumer paths resolve) | | Docs-only (no product behavior) | diff scope of #286 merge | **PASS** | | Optional v1 retirement note at README top | read `frontend/public/art/README.md` L7 | **PASS** | | Invariant + CI gate documented | `INV-FRONTEND-286-ART-README`, `docs/frontend/design.md`, `docs/testing/invariants-and-business-logic.md`, `.github/workflows/unit-tests.yml` scripts-smoke | **PASS** | ### Commands run (2026-06-03) ```bash rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md # (no output) bash scripts/check-art-readme-consumers.sh # [check-art-readme-consumers] OK — 31 consumer .tsx/.ts path(s), no stale TimeCurve links. ``` ### Third-party re-verify ```bash bash scripts/check-art-readme-consumers.sh rg -n 'TimeCurvePage|TimeCurveArenaView|TimeCurveBranchPage|pages/ArenaSimplePage\.tsx' frontend/public/art/README.md ``` Closing as satisfied on `main` — no open blockers.
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-06-03 14:44:56 +00:00
PlasticDigits commented 2026-06-08 08:45:13 +00:00 (Migrated from gitlab.com)

mentioned in commit 3957cb6ed4

mentioned in commit 3957cb6ed43b5fe427fd1f5e55d64d905a5ba37e
PlasticDigits commented 2026-06-08 08:45:13 +00:00 (Migrated from gitlab.com)

mentioned in commit b36900cda6

mentioned in commit b36900cda69da18ee8e008b73d1c6bc7a2aaf926
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
cac-design-issue-544
renovate/configure
No results found.
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega#286
No description provided.