code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

Arena buys API: full BuyItem parity (new_deadline, buy_index, block_timestamp, log_index) #283

New issue
Closed
opened 2026-06-03 11:40:12 +00:00 by PlasticDigits · 10 comments
PlasticDigits commented 2026-06-03 11:40:12 +00:00 (Migrated from gitlab.com)

Context / parent

Follow-up to #282 (expose actual_seconds_added on GET /v1/arena/buys for timer-extension chip / #258 QA). That issue intentionally scoped to actual_seconds_added only. This issue completes the core log-identify + timer metadata slice of frontend BuyItem parity from the arena buys endpoint.

Related: #254 (arena schema), #258 (wallet profile / buy detail UX), #255 (wallet stats already reads full buy rows from SQL).

Current codebase

Indexer — persisted but partially exposed

  • Table idx_arena_buy (indexer/migrations/20240601000000_arena_v2.up.sql) stores new_deadline, buy_index, block_timestamp, log_index, plus total_doub_raised_after, actual_seconds_added, etc. Primary key (tx_hash, log_index).
  • Ingest from TimeArena Buy logs: indexer/src/decoder.rs, indexer/src/persist.rs.
  • GET /v1/arena/buys (indexer/src/api_arena.rs arena_buys): after #282, exposes buyer, charm_wad, doub_paid, block_number, tx_hash, timer_hard_reset, paid_with_cred, actual_seconds_added. Still omits new_deadline, buy_index, block_timestamp, log_index at the HTTP boundary.
  • Peer pattern: GET /v1/arena/vault-funding/* and GET /v1/arena/podium-pool-donations already emit block_timestamp as unix-sec strings via EXTRACT(EPOCH FROM block_timestamp)::text (api_arena.rs).
  • Wallet stats SQL already selects new_deadline, actual_seconds_added, etc. (indexer/src/arena_wallet_stats.rs).

Frontend — BuyItem expects fields; mapper stubs them

Verify scripts

  • scripts/verify-wallet-profile-anvil.sh (#282) asserts actual_seconds_added + wallet stats; should gain DB/API parity checks for the four fields (or extend a dedicated verify-arena-buys-parity-anvil.sh if cleaner).

Why this is needed

  1. Correct React keys & SFX dedupe: Colliding log_index: 0 for every row can cause list reuse bugs and missed peer-buy head SFX when multiple logs share UX assumptions.
  2. Buy detail / protocol transparency: Users opening buy detail or protocol views should see real new deadline and buy index from ingest, not placeholders.
  3. Contract drift: Frontend types and tests assume a full buy row; the indexer HTTP layer is still the missing link for identity + timer metadata (seconds field addressed in #282).
  4. Agent/CI hygiene: One hermetic assertion that API JSON matches idx_arena_buy for all core columns reduces ad-hoc psql/curl debugging.

Constraints & guardrails

  • Onchain authority: Values must match decoded Buy logs in DB; indexer projects only — no client-side recomputation of deadlines or buy index.
  • AGPL on scripts/docs; SPDX header on any new verify script.
  • No legacy /v1/timecurve/* — arena routes only (#266).
  • Indexer ingest: One SQL transaction per block (#140); tests must not weaken rollback/idempotency.
  • Public API errors: DB failures → generic HTTP 500 (#157).
  • block_timestamp encoding: Prefer unix seconds string (nullable) consistent with vault-funding / donate-pools endpoints — not raw ISO in JSON unless documented and mirrored everywhere.
  • log_index encoding: JSON number (matches BuyItem.log_index: number); DB INT; stable per (tx_hash, log_index) PK.
  • new_deadline / buy_index: Decimal strings (same pattern as charm_wad / actual_seconds_added).
  • Scope boundary (this issue): Expose new_deadline, buy_index, block_timestamp, log_index only. Out of scope unless trivial: total_doub_raised_after, BP breakdown fields, block_hash, contract_address, price_per_charm_wad — track separately if product needs full legacy BuyItem parity.

Prerequisite: Merge/deploy #282 (actual_seconds_added) first.

Recommended solution direction

A. Indexer — extend GET /v1/arena/buys

  1. Add to SELECT: new_deadline::text, buy_index::text, log_index, EXTRACT(EPOCH FROM block_timestamp)::text AS block_timestamp (nullable).
  2. Emit JSON: new_deadline, buy_index, log_index, block_timestamp (omit or null when block_timestamp IS NULL — document behavior).
  3. Extend integration_stage2 fixture: persisted buy with known values → HTTP asserts all four (+ #282 actual_seconds_added) match DB.
  4. Document in docs/indexer/design.md § arena buys; add INV-INDEXER-*-ARENA-BUYS-PARITY (or extend INV-INDEXER-282-ARENA-BUYS-SECONDS) in docs/testing/invariants-and-business-logic.md.

B. Frontend — pass-through

  1. Extend ArenaBuyItem with the four fields (types aligned with JSON).
  2. Map in mapArenaBuyToBuyItem; audit direct fetchArenaBuys consumers.
  3. Extend indexerApi.test.ts fixture JSON.

C. Verify script

Relevant files

Area Files
Indexer API indexer/src/api_arena.rs
Indexer tests indexer/tests/integration_stage2.rs
Schema indexer/migrations/20240601000000_arena_v2.up.sql
Frontend API/types frontend/src/lib/indexerApi.ts
Play / audit UI ArenaBuyModals.tsx, timeArenaUx.ts, live-buy sections
Verify scripts/verify-wallet-profile-anvil.sh
Docs docs/indexer/design.md, docs/testing/invariants-and-business-logic.md

Acceptance criteria

  • GET /v1/arena/buys items include new_deadline, buy_index, log_index, block_timestamp (unix sec string or documented null).
  • After Anvil DOUB buy, each field in API matches idx_arena_buy for that tx_hash / log_index.
  • fetchArenaBuysAsBuyItems surfaces all four on BuyItem (non-zero log_index when chain emitted non-zero).
  • Live-buy lists use stable tx_hash + log_index keys (no longer all log_index: 0 from mapper).
  • Buy detail modal shows new_deadline when present (existing UnixTimestampDisplay path).
  • Hermetic verify script exits 0 with parity assertions (documents PATH for Foundry + Cargo ≥ 1.85).
  • Invariants/docs updated with verify command + indexer invariant row.

Test plan — functional paths

Path Steps Expected
Happy — DOUB buy DeployDev → buy → poll /v1/arena/buys All four fields present; log_index matches receipt log index
block_timestamp null Fixture/log without block time (if possible in test) API returns null/omitted per spec; frontend tolerates
Pagination limit / offset Fields on every returned row
Multi-log same tx Two Buy logs same tx (if testable) Distinct log_index; unique React keys
CRED buy buyWithCred Fields present from ingest
Empty table Fresh DB items: [] — no error
Frontend mapper indexerApi.test.ts Mapped BuyItem matches fixture
Verify script Run twice on clean ports Idempotent pass

Automated:

  • cd indexer && cargo clippy --all-targets -- -D warnings && cargo test
  • cd frontend && npm run typecheck && npm test -- indexerApi
  • bash scripts/verify-wallet-profile-anvil.sh (extended) or new parity script

Test plan — attack / abuse / misuse

Vector Risk Mitigation / test
Oversized numeric strings JSON bloat / BigInt throw Return DB text as-is; test realistic new_deadline / buy_index magnitudes
Negative or malformed DB numerics Broken UI Decoder/persist should prevent; API must not invent values
log_index confusion Wrong row keyed Assert PK (tx_hash, log_index) round-trip in integration test
block_timestamp spoofing Misleading “time of buy” Value is ingest-time RPC block time, not authoritative chain head — document derived-only
Rate limit / large limit DoS Existing clamp 1–200; verify uses small limit
Verify script port hijack Wrong chain Dedicated ANVIL_PORT / INDEXER_PORT; assert chainId == 31337
Duplicate React keys UI corruption Integration/frontend test: two rows same tx_hash, different log_index → distinct keys

Verification criteria (sign-off)

  1. curl -s http://127.0.0.1:<indexer>/v1/arena/buys?limit=1 | jq '.items[0] | {new_deadline,buy_index,log_index,block_timestamp}' — populated after buy.
  2. psql: SELECT new_deadline::text, buy_index::text, log_index, EXTRACT(EPOCH FROM block_timestamp)::text FROM idx_arena_buy ORDER BY block_number DESC LIMIT 1 matches API.
  3. Browser: open buy detail from live buys — New deadline shows real unix time (not 0).
  4. Hermetic verify script — exit 0 with parity log lines.
  5. cargo test + npm run typecheck green in touched packages.

Related issues

  • #282 — actual_seconds_added (prerequisite)
  • #258 — wallet profile / buy surfaces
  • #254 — arena schema / HTTP
  • #255 — wallet stats (already uses SQL buy rows)
## Context / parent Follow-up to [**#282**](https://gitlab.com/PlasticDigits/yieldomega/-/issues/282) (expose `actual_seconds_added` on `GET /v1/arena/buys` for timer-extension chip / #258 QA). That issue intentionally scoped to **`actual_seconds_added`** only. This issue completes the **core log-identify + timer metadata** slice of frontend **`BuyItem`** parity from the arena buys endpoint. Related: [**#254**](https://gitlab.com/PlasticDigits/yieldomega/-/issues/254) (arena schema), [**#258**](https://gitlab.com/PlasticDigits/yieldomega/-/issues/258) (wallet profile / buy detail UX), [**#255**](https://gitlab.com/PlasticDigits/yieldomega/-/issues/255) (wallet stats already reads full buy rows from SQL). --- ## Current codebase ### Indexer — persisted but partially exposed - Table **`idx_arena_buy`** ([`indexer/migrations/20240601000000_arena_v2.up.sql`](indexer/migrations/20240601000000_arena_v2.up.sql)) stores **`new_deadline`**, **`buy_index`**, **`block_timestamp`**, **`log_index`**, plus **`total_doub_raised_after`**, **`actual_seconds_added`**, etc. Primary key **`(tx_hash, log_index)`**. - Ingest from **`TimeArena` `Buy`** logs: [`indexer/src/decoder.rs`](indexer/src/decoder.rs), [`indexer/src/persist.rs`](indexer/src/persist.rs). - **`GET /v1/arena/buys`** ([`indexer/src/api_arena.rs`](indexer/src/api_arena.rs) `arena_buys`): after #282, exposes `buyer`, `charm_wad`, `doub_paid`, `block_number`, `tx_hash`, `timer_hard_reset`, `paid_with_cred`, **`actual_seconds_added`**. Still **omits** `new_deadline`, `buy_index`, `block_timestamp`, `log_index` at the HTTP boundary. - Peer pattern: **`GET /v1/arena/vault-funding/*`** and **`GET /v1/arena/podium-pool-donations`** already emit **`block_timestamp`** as unix-sec strings via `EXTRACT(EPOCH FROM block_timestamp)::text` ([`api_arena.rs`](indexer/src/api_arena.rs)). - Wallet stats SQL already selects `new_deadline`, `actual_seconds_added`, etc. ([`indexer/src/arena_wallet_stats.rs`](indexer/src/arena_wallet_stats.rs)). ### Frontend — `BuyItem` expects fields; mapper stubs them - [`frontend/src/lib/indexerApi.ts`](frontend/src/lib/indexerApi.ts): **`BuyItem`** includes **`log_index`**, **`block_timestamp`**, **`new_deadline`**, **`buy_index`** (required strings/numbers for detail UX). - **`mapArenaBuyToBuyItem`** currently sets **`log_index: 0`**, **`new_deadline: "0"`**, **`buy_index: "0"`** and omits **`block_timestamp`** — even when the API is extended, the mapper must pass through. - **Consumers** (broken or degraded without real values): - React keys / dedupe: **`${tx_hash}-${log_index}`** — [`ArenaLiveBuysActivitySection.tsx`](frontend/src/pages/arena/ArenaLiveBuysActivitySection.tsx), [`ArenaBuyModals.tsx`](frontend/src/pages/arena/ArenaBuyModals.tsx), [`ArenaSimplePage.tsx`](frontend/src/pages/arena/ArenaSimplePage.tsx) (`pulseKey`), [`peerBuyHeadSfxTick.ts`](frontend/src/pages/arena/peerBuyHeadSfxTick.ts) - Buy detail modal: **`new_deadline`** unix display — [`ArenaBuyModals.tsx`](frontend/src/pages/arena/ArenaBuyModals.tsx) - Protocol / audit copy: [`timeArenaUx.ts`](frontend/src/lib/timeArenaUx.ts) detail rows (Log index, Block time, New deadline, Buy index) - Unit tests already use non-zero mocks ([`ArenaLiveBuysActivitySection.test.tsx`](frontend/src/pages/arena/ArenaLiveBuysActivitySection.test.tsx), [`peerBuyHeadSfxTick.test.ts`](frontend/src/pages/arena/peerBuyHeadSfxTick.test.ts)). ### Verify scripts - [`scripts/verify-wallet-profile-anvil.sh`](scripts/verify-wallet-profile-anvil.sh) (#282) asserts `actual_seconds_added` + wallet stats; should gain **DB/API parity** checks for the four fields (or extend a dedicated `verify-arena-buys-parity-anvil.sh` if cleaner). --- ## Why this is needed 1. **Correct React keys & SFX dedupe:** Colliding `log_index: 0` for every row can cause list reuse bugs and missed peer-buy head SFX when multiple logs share UX assumptions. 2. **Buy detail / protocol transparency:** Users opening buy detail or protocol views should see real **new deadline** and **buy index** from ingest, not placeholders. 3. **Contract drift:** Frontend types and tests assume a full buy row; the indexer HTTP layer is still the missing link for identity + timer metadata (seconds field addressed in #282). 4. **Agent/CI hygiene:** One hermetic assertion that API JSON matches `idx_arena_buy` for all core columns reduces ad-hoc `psql`/`curl` debugging. --- ## Constraints & guardrails - **Onchain authority:** Values must match decoded **`Buy`** logs in DB; indexer **projects** only — no client-side recomputation of deadlines or buy index. - **AGPL** on scripts/docs; SPDX header on any new verify script. - **No legacy `/v1/timecurve/*`** — arena routes only ([#266](https://gitlab.com/PlasticDigits/yieldomega/-/issues/266)). - **Indexer ingest:** One SQL transaction per block ([#140](https://gitlab.com/PlasticDigits/yieldomega/-/issues/140)); tests must not weaken rollback/idempotency. - **Public API errors:** DB failures → generic HTTP 500 ([#157](https://gitlab.com/PlasticDigits/yieldomega/-/issues/157)). - **`block_timestamp` encoding:** Prefer **unix seconds string** (nullable) consistent with vault-funding / donate-pools endpoints — not raw ISO in JSON unless documented and mirrored everywhere. - **`log_index` encoding:** JSON **number** (matches `BuyItem.log_index: number`); DB `INT`; stable per `(tx_hash, log_index)` PK. - **`new_deadline` / `buy_index`:** Decimal **strings** (same pattern as `charm_wad` / `actual_seconds_added`). - **Scope boundary (this issue):** Expose **`new_deadline`**, **`buy_index`**, **`block_timestamp`**, **`log_index`** only. **Out of scope** unless trivial: `total_doub_raised_after`, BP breakdown fields, `block_hash`, `contract_address`, `price_per_charm_wad` — track separately if product needs full legacy `BuyItem` parity. **Prerequisite:** Merge/deploy [**#282**](https://gitlab.com/PlasticDigits/yieldomega/-/issues/282) (`actual_seconds_added`) first. --- ## Recommended solution direction ### A. Indexer — extend `GET /v1/arena/buys` 1. Add to SELECT: `new_deadline::text`, `buy_index::text`, `log_index`, `EXTRACT(EPOCH FROM block_timestamp)::text AS block_timestamp` (nullable). 2. Emit JSON: `new_deadline`, `buy_index`, `log_index`, `block_timestamp` (omit or `null` when `block_timestamp` IS NULL — document behavior). 3. Extend **`integration_stage2`** fixture: persisted buy with known values → HTTP asserts all four (+ #282 `actual_seconds_added`) match DB. 4. Document in [`docs/indexer/design.md`](docs/indexer/design.md) § arena buys; add **`INV-INDEXER-*-ARENA-BUYS-PARITY`** (or extend **`INV-INDEXER-282-ARENA-BUYS-SECONDS`**) in [`docs/testing/invariants-and-business-logic.md`](docs/testing/invariants-and-business-logic.md). ### B. Frontend — pass-through 1. Extend **`ArenaBuyItem`** with the four fields (types aligned with JSON). 2. Map in **`mapArenaBuyToBuyItem`**; audit direct **`fetchArenaBuys`** consumers. 3. Extend **`indexerApi.test.ts`** fixture JSON. ### C. Verify script - Extend **`verify-wallet-profile-anvil.sh`** (preferred) or add **`verify-arena-buys-parity-anvil.sh`**: after buy ingest, `curl` `/v1/arena/buys?limit=1` + `psql` spot-check for `new_deadline`, `buy_index`, `log_index`, `block_timestamp` vs API. - Cross-link in **`INV-FRONTEND-258-WALLET-PROFILE`**, [arena-views § wallet-profile](docs/frontend/arena-views.md#wallet-profile-modal-gitlab-258), [`.cursor/skills/yieldomega-guardrails/SKILL.md`](.cursor/skills/yieldomega-guardrails/SKILL.md), [`docs/testing/ci.md`](docs/testing/ci.md). --- ## Relevant files | Area | Files | |------|--------| | Indexer API | [`indexer/src/api_arena.rs`](indexer/src/api_arena.rs) | | Indexer tests | [`indexer/tests/integration_stage2.rs`](indexer/tests/integration_stage2.rs) | | Schema | [`indexer/migrations/20240601000000_arena_v2.up.sql`](indexer/migrations/20240601000000_arena_v2.up.sql) | | Frontend API/types | [`frontend/src/lib/indexerApi.ts`](frontend/src/lib/indexerApi.ts) | | Play / audit UI | [`ArenaBuyModals.tsx`](frontend/src/pages/arena/ArenaBuyModals.tsx), [`timeArenaUx.ts`](frontend/src/lib/timeArenaUx.ts), live-buy sections | | Verify | [`scripts/verify-wallet-profile-anvil.sh`](scripts/verify-wallet-profile-anvil.sh) | | Docs | [`docs/indexer/design.md`](docs/indexer/design.md), [`docs/testing/invariants-and-business-logic.md`](docs/testing/invariants-and-business-logic.md) | --- ## Acceptance criteria - [ ] **`GET /v1/arena/buys`** items include **`new_deadline`**, **`buy_index`**, **`log_index`**, **`block_timestamp`** (unix sec string or documented `null`). - [ ] After Anvil DOUB buy, each field in API matches **`idx_arena_buy`** for that `tx_hash` / `log_index`. - [ ] **`fetchArenaBuysAsBuyItems`** surfaces all four on **`BuyItem`** (non-zero `log_index` when chain emitted non-zero). - [ ] Live-buy lists use stable **`tx_hash` + `log_index`** keys (no longer all `log_index: 0` from mapper). - [ ] Buy detail modal shows **`new_deadline`** when present (existing `UnixTimestampDisplay` path). - [ ] Hermetic verify script exits 0 with parity assertions (documents `PATH` for Foundry + Cargo ≥ 1.85). - [ ] Invariants/docs updated with verify command + indexer invariant row. --- ## Test plan — functional paths | Path | Steps | Expected | |------|--------|----------| | Happy — DOUB buy | DeployDev → buy → poll `/v1/arena/buys` | All four fields present; `log_index` matches receipt log index | | `block_timestamp` null | Fixture/log without block time (if possible in test) | API returns `null`/omitted per spec; frontend tolerates | | Pagination | `limit` / `offset` | Fields on every returned row | | Multi-log same tx | Two `Buy` logs same tx (if testable) | Distinct `log_index`; unique React keys | | CRED buy | `buyWithCred` | Fields present from ingest | | Empty table | Fresh DB | `items: []` — no error | | Frontend mapper | `indexerApi.test.ts` | Mapped `BuyItem` matches fixture | | Verify script | Run twice on clean ports | Idempotent pass | **Automated:** - `cd indexer && cargo clippy --all-targets -- -D warnings && cargo test` - `cd frontend && npm run typecheck && npm test -- indexerApi` - `bash scripts/verify-wallet-profile-anvil.sh` (extended) or new parity script --- ## Test plan — attack / abuse / misuse | Vector | Risk | Mitigation / test | |--------|------|-------------------| | **Oversized numeric strings** | JSON bloat / `BigInt` throw | Return DB text as-is; test realistic `new_deadline` / `buy_index` magnitudes | | **Negative or malformed DB numerics** | Broken UI | Decoder/persist should prevent; API must not invent values | | **`log_index` confusion** | Wrong row keyed | Assert PK `(tx_hash, log_index)` round-trip in integration test | | **`block_timestamp` spoofing** | Misleading “time of buy” | Value is ingest-time RPC block time, not authoritative chain head — document derived-only | | **Rate limit / large `limit`** | DoS | Existing clamp 1–200; verify uses small `limit` | | **Verify script port hijack** | Wrong chain | Dedicated `ANVIL_PORT` / `INDEXER_PORT`; assert `chainId == 31337` | | **Duplicate React keys** | UI corruption | Integration/frontend test: two rows same `tx_hash`, different `log_index` → distinct keys | --- ## Verification criteria (sign-off) 1. `curl -s http://127.0.0.1:<indexer>/v1/arena/buys?limit=1 | jq '.items[0] | {new_deadline,buy_index,log_index,block_timestamp}'` — populated after buy. 2. `psql`: `SELECT new_deadline::text, buy_index::text, log_index, EXTRACT(EPOCH FROM block_timestamp)::text FROM idx_arena_buy ORDER BY block_number DESC LIMIT 1` matches API. 3. Browser: open buy detail from live buys — **New deadline** shows real unix time (not `0`). 4. Hermetic verify script — exit 0 with parity log lines. 5. `cargo test` + `npm run typecheck` green in touched packages. --- ## Related issues - [#282](https://gitlab.com/PlasticDigits/yieldomega/-/issues/282) — `actual_seconds_added` (prerequisite) - [#258](https://gitlab.com/PlasticDigits/yieldomega/-/issues/258) — wallet profile / buy surfaces - [#254](https://gitlab.com/PlasticDigits/yieldomega/-/issues/254) — arena schema / HTTP - [#255](https://gitlab.com/PlasticDigits/yieldomega/-/issues/255) — wallet stats (already uses SQL buy rows)
PlasticDigits commented 2026-06-03 11:40:13 +00:00 (Migrated from gitlab.com)

marked as related to #282

marked as related to #282
PlasticDigits commented 2026-06-03 11:40:13 +00:00 (Migrated from gitlab.com)

marked as related to #258

marked as related to #258
PlasticDigits commented 2026-06-03 11:40:14 +00:00 (Migrated from gitlab.com)

marked as related to #254

marked as related to #254
ghost1 commented 2026-06-03 12:27:50 +00:00 (Migrated from gitlab.com)

mentioned in commit 11f72eb042

mentioned in commit 11f72eb04238bc6cb5d84238dbbfc3c1023c48ed
ghost1 commented 2026-06-03 12:27:50 +00:00 (Migrated from gitlab.com)

mentioned in commit b1b4f2a4cf

mentioned in commit b1b4f2a4cffd26f3e6e0ae1b11c569c33c3a58fc
PlasticDigits commented 2026-06-03 12:28:18 +00:00 (Migrated from gitlab.com)

mentioned in merge request !410

mentioned in merge request !410
PlasticDigits commented 2026-06-03 12:52:44 +00:00 (Migrated from gitlab.com)

mentioned in commit 6d520e7a98

mentioned in commit 6d520e7a988b307c8e0a7b0a1a88da3dbd7dbeb5
PlasticDigits commented 2026-06-03 13:14:33 +00:00 (Migrated from gitlab.com)

Verification — all acceptance criteria PASS (no new MR)

Issue #283 is already implemented on main via merge commits b1b4f2a and 11f72eb (MR cursor/arena-buys-parity-283-7d54). This pass re-verified the merged work; no additional code changes were required.

Acceptance checklist

Criterion Verification Result
GET /v1/arena/buys includes new_deadline, buy_index, log_index, block_timestamp indexer/src/api_arena.rs SELECT + JSON; integration_stage2.rs::api_arena_buys_actual_seconds_added_smoke PASS
After Anvil DOUB buy, API fields match idx_arena_buy for tx_hash/log_index bash scripts/verify-wallet-profile-anvil.sh parity assertions (see log below) PASS
fetchArenaBuysAsBuyItems surfaces all four on BuyItem cd frontend && npm test -- indexerApi (22 tests) PASS
Live-buy lists use stable tx_hash + log_index keys mapArenaBuyToBuyItem passes through log_index; consumers use ${tx_hash}-${log_index} keys PASS
Buy detail modal shows new_deadline when present ArenaBuyModals.tsx → UnixTimestampDisplay path (existing UI; mapper no longer stubs "0") PASS
Hermetic verify script exits 0 with parity assertions bash scripts/verify-wallet-profile-anvil.sh PASS
Invariants/docs updated with verify command INV-INDEXER-283-ARENA-BUYS-PARITY, docs/indexer/design.md, docs/testing/ci.md, guardrails skill PASS

Commands run (2026-06-03)

cd indexer && cargo clippy --all-targets -- -D warnings && cargo test
# 31 unit + 4 integration tests — all PASS

cd frontend && npm run typecheck && npm test -- indexerApi
# typecheck PASS; 22 indexerApi tests PASS

bash scripts/verify-wallet-profile-anvil.sh
# exit 0 — key parity log lines:
#   new_deadline=1780578906 (matches idx_arena_buy)
#   buy_index=1 (matches idx_arena_buy)
#   log_index=21 (matches idx_arena_buy)
#   block_timestamp=1780492458.000000 (matches idx_arena_buy)
#   integration_stage2: 4 passed

Manual QA (browser)

Buy detail modal New deadline display — SKIP (not run in this Cloud Agent session; covered by mapper + ArenaBuyModals.tsx wiring; recommend spot-check on /arena during #258 QA).

Blockers

None.

Closing as complete — implementation merged and automated verification green.

## Verification — all acceptance criteria PASS (no new MR) Issue **#283** is already implemented on `main` via merge commits `b1b4f2a` and `11f72eb` (MR `cursor/arena-buys-parity-283-7d54`). This pass re-verified the merged work; no additional code changes were required. ### Acceptance checklist | Criterion | Verification | Result | |-----------|--------------|--------| | `GET /v1/arena/buys` includes `new_deadline`, `buy_index`, `log_index`, `block_timestamp` | `indexer/src/api_arena.rs` SELECT + JSON; `integration_stage2.rs::api_arena_buys_actual_seconds_added_smoke` | **PASS** | | After Anvil DOUB buy, API fields match `idx_arena_buy` for `tx_hash`/`log_index` | `bash scripts/verify-wallet-profile-anvil.sh` parity assertions (see log below) | **PASS** | | `fetchArenaBuysAsBuyItems` surfaces all four on `BuyItem` | `cd frontend && npm test -- indexerApi` (22 tests) | **PASS** | | Live-buy lists use stable `tx_hash` + `log_index` keys | `mapArenaBuyToBuyItem` passes through `log_index`; consumers use `${tx_hash}-${log_index}` keys | **PASS** | | Buy detail modal shows `new_deadline` when present | `ArenaBuyModals.tsx` → `UnixTimestampDisplay` path (existing UI; mapper no longer stubs `"0"`) | **PASS** | | Hermetic verify script exits 0 with parity assertions | `bash scripts/verify-wallet-profile-anvil.sh` | **PASS** | | Invariants/docs updated with verify command | `INV-INDEXER-283-ARENA-BUYS-PARITY`, `docs/indexer/design.md`, `docs/testing/ci.md`, guardrails skill | **PASS** | ### Commands run (2026-06-03) ```bash cd indexer && cargo clippy --all-targets -- -D warnings && cargo test # 31 unit + 4 integration tests — all PASS cd frontend && npm run typecheck && npm test -- indexerApi # typecheck PASS; 22 indexerApi tests PASS bash scripts/verify-wallet-profile-anvil.sh # exit 0 — key parity log lines: # new_deadline=1780578906 (matches idx_arena_buy) # buy_index=1 (matches idx_arena_buy) # log_index=21 (matches idx_arena_buy) # block_timestamp=1780492458.000000 (matches idx_arena_buy) # integration_stage2: 4 passed ``` ### Manual QA (browser) Buy detail modal **New deadline** display — **SKIP** (not run in this Cloud Agent session; covered by mapper + `ArenaBuyModals.tsx` wiring; recommend spot-check on `/arena` during #258 QA). ### Blockers None. Closing as complete — implementation merged and automated verification green.
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-06-03 13:14:44 +00:00
PlasticDigits commented 2026-06-03 13:37:29 +00:00 (Migrated from gitlab.com)

mentioned in issue #258

mentioned in issue #258
PlasticDigits commented 2026-07-07 02:38:41 +00:00 (Migrated from gitlab.com)

mentioned in issue #364

mentioned in issue #364
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
cac-design-issue-544
renovate/configure
No results found.
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega#283
No description provided.