Docs: remove TimeCurve/FeeRouter mentions from satellite docs #274
Labels
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
code/yieldomega#274
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Finish the Arena v2 documentation migration by removing or rewriting stale TimeCurve / FeeRouter / v1 launchpad prose that remains in satellite docs (everything outside the already-trimmed
docs/testing/invariants-and-business-logic.md). Parent cleanup: #263 (bulk invariant deletion + anchor CI). Epic: #238.Goal: Operators, QA, agents, and contributors reading
docs/,skills/, and.cursor/skills/must not be instructed to configure, test, or preserve retired v1 economics (TimeCurve.endSale,FeeRouter.distributeFees,idx_timecurve_*,VITE_FEE_ROUTER_*,/timecurve/*QA paths).Current codebase
Already aligned (do not regress)
DeployDev.s.sol/DeployProduction.s.soldeploy TimeArena + vaults only (#259)GET /v1/arena/*; noTimeCurve*DecodedEventvariants (#260)/arena;VITE_TIME_ARENA_ADDRESS(#256);.env.examplehas noVITE_FEE_ROUTER_*INV-TIME-ARENA-*table;scripts/check-doc-anchors.shgreen (#263)docs/onchain/fee-routing-and-governance.mdrewritten for DOUB 40/30/30 (#244)bots/timearena/(notbots/timecurve/) (#245)Stale surface (grep snapshot on
main)docs/: ~45 files, ~255TimeCurve|FeeRoutertoken matches (many are full sections, not one-line cross-links).skills/: 3 files (mostly “legacy removed” notes — verify wording)..cursor/skills/: guardrails already list retired components; confirm no operator steps cite v1 paths.High-impact offenders (non-exhaustive)
docs/qa/QA-onboarding-gitlab-issue-body.mdVITE_TIMECURVE_ADDRESS,VITE_FEE_ROUTER_ADDRESS,bots/timecurve,distributePrizes/ five-sink FeeRouter tablesdocs/indexer/design.mdtimecurve_buys,idx_timecurve_*,GET /v1/timecurve/*, WarBow CL8Y / sale-state sections superseded by Arena ingestdocs/integrations/kumbaya.mdTimeCurveBuyRouterlive-sale checklist; mixed Arena + v1 operator stepsdocs/onchain/cl8y-flow-audit.mdTimeCurve/FeeRouterpublic flows (historical audit, not Arena DOUB)docs/operations/deployment-guide.mddocs/operations/archive/only if product agrees (default: delete per #263 policy)docs/operations/final-signoff-and-value-movement.mdverify-timecurve-post-end-gates-anvil.shdocs/operations/pause-and-final-signoff.mddocs/onchain/security-and-threat-model.mddocs/testing/qa-local-full-stack.mdTimeCurveBuyRouterregistry +verify-timecurve-buy-router-anvil.shdocs/testing/contract-fork-smoke.mdTimeCurveForkTestas primary exampledocs/agent-phases.md,docs/agent-implementation-phases.mddocs/product/vision.md,docs/glossary.mddocs/frontend/design.mddocs/architecture/repository-layout.mdscripts/qa/README.mdContracts note:
TimeCurve.sol/FeeRouter.solmay remain in tree for history/fork tests — out of scope unless doc claims they are deployed on current dev path.Why this is needed
idx_timecurve_*indexer work — contradictingarena-v2.mdandinvariants§260.VITE_FEE_ROUTER_ADDRESSand TimeCurve page smoke — causes failed env checks and wrong-route testing on Arena v2 stacks.endSale/redeemCharms/ FeeRouter rescue paths (#241–#244).check-doc-anchors.shonly coversinvariants-and-business-logic.md#…— satellite links to deleted anchors may still exist.Constraints and guardrails
docs/testing/archive/stubs that repeatarena-v2.md.TimeArena,TimeArenaBuyRouter,GET /v1/arena/*,VITE_TIME_ARENA_ADDRESS,VITE_KUMBAYA_TIME_ARENA_BUY_ROUTER, play skills underskills/.VITE_FEE_ROUTER_*in.env.exampleor operator checklists;VITE_TIMECURVE_ADDRESSmay remain as documented legacy alias for e2e only (e2e-anvil.md).verify-timecurve-*in docs toverify-time-arena-buy-router-anvil.sh; script deletion is optional separate PR if still wrapped.Relevant files
Must touch (priority)
docs/qa/QA-onboarding-gitlab-issue-body.md— rewrite for/arena,bots/timearena, Arena env varsdocs/indexer/design.md— Arena tables/routes onlydocs/integrations/kumbaya.md— Arena-first; delete legacy TimeCurve flow sectiondocs/testing/qa-local-full-stack.mddocs/onchain/cl8y-flow-audit.md— relocate to “historical v1 CL8Y” or trimdocs/operations/final-signoff-and-value-movement.mddocs/operations/pause-and-final-signoff.mddocs/onchain/security-and-threat-model.mddocs/agent-phases.md,docs/agent-implementation-phases.mddocs/product/vision.md,docs/glossary.mddocs/frontend/design.mddocs/architecture/repository-layout.md,docs/architecture/data-flows.mddocs/testing/contract-fork-smoke.mdscripts/qa/README.mdLikely touch
docs/operations/deployment-guide.md— collapse retired v1 blockdocs/operations/stage2-run-log.md,docs/operations/stage3-mainnet-operator-runbook.mddocs/product/referrals.md,docs/product/primitives.md— remove TimeCurve-only anchorsdocs/testing/ci.md,docs/testing/local-swap-testing.mddocs/README.md,docs/contracts/foundry-and-megaeth.mdskills/README.md, play skills — ensure zeroplay-timecurve-*resurrectionVerification / CI
scripts/check-doc-anchors.shor addscripts/check-doc-retired-terms.shfor operator-facing paths (see acceptance criteria)docs/testing/strategy.md— document new grep gatesRecommended solution direction
rg -l 'TimeCurve|FeeRouter|idx_timecurve|VITE_FEE_ROUTER|redeemCharms|endSale' docs/ skills/ .cursor/→ tier P0 (operator/QA/agent) vs P1 (historical audit)./arena,TimeArena,GET /v1/arena/*,YIELDOMEGA_TIME_ARENA_ADDRESS,make check-frontend-envchecks for arena addresses only.arena-v2.md.manual-qa-checklists.md§260 / Arena play skills.TimeArenaBuyRouter); bottom historical section removed (not moved).docs/qa/,docs/testing/qa-local-full-stack.md,docs/agent-phases.mdcontainFeeRouterorTimeCurve.endSale(allowlistinvariantsnegative-test rows andfee-routing“Retired” paragraph).yieldomega-guardrailsSKILL andskills/README.mdfrom updated onboarding.Acceptance criteria
rg 'VITE_FEE_ROUTER|FeeRouter\.distributeFees|TimeCurve\.endSale|redeemCharms|idx_timecurve' docs/qa/ docs/testing/qa-local-full-stack.md docs/agent-phases.md docs/agent-implementation-phases.md→ zero matches.rg -l 'TimeCurve|FeeRouter' docs/count reduced by ≥50% vs baseline (~45 files / ~255 mentions); no file indocs/qa/ordocs/agent-phases.mdcontains standalone v1 operator instructions.docs/qa/QA-onboarding-gitlab-issue-body.mddescribes/arena,bots/timearena, andVITE_TIME_ARENA_ADDRESS(not TimeCurve page / FeeRouter panel).docs/indexer/design.mddocumentsidx_arena_*andGET /v1/arena/*only; noGET /v1/timecurve/*as active API.docs/integrations/kumbaya.mdhas no “Legacy TimeCurve product flow” section longer than a one-line retired pointer.verify-timecurve-post-end-gates-anvil.shor configuring five-sink FeeRouter for current dev deploy.bash scripts/check-doc-anchors.shstill passes; no new brokeninvariants-and-business-logic.md#…links from edited files.skills/and.cursor/skills/yieldomega-guardrails/SKILL.mdagree with post-edit doc map.Test plan — documentation paths
rgcommands from repo root/arena,make check-frontend-envpasses without FeeRouter varsstart-qa-local-full-stack.sh,/arena,bots/timearena— not TimeCurve pagedesign.mdtoindexer/src/decoder.rs+api_arena.rse2e-anvil.md+ kumbaya.mdTimeArenaBuyRouter; no live-saleTimeCurve.ended()prerequisiterg 'invariants-and-business-logic\.md#' docs/+ sample GitLab renderskills/README.mdplay-*-time-arena*play skillsTest plan — misuse / abuse vectors (doc integrity)
VITE_FEE_ROUTER_*from QA bodyrg 'VITE_FEE_ROUTER' docs/qa docs/testing/qa-local-full-stack.md→ zero/timecurveor “TimeCurve page” instead of/arena/arenamountidx_timecurve_buytasksdesign.mdgrepidx_timecurve→ zero or historical appendix onlyTimeCurve.t.solfor arena economicsagent-phases.mdcitesTimeArena.t.sol/anvil-arena-*check-doc-anchors.sh+ manual skills link checkVerification criteria (definition of done)
rggates in acceptance criteria all zero;docs/TimeCurve|FeeRoutermention count ≤125 (~50% reduction) unless justified in issue close comment.bash scripts/check-doc-anchors.shpasses; if newcheck-doc-retired-terms.shadded, it passes in CI.cd indexer && cargo testandcd frontend && npm testunchanged (docs-only).bash scripts/e2e-anvil.shpasses on clean host (no doc-driven env drift).deployment-guide.mdretired block into external archive).Related
marked as related to #263
mentioned in commit
730f405ed1Implementation summary (#274)
Satellite documentation migration for Arena v2 is merged to
main(eee286c).What changed
/arena,TimeArena,VITE_TIME_ARENA_ADDRESS,bots/timearena, andGET /v1/arena/*— notablydocs/qa/QA-onboarding-gitlab-issue-body.md,docs/indexer/design.md,docs/integrations/kumbaya.md,docs/agent-phases.md,docs/agent-implementation-phases.md,docs/testing/qa-local-full-stack.md.docs/operations/deployment-guide.md;docs/onchain/cl8y-flow-audit.mdmarked retired historical.scripts/check-doc-retired-terms.sh— fails if P0 paths cite retiredVITE_FEE_ROUTER,FeeRouter.distributeFees,TimeCurve.endSale,redeemCharms, oridx_timecurve..cursor/skills/yieldomega-guardrails/SKILL.md,skills/README.md,docs/testing/strategy.mdupdated.TimeCurve|FeeRoutermentions indocs/reduced from ~255 (45 files) → 54 (30 files); remaining hits are labeled retired or in canonical product specs (arena-v2.md,time-arena.md, invariants negative-test rows).Verification checklist (QA)
bash scripts/check-doc-retired-terms.sh— exit 0bash scripts/check-doc-anchors.sh— exit 0rg 'VITE_FEE_ROUTER|FeeRouter\.distributeFees|TimeCurve\.endSale|redeemCharms|idx_timecurve' docs/qa/ docs/testing/qa-local-full-stack.md docs/agent-phases.md docs/agent-implementation-phases.md— zero matchesdocs/qa/QA-onboarding-gitlab-issue-body.mdon Anvil stack → lands on/arena,make check-frontend-envpasses without fee-router varsdocs/indexer/design.mdmatchesindexer/src/decoder.rs+api_arena.rs(Arena-only tables/routes)docs/integrations/kumbaya.md+bash scripts/verify-time-arena-buy-router-anvil.sh— no live-sale prerequisite/arena,bots/timearena, not TimeCurve pageFollow-ups (deferred)
check-doc-retired-terms.shinto.github/workflows/(documented in strategy.md; not added to CI in this pass).docs/testing/contract-fork-smoke.mdreferencesTimeArenaForkTest— fork test file/workflow alignment is a separate task if not yet in tree.Requesting verification from the QA agent team. Issue left open until checklist sign-off.
mentioned in issue #275
mentioned in commit
9831bd66cfmentioned in commit
4230ab7ae9Verification complete (issue/274-verify →
4230ab7)Verified GitLab #274 on a dedicated worktree against
main. Prior bulk doc cleanup (730f405) already satisfied most acceptance criteria; this pass added CI wiring + invariant crosslinks and re-ran the full gate suite.What was done
VITE_FEE_ROUTER,FeeRouter.distributeFees,TimeCurve.endSale,redeemCharms,idx_timecurveindocs/qa/,docs/testing/qa-local-full-stack.md,docs/agent-phases.md,docs/agent-implementation-phases.md.docs/TimeCurve|FeeRoutermentions: 55 (baseline ~255, target ≤125). Files with matches: 30 (baseline ~45).bash scripts/check-doc-anchors.sh(37 anchors) andbash scripts/check-doc-retired-terms.shboth green.scripts-smokejob in.github/workflows/unit-tests.yml; documented indocs/testing/ci.md.INV-DOCS-274-*table + anchor#satellite-docs-gitlab-274indocs/testing/invariants-and-business-logic.md; cross-linked from guardrails +skills/README.md.Makefilehelp forcheck-frontend-env(Arena v2, not TimeCurve/fee router); Playwright CI env now usesVITE_TIME_ARENA_ADDRESS.indexer cargo test(32 tests),frontend npm test(531 tests),bash scripts/e2e-anvil.sh(6/6 Anvil specs) all pass; no doc-driven env drift.Manual verification checklist (for QA follow-up)
docs/qa/QA-onboarding-gitlab-issue-body.md→ lands on/arena,make check-frontend-envpasses without FeeRouter varsdocs/indexer/design.mdmatchesindexer/src/decoder.rs+api_arena.rs(Arena tables/routes only)docs/integrations/kumbaya.mdhas no legacy TimeCurve product-flow runbook (one-line retired pointer only)start-qa-local-full-stack.sh,/arena,bots/timearenarg 'VITE_FEE_ROUTER' docs/qa docs/testing/qa-local-full-stack.md→ zerobash scripts/check-doc-retired-terms.shpasses locally and in CIscripts-smokejobDeferred (non-blocking)
docs/still contain labeled retiredTimeCurve|FeeRouterreferences (historical cross-links, negative-test rows, fork-smoke notes) — all reviewed as non-operator instructions per #263 policy.docs/operations/deployment-guide.mdretired pointer or move to external archive.All issue-body acceptance criteria and verification criteria pass. Closing.
mentioned in issue #276
mentioned in commit
43ffbe550amentioned in issue #277
mentioned in merge request !396
mentioned in commit
780c26e64amentioned in merge request !401
mentioned in issue #284
marked as related to #284
mentioned in issue #309