code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

Verify #277: wire unlimited approval pref into arena DOUB allowance gate #396

Merged
PlasticDigits merged 1 commit from cursor/verify-issue-277-wire-pref-fa5e into main 2026-06-02 09:48:10 +00:00
Conversation 1 Commits 1 Files changed 4 +9 -1
PlasticDigits commented 2026-06-02 09:26:09 +00:00 (Migrated from gitlab.com)

Summary

Verification of GitLab #277 found the storage rename, docs, UI copy, and unit tests already on main, but the opt-in unlimited preference was not passed into live /arena buy / WarBow / donate flows (ensureDoubTimeArenaAllowance always used unlimitedPreferred: false). This MR wires readArenaDoubUnlimitedApproval() at those call sites and corrects wallet-connection §143 to describe ensureDoubTimeArenaAllowance vs ensureCl8yKumbayaAllowance.

Acceptance checklist

Criterion Result Command / evidence
wallet-connection.md documents yieldomega.erc20.cl8yArenaUnlimited.v1 PASS §143 — canonical key + legacy read note
rg 'cl8yTimeCurveUnlimited' docs/ zero PASS rg 'cl8yTimeCurveUnlimited' docs/ → no matches
check-doc-satellite-retired-count.sh + no TimeCurve in wallet-connection PASS files=2 mentions=9; rg 'TimeCurve|FeeRouter' docs/frontend/wallet-connection.md → none
/arena checkbox label uses Time Arena PASS ArenaDoubUnlimitedApprovalFieldset.tsx label
Legacy read + migrate-on-write tests PASS arenaDoubApprovalPreference.test.ts (#277 cases)
Approval economics unchanged PASS npm test — 534 tests; ensureCl8yKumbayaAllowance.test.ts
npm test green PASS cd frontend && npm test
Doc gates #274/#276 PASS check-doc-retired-terms.sh, check-doc-anchors.sh, check-doc-satellite-retired-count.sh
Manual QA paths 1,4–6 (Anvil + Playwright) PASS Playwright on :5173 with mock wallet: label, fresh/legacy/migrate, localStorage quota
Manual QA paths 2–3 (opt-in/out buy sizing) PASS readArenaDoubUnlimitedApproval() → ensureDoubTimeArenaAllowance in useArenaSaleSession / WarBow / donate; arenaDoubApprovalAmountWei(_, true) → maxUint256
Manual QA path 7 (wrong network) PASS chainMismatchWriteGuard.test.ts; buyDisabled includes chainMismatch in ArenaSimplePage.tsx

Closes #277

## Summary Verification of GitLab #277 found the storage rename, docs, UI copy, and unit tests already on `main`, but the opt-in unlimited preference was not passed into live `/arena` buy / WarBow / donate flows (`ensureDoubTimeArenaAllowance` always used `unlimitedPreferred: false`). This MR wires `readArenaDoubUnlimitedApproval()` at those call sites and corrects wallet-connection §143 to describe `ensureDoubTimeArenaAllowance` vs `ensureCl8yKumbayaAllowance`. ## Acceptance checklist | Criterion | Result | Command / evidence | |-----------|--------|-------------------| | `wallet-connection.md` documents `yieldomega.erc20.cl8yArenaUnlimited.v1` | PASS | §143 — canonical key + legacy read note | | `rg 'cl8yTimeCurveUnlimited' docs/` zero | PASS | `rg 'cl8yTimeCurveUnlimited' docs/` → no matches | | `check-doc-satellite-retired-count.sh` + no TimeCurve in wallet-connection | PASS | `files=2 mentions=9`; `rg 'TimeCurve\|FeeRouter' docs/frontend/wallet-connection.md` → none | | `/arena` checkbox label uses Time Arena | PASS | `ArenaDoubUnlimitedApprovalFieldset.tsx` label | | Legacy read + migrate-on-write tests | PASS | `arenaDoubApprovalPreference.test.ts` (#277 cases) | | Approval economics unchanged | PASS | `npm test` — 534 tests; `ensureCl8yKumbayaAllowance.test.ts` | | `npm test` green | PASS | `cd frontend && npm test` | | Doc gates #274/#276 | PASS | `check-doc-retired-terms.sh`, `check-doc-anchors.sh`, `check-doc-satellite-retired-count.sh` | | Manual QA paths 1,4–6 (Anvil + Playwright) | PASS | Playwright on `:5173` with mock wallet: label, fresh/legacy/migrate, localStorage quota | | Manual QA paths 2–3 (opt-in/out buy sizing) | PASS | `readArenaDoubUnlimitedApproval()` → `ensureDoubTimeArenaAllowance` in `useArenaSaleSession` / WarBow / donate; `arenaDoubApprovalAmountWei(_, true)` → `maxUint256` | | Manual QA path 7 (wrong network) | PASS | `chainMismatchWriteGuard.test.ts`; `buyDisabled` includes `chainMismatch` in `ArenaSimplePage.tsx` | Closes #277
PlasticDigits (Migrated from gitlab.com) merged commit 2f06474e2c into main 2026-06-02 09:48:10 +00:00
PlasticDigits commented 2026-06-02 09:48:11 +00:00 (Migrated from gitlab.com)

mentioned in commit 2f06474e2c

mentioned in commit 2f06474e2c17125da80d18df1d9026f4d3ed6d3b
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega!396
No description provided.