fix(frontend): Create Pair fee + gas (#345) #844

Merged

PlasticDigits merged 1 commit from local1/345-create-pair-fee-gas into main

2026-06-09 07:05:59 +00:00

PlasticDigits commented

2026-06-09 06:53:08 +00:00

(Migrated from gitlab.com)

Summary

Attach pair_creation_fee_uluna from factory config on createPair()
Bump CREATE_PAIR_GAS_LIMIT to 1_000_000
Show required fee on Create Pair page

Test plan

npm test -- factory.test.ts transactions.test.ts
Create Pair with two whitelisted CW20s on LocalTerra
Tx succeeds with uluna fee attached

Docs

skills/AGENTS_TERRACLASSIC_GAS.md

Closes #345 (issue left open per workflow).

Note

Medium Risk
Changes real tx payloads (native fee attachment) and gas limits for pair creation and unwrap swaps; misconfiguration could cause failed txs or under-estimated fees, but behavior is covered by unit tests and aligns with measured chain usage.

Overview
Fixes Create Pair so broadcasts match on-chain factory requirements: createPair loads factory config and attaches uluna when pair_creation_fee_uluna > 0, skips coins when zero, and Create Pair page surfaces the fee from the same config query.

Gas: CREATE_PAIR_GAS_LIMIT rises 800k → 1M (LocalTerra instantiate ~871k). Router execute_swap_operations with unwrap_output: true now adds UNWRAP_GAS_LIMIT to fee estimates (CW20→native, #343), including CW20 send paths that decode inner router msgs.

Also extends FactoryConfigResponse with pair_creation_fee_uluna, allows null on indexer trader best_trade_pnl / worst_trade_pnl, updates factory.test.ts / transactions.test.ts, and documents #343/#345 in AGENTS_TERRACLASSIC_GAS.md.

^{Reviewed by Cursor Bugbot for commit 1f1933956f. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary - Attach `pair_creation_fee_uluna` from factory config on `createPair()` - Bump `CREATE_PAIR_GAS_LIMIT` to 1_000_000 - Show required fee on Create Pair page ## Test plan - [ ] `npm test -- factory.test.ts transactions.test.ts` - [ ] Create Pair with two whitelisted CW20s on LocalTerra - [ ] Tx succeeds with uluna fee attached ## Docs - [skills/AGENTS_TERRACLASSIC_GAS.md](skills/AGENTS_TERRACLASSIC_GAS.md) Closes #345 (issue left open per workflow).  --- > [!NOTE] > **Medium Risk** > Changes real tx payloads (native fee attachment) and gas limits for pair creation and unwrap swaps; misconfiguration could cause failed txs or under-estimated fees, but behavior is covered by unit tests and aligns with measured chain usage. > > **Overview** > Fixes **Create Pair** so broadcasts match on-chain factory requirements: **`createPair`** loads factory config and attaches **`uluna`** when **`pair_creation_fee_uluna` > 0**, skips coins when zero, and **Create Pair** page surfaces the fee from the same config query. > > **Gas:** **`CREATE_PAIR_GAS_LIMIT`** rises **800k → 1M** (LocalTerra instantiate ~871k). Router **`execute_swap_operations`** with **`unwrap_output: true`** now adds **`UNWRAP_GAS_LIMIT`** to fee estimates (CW20→native, #343), including CW20 **`send`** paths that decode inner router msgs. > > Also extends **`FactoryConfigResponse`** with **`pair_creation_fee_uluna`**, allows **`null`** on indexer trader **`best_trade_pnl` / `worst_trade_pnl`**, updates **`factory.test.ts`** / **`transactions.test.ts`**, and documents #343/#345 in **`AGENTS_TERRACLASSIC_GAS.md`**. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 1f1933956f3e440b8e89b0a0dd729e94a93bcb2e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

Rows
Columns