fix(frontend): post-tax CW20 amounts after native wrap (#342) #846
No reviewers
Labels
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
code/cl8y-dex-terraclassic!846
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "local1/342-native-tax"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
nativeTransferTax.tsqueries LCD tax rate; net CW20 for router send and pool provide afterwrap_depositTest plan
npm test -- nativeTransferTax.test.tsDocs
Merge after !844–!845 (stacked).
changed the description
mentioned in issue #342
changed the description
Stale Security Review comment
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issues.
Reviewed by Cursor Bugbot for commit
ee182786a0. Configure here.Tax cache ignores denom
Medium Severity
fetchNativeTransferTaxParamscaches a singleparamsobject for 60s without recording which denom was used fortax_caps. A later call for another native denom (e.g.uusdafteruluna) can reuse the wrong per-denom cap and compute incorrect net amounts for wrap/LP.Reviewed by Cursor Bugbot for commit
ee182786a0. Configure here.Wrap deposit uses net amount
High Severity
The native-wrap provide path overwrites
rawA/rawBwith post-tax net values before building messages, sowrap_depositcoins use the net amount instead of the user’s gross native deposit. That under-deposits native, mints less CW20 than the allowance andprovide_liquidityexpect, and can reproduceCannot Subor wrong pool deposits.Reviewed by Cursor Bugbot for commit
ee182786a0. Configure here.changed this line in version 2 of the diff
added 1 commit
Compare with previous version
changed the description
resolved all threads
resolved all threads
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.
Reviewed by Cursor Bugbot for commit 5b2baee0382a61bcb5f95121f9dbfc106645f98a. Configure here.
Max reserve omits unwrap gas
Medium Severity
Broadcast gas for router swaps with
unwrap_outputnow includesUNWRAP_GAS_LIMIT, andestimateNativeSwapUlunaFeesTotalcan mirror that whenneedsUnwrapOutputis set, but native Max still buildsnativeSwapHintswithout that flag, so the reservedulunacan be too low on wrap-and-unwrap swap paths.Reviewed by Cursor Bugbot for commit 5b2baee0382a61bcb5f95121f9dbfc106645f98a. Configure here.
added 1 commit
Compare with previous version
changed the description
resolved all threads
changed this line in version 5 of the diff
added 7 commits
mainCompare with previous version
changed the description
added 6 commits
main5b3f7358- Fix native-wrap provide gross deposit and per-denom tax cacheCompare with previous version
changed the description
mentioned in commit
b511e77e6a