fix(frontend): opaque trade limit sticky CTA without form bleed (#500) #1034

Merged

PlasticDigits merged 3 commits from fix/500-limit-ticket-sticky-footer into main

2026-07-25 04:49:33 +00:00

PlasticDigits commented

2026-07-25 04:33:36 +00:00

(Migrated from gitlab.com)

Summary

Fix /trade sticky Place limit footer bleed (#500): replace invalid var(--card) translucent background with opaque var(--panel-bg-strong) over solid var(--bg-1).
Keep validation/place guards in normal document flow above the sticky CTA so they cannot cover expiry/date inputs (issue note).
Add ticket scroll clearance (--trade-limit-sticky-clearance), Vitest + Playwright coverage, and agent docs/skills crosslinks.

Test plan

npm test -- --run src/pages/TradePage.test.tsx -t "sticky CTA" (worktree cl8y-dex-terraclassic-500)
Playwright trade-page-responsive.spec.ts -g "#500" after LocalTerra redeploy (fresh Vite)
Manual /trade desktop: scroll mid-ticket — no ADVANCED/fee text through CTA; expiry clears pinned footer; dark + light

Issue criteria

Opaque (or glass-with-solid underlay) sticky footer — no form bleed
Scroll clearance so EXPIRY / date / ADVANCED can clear pinned footer
Validation banner in normal document flow (not inside sticky chrome)
Invariants documented + skills crosslinked for 3rd-party agents

Closes #500

## Summary - Fix `/trade` sticky **Place limit** footer bleed (#500): replace invalid `var(--card)` translucent background with opaque `var(--panel-bg-strong)` over solid `var(--bg-1)`. - Keep validation/place guards in normal document flow above the sticky CTA so they cannot cover expiry/date inputs (issue note). - Add ticket scroll clearance (`--trade-limit-sticky-clearance`), Vitest + Playwright coverage, and agent docs/skills crosslinks. ## Test plan - [x] `npm test -- --run src/pages/TradePage.test.tsx -t "sticky CTA"` (worktree `cl8y-dex-terraclassic-500`) - [x] Playwright `trade-page-responsive.spec.ts` `-g "#500"` after LocalTerra redeploy (fresh Vite) - [ ] Manual `/trade` desktop: scroll mid-ticket — no ADVANCED/fee text through CTA; expiry clears pinned footer; dark + light ## Issue criteria - [x] Opaque (or glass-with-solid underlay) sticky footer — no form bleed - [x] Scroll clearance so EXPIRY / date / ADVANCED can clear pinned footer - [x] Validation banner in normal document flow (not inside sticky chrome) - [x] Invariants documented + skills crosslinked for 3rd-party agents Closes #500

ghost1 commented

2026-07-25 04:33:39 +00:00

(Migrated from gitlab.com)

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot) to get automatic reviews on future PRs.

PlasticDigits commented

2026-07-25 04:36:17 +00:00

(Migrated from gitlab.com)

Retested after LocalTerra redeploy from worktree cl8y-dex-terraclassic-500:

Vitest TradePage sticky CTA DOM order — pass
Playwright trade-page-responsive.spec.ts #500 — pass (fresh Vite server; scroll-into-view hit-test)

Retested after LocalTerra redeploy from worktree `cl8y-dex-terraclassic-500`: - Vitest `TradePage` sticky CTA DOM order — pass - Playwright `trade-page-responsive.spec.ts` `#500` — pass (fresh Vite server; scroll-into-view hit-test)

PlasticDigits commented

2026-07-25 04:38:06 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-07-25 04:38:12 +00:00

(Migrated from gitlab.com)

added 1 commit

a8c0755c - test(frontend): harden #500 sticky CTA e2e and allow worktree node_modules

Compare with previous version

added 1 commit <ul><li>a8c0755c - test(frontend): harden #500 sticky CTA e2e and allow worktree node_modules</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/316/diffs?diff_id=1923589074&start_sha=7b4f786a7c6a34feb10c688cff55f33bcc4969ac)

ghost1 commented

2026-07-25 04:38:14 +00:00

(Migrated from gitlab.com)

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot) to get automatic reviews on future PRs.

PlasticDigits commented

2026-07-25 04:49:31 +00:00

(Migrated from gitlab.com)

added 8 commits

a8c0755c...5993d3a7 - 7 commits from branch main
0be38dc8 - merge: sync #500 with main; keep #494 and #500 design notes

Compare with previous version

added 8 commits <ul><li>a8c0755c...5993d3a7 - 7 commits from branch <code>main</code></li><li>0be38dc8 - merge: sync #500 with main; keep #494 and #500 design notes</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/316/diffs?diff_id=1923592122&start_sha=a8c0755cd97d84e05c99f305195f91f6497ec333)

PlasticDigits commented

2026-07-25 04:49:33 +00:00

(Migrated from gitlab.com)

mentioned in commit 3a0069ce89

mentioned in commit 3a0069ce89de94c5e340d9e652d2e4cc018d4aef