Limits Ladder: create ladder options missing when Ladder place mode is selected #494

New issue

Closed

opened 2026-07-15 04:03:41 +00:00 by PlasticDigits · 12 comments

PlasticDigits commented

2026-07-15 04:03:41 +00:00

(Migrated from gitlab.com)

Summary

On /limits, switching Place mode to Ladder does not show the create-ladder form (start/end price, rung count, total pay, place CTA). The Single place form still appears as expected.

Expected: selecting Ladder shows LimitOrderLadderPanel create options.

Steps to reproduce

Open /limits with a pair selected.
In the Place card, click Ladder.
Observe the place card body under the Single / Ladder tabs.

Actual

Ladder create options are missing (empty / no ladder panel fields under the tablist).

Expected

Show the ladder create UI: bid/ask side, start/end price, rungs, total pay, expiry/advanced, preview, and Place N-rung ladder.

Likely location

frontend-dapp/src/pages/LimitOrdersPage.tsx — Ladder panel is gated on wallet address:

{placeMode === 'ladder' && selectedPair && address && (
  <LimitOrderLadderPanel ... />
)}

Single mode does not require address to render its form. If the wallet is disconnected (or address is briefly unset), Ladder mode shows no create options while the tab still looks selected.

Also check frontend-dapp/src/components/trade/LimitOrderLadderPanel.tsx if a design-system regression hid the fields after #488.

## Summary On `/limits`, switching Place mode to **Ladder** does not show the create-ladder form (start/end price, rung count, total pay, place CTA). The Single place form still appears as expected. **Expected:** selecting Ladder shows `LimitOrderLadderPanel` create options. ## Steps to reproduce 1. Open `/limits` with a pair selected. 2. In the Place card, click **Ladder**. 3. Observe the place card body under the Single / Ladder tabs. ## Actual Ladder create options are missing (empty / no ladder panel fields under the tablist). ## Expected Show the ladder create UI: bid/ask side, start/end price, rungs, total pay, expiry/advanced, preview, and **Place N-rung ladder**. ## Likely location `frontend-dapp/src/pages/LimitOrdersPage.tsx` — Ladder panel is gated on wallet address: ```tsx {placeMode === 'ladder' && selectedPair && address && ( <LimitOrderLadderPanel ... /> )} ``` Single mode does not require `address` to render its form. If the wallet is disconnected (or `address` is briefly unset), Ladder mode shows no create options while the tab still looks selected. Also check `frontend-dapp/src/components/trade/LimitOrderLadderPanel.tsx` if a design-system regression hid the fields after #488.

PlasticDigits commented

2026-07-25 04:33:07 +00:00

(Migrated from gitlab.com)

mentioned in commit 97c539cda7

mentioned in commit 97c539cda771f6d5a6c4ae07c90c34fa18d69fbf

PlasticDigits commented

2026-07-25 04:33:14 +00:00

(Migrated from gitlab.com)

mentioned in merge request !1032

PlasticDigits commented

2026-07-25 04:33:17 +00:00

(Migrated from gitlab.com)

Fix implemented in !1032 (fix/494-limits-ladder-create-options).

Done vs acceptance:

Ladder create form renders when Place mode is Ladder + pair selected (no address && gate)
Fields: start/end price, rungs, total pay, expiry/advanced, preview mount path
Connect Wallet CTA parity with Single when disconnected
Unit tests + docs/skills invariant §14

Not run here: Playwright smoke against live LocalTerra/make dev (E2E case added in limit-orders.spec.ts for that).

Fix implemented in !1032 (`fix/494-limits-ladder-create-options`). **Done vs acceptance:** - [x] Ladder create form renders when Place mode is Ladder + pair selected (no `address &&` gate) - [x] Fields: start/end price, rungs, total pay, expiry/advanced, preview mount path - [x] Connect Wallet CTA parity with Single when disconnected - [x] Unit tests + docs/skills invariant §14 **Not run here:** Playwright smoke against live LocalTerra/`make dev` (E2E case added in `limit-orders.spec.ts` for that).

PlasticDigits commented

2026-07-25 04:46:18 +00:00

(Migrated from gitlab.com)

mentioned in commit d275d44a79

mentioned in commit d275d44a79fc7c5f16771d3e083cf87c3718c10b

PlasticDigits (Migrated from gitlab.com) closed this issue

2026-07-25 04:46:19 +00:00

PlasticDigits commented

2026-07-25 04:49:03 +00:00

(Migrated from gitlab.com)

mentioned in commit 0be38dc852

mentioned in commit 0be38dc852561f1b0ec2b6ce6f798f6edceb0b6c