fix(frontend): show ladder create options when wallet disconnected (#494) #1032

Merged

PlasticDigits merged 1 commit from fix/494-limits-ladder-create-options into main

2026-07-25 04:46:18 +00:00

PlasticDigits commented

2026-07-25 04:33:12 +00:00

(Migrated from gitlab.com)

Summary

Mount LimitOrderLadderPanel on /limits whenever Ladder mode and a pair are selected — remove the address && gate that hid create options when disconnected (#494).
Mirror Single / TradeOrderTicket Connect Wallet CTA: escrow/LUNC place gates apply only when connected; click opens the wallet modal.
Document invariant §14 in skills/AGENTS_LIMIT_ORDER_BATCH_LADDER.md, crosslink in docs/limit-orders.md, docs/design-system.md, and AGENTS.md.

Closes #494

Test plan

cd frontend-dapp && npm test -- LimitOrderLadderPanel.disconnect LimitOrderLadderPanel.crossing LimitOrdersPage --run (24 passed, run twice)
Manual: /limits disconnected → select pair → Ladder → start/end price, rungs, total pay, Connect Wallet CTA visible
Manual: connect wallet → place CTA becomes Place N-rung ladder and gates apply
Optional smoke E2E: limit-orders.spec.ts GitLab #494 case (needs make has-localterra + make dev)

## Summary - Mount `LimitOrderLadderPanel` on `/limits` whenever **Ladder** mode and a pair are selected — remove the `address &&` gate that hid create options when disconnected (#494). - Mirror Single / `TradeOrderTicket` **Connect Wallet** CTA: escrow/LUNC place gates apply only when connected; click opens the wallet modal. - Document invariant §14 in `skills/AGENTS_LIMIT_ORDER_BATCH_LADDER.md`, crosslink in `docs/limit-orders.md`, `docs/design-system.md`, and `AGENTS.md`. Closes #494 ## Test plan - [x] `cd frontend-dapp && npm test -- LimitOrderLadderPanel.disconnect LimitOrderLadderPanel.crossing LimitOrdersPage --run` (24 passed, run twice) - [ ] Manual: `/limits` disconnected → select pair → **Ladder** → start/end price, rungs, total pay, **Connect Wallet** CTA visible - [ ] Manual: connect wallet → place CTA becomes **Place N-rung ladder** and gates apply - [ ] Optional smoke E2E: `limit-orders.spec.ts` GitLab #494 case (needs `make has-localterra` + `make dev`)

ghost1 commented

2026-07-25 04:33:16 +00:00

(Migrated from gitlab.com)

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the [Cursor dashboard](https://www.cursor.com/dashboard/bugbot) to get automatic reviews on future PRs.

PlasticDigits commented

2026-07-25 04:33:17 +00:00

(Migrated from gitlab.com)

mentioned in issue #494