Verify #336: fix clippy useless_vec blocking indexer gate #512

Merged

PlasticDigits merged 1 commit from verify/336-clippy-integration-stage2 into main

2026-06-19 10:08:10 +00:00

PlasticDigits commented

2026-06-19 08:44:36 +00:00

(Migrated from gitlab.com)

Summary

Verification of #336 (wallet level history in profile modal via indexer) passed on main for all feature acceptance criteria. This MR only fixes a pre-existing clippy::useless_vec lint in integration_stage2.rs that blocked the required cargo clippy --all-targets -- -D warnings gate.

Verification checklist (#336)

Acceptance item	Command / method	Result
Wallet stats returns `level_history` with UTC timestamps	`bash scripts/verify-wallet-profile-anvil.sh` · `curl http://127.0.0.1:3100/v1/arena/wallet/{buyer}/stats`	PASS — 5 entries; L1 `reached_at` ISO-8601 UTC
Profile modal Level History section (levels 1–5, local time)	`cd frontend && npm test` (`WalletProfileModalSections.test.tsx`) · Playwright check on `/arena/protocol` live-buy profile click	PASS
Missing milestones show em dash	`WalletProfileModalSections.test.tsx` · curl sad-path wallet with no buys	PASS
Reorg rollback keeps history consistent	`YIELDOMEGA_PG_TEST_URL=... cargo test --test integration_stage2 arena_wallet_stats_level_history_and_reorg`	PASS
Indexer clippy + tests	`cd indexer && cargo clippy --all-targets -- -D warnings && cargo test`	PASS (after this MR’s `vec!` → array fix)
Frontend typecheck + lint + tests	`cd frontend && npm run typecheck && npm run lint && npm test`	PASS
E2E indexer + modal data	`bash scripts/verify-wallet-profile-anvil.sh`	PASS
`curl` Anvil buyer after scripted buy	Manual during stack run	PASS — `level_history[0].reached_at` populated
Click rival → modal Level History populated	Playwright on `http://127.0.0.1:5173/arena/protocol` (AUDIT live buys)	PASS

Test plan

bash scripts/verify-wallet-profile-anvil.sh
cd indexer && cargo clippy --all-targets -- -D warnings && cargo test
cd frontend && npm run typecheck && npm run lint && npm test
YIELDOMEGA_PG_TEST_URL=postgres://yieldomega:password@127.0.0.1:5433/yieldomega_indexer_test cargo test --test integration_stage2 arena_wallet_stats

## Summary Verification of [#336](https://gitlab.com/PlasticDigits/yieldomega/-/issues/336) (wallet level history in profile modal via indexer) passed on `main` for all feature acceptance criteria. This MR only fixes a pre-existing `clippy::useless_vec` lint in `integration_stage2.rs` that blocked the required `cargo clippy --all-targets -- -D warnings` gate. ## Verification checklist (#336) | Acceptance item | Command / method | Result | |-----------------|------------------|--------| | Wallet stats returns `level_history` with UTC timestamps | `bash scripts/verify-wallet-profile-anvil.sh` · `curl http://127.0.0.1:3100/v1/arena/wallet/{buyer}/stats` | **PASS** — 5 entries; L1 `reached_at` ISO-8601 UTC | | Profile modal Level History section (levels 1–5, local time) | `cd frontend && npm test` (`WalletProfileModalSections.test.tsx`) · Playwright check on `/arena/protocol` live-buy profile click | **PASS** | | Missing milestones show em dash | `WalletProfileModalSections.test.tsx` · curl sad-path wallet with no buys | **PASS** | | Reorg rollback keeps history consistent | `YIELDOMEGA_PG_TEST_URL=... cargo test --test integration_stage2 arena_wallet_stats_level_history_and_reorg` | **PASS** | | Indexer clippy + tests | `cd indexer && cargo clippy --all-targets -- -D warnings && cargo test` | **PASS** (after this MR’s `vec!` → array fix) | | Frontend typecheck + lint + tests | `cd frontend && npm run typecheck && npm run lint && npm test` | **PASS** | | E2E indexer + modal data | `bash scripts/verify-wallet-profile-anvil.sh` | **PASS** | | `curl` Anvil buyer after scripted buy | Manual during stack run | **PASS** — `level_history[0].reached_at` populated | | Click rival → modal Level History populated | Playwright on `http://127.0.0.1:5173/arena/protocol` (AUDIT live buys) | **PASS** | ## Test plan - [x] `bash scripts/verify-wallet-profile-anvil.sh` - [x] `cd indexer && cargo clippy --all-targets -- -D warnings && cargo test` - [x] `cd frontend && npm run typecheck && npm run lint && npm test` - [x] `YIELDOMEGA_PG_TEST_URL=postgres://yieldomega:password@127.0.0.1:5433/yieldomega_indexer_test cargo test --test integration_stage2 arena_wallet_stats`

PlasticDigits commented

2026-06-19 08:46:45 +00:00

(Migrated from gitlab.com)

Security review — MR !512

Commit reviewed: 5b3bf97e59f08c6cb71fb9115b5a596393e511c8

Scope: Single-line change in indexer/tests/integration_stage2.rs — replace vec![...] with array literal [...] in arena_session_summary_fixture_since_activity to satisfy clippy::useless_vec (-D warnings gate). No production indexer, API, contract, or frontend runtime code modified.

Method: Inspected full MR diff (8821b2df..5b3bf97e, 1 file, 1 hunk). Traced usage of logs in the test fixture (clone/iterate only; no attacker-controlled input, no I/O, auth, SQL, shell, or network paths). Checked prior MR discussion threads — none present.

Outcome: FINDINGS: 0 medium+

Security review: no medium+ findings on this diff.

This change is test-only lint cleanup with no observable security boundary impact. Inline review threads: none (no findings to anchor).

## Security review — MR !512 **Commit reviewed:** `5b3bf97e59f08c6cb71fb9115b5a596393e511c8` **Scope:** Single-line change in `indexer/tests/integration_stage2.rs` — replace `vec![...]` with array literal `[...]` in `arena_session_summary_fixture_since_activity` to satisfy `clippy::useless_vec` (`-D warnings` gate). No production indexer, API, contract, or frontend runtime code modified. **Method:** Inspected full MR diff (`8821b2df..5b3bf97e`, 1 file, 1 hunk). Traced usage of `logs` in the test fixture (clone/iterate only; no attacker-controlled input, no I/O, auth, SQL, shell, or network paths). Checked prior MR discussion threads — none present. **Outcome:** **FINDINGS: 0** medium+ **Security review: no medium+ findings on this diff.** This change is test-only lint cleanup with no observable security boundary impact. Inline review threads: none (no findings to anchor).

PlasticDigits (Migrated from gitlab.com) merged commit e60a100f0a into main

2026-06-19 10:08:10 +00:00

PlasticDigits commented

2026-06-19 10:08:11 +00:00

(Migrated from gitlab.com)

mentioned in commit e60a100f0a

mentioned in commit e60a100f0afc8d51c92387470f1d0dbd18bf3a15

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega!512

No description provided.

Rows
Columns