code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

Verify #320: align manual QA cross-links with shipped UI #495

Merged
PlasticDigits merged 1 commit from verify/issue-320-manual-qa-routes into main 2026-06-14 13:28:45 +00:00
Conversation 2 Commits 1 Files changed 1 +15 -15
PlasticDigits commented 2026-06-14 12:49:56 +00:00 (Migrated from gitlab.com)

Summary

Completes verification of GitLab #320 by fixing residual drift in manual-qa-checklists.md sections cross-linked from frontend-content-audit.md. Prior MRs reconciled product specs, content audit, pause ops, and indexer design; this patch aligns manual QA §280/§260/§291/§292/§290/§301 with shipped route IA (/ play, /arena/protocol AUDIT) and removed ArenaSubnav / decision-row chrome.

Acceptance checklist

Criterion Command / review Result
Progression/CRED constants match TimeArena.sol grep FIRST_BUY_CRED_BONUS docs/product/*.md + contracts/src/arena/TimeArena.sol PASS — 1100e18, MAX_PLAYER_LEVEL=5
Route IA consistent across product + audit docs cd frontend && npm test -- frontendContentAudit + manual review LaunchGate.tsx vs frontend-content-audit.md PASS
Pause doc matches _requireLive() Review docs/operations/pause-and-final-signoff.md L25 + TimeArena.claimWarBowFlag PASS — flag claim gated when paused
Indexer design lists implemented routes Review docs/indexer/design.md + indexer/src/api_arena.rs PASS — last-buy-epoch-pricing, warbow/latest-bp, cursor pagination
Doc anchors resolve bash scripts/check-doc-anchors.sh PASS
Content audit / surface tests cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic PASS (15 tests)
Manual QA cross-links (this MR) Review manual-qa-checklists.md §291/§292 vs shipped UI PASS after patch

Test plan

  • bash scripts/check-doc-anchors.sh
  • cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic
  • Manual review: LaunchGate.tsx routes vs frontend-content-audit.md

Follow-ups

  • Older manual QA sections outside the content-audit cross-links (e.g. §87 E2E, §95 wrong-network) still use /arena as a synonym; /arena redirects to / so steps work, but a future sweep could normalize all play-surface references to /.
## Summary Completes verification of GitLab #320 by fixing residual drift in `manual-qa-checklists.md` sections cross-linked from `frontend-content-audit.md`. Prior MRs reconciled product specs, content audit, pause ops, and indexer design; this patch aligns manual QA §280/§260/§291/§292/§290/§301 with shipped route IA (`/` play, `/arena/protocol` AUDIT) and removed `ArenaSubnav` / decision-row chrome. ## Acceptance checklist | Criterion | Command / review | Result | |-----------|------------------|--------| | Progression/CRED constants match `TimeArena.sol` | `grep FIRST_BUY_CRED_BONUS docs/product/*.md` + `contracts/src/arena/TimeArena.sol` | **PASS** — `1100e18`, `MAX_PLAYER_LEVEL=5` | | Route IA consistent across product + audit docs | `cd frontend && npm test -- frontendContentAudit` + manual review `LaunchGate.tsx` vs `frontend-content-audit.md` | **PASS** | | Pause doc matches `_requireLive()` | Review `docs/operations/pause-and-final-signoff.md` L25 + `TimeArena.claimWarBowFlag` | **PASS** — flag claim gated when paused | | Indexer design lists implemented routes | Review `docs/indexer/design.md` + `indexer/src/api_arena.rs` | **PASS** — `last-buy-epoch-pricing`, `warbow/latest-bp`, cursor pagination | | Doc anchors resolve | `bash scripts/check-doc-anchors.sh` | **PASS** | | Content audit / surface tests | `cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic` | **PASS** (15 tests) | | Manual QA cross-links (this MR) | Review `manual-qa-checklists.md` §291/§292 vs shipped UI | **PASS** after patch | ## Test plan - [x] `bash scripts/check-doc-anchors.sh` - [x] `cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic` - [x] Manual review: `LaunchGate.tsx` routes vs `frontend-content-audit.md` ## Follow-ups - Older manual QA sections outside the content-audit cross-links (e.g. §87 E2E, §95 wrong-network) still use `/arena` as a synonym; `/arena` redirects to `/` so steps work, but a future sweep could normalize all play-surface references to `/`.
PlasticDigits commented 2026-06-14 12:51:16 +00:00 (Migrated from gitlab.com)

Security review — MR !495

Commit reviewed: cd838666b341bdd6500171cca5ec42d7988f0409
Scope: docs/testing/manual-qa-checklists.md only — route IA cross-link updates (/arena → /, /arena/protocol AUDIT surface, removal of ArenaSubnav / decision-row references) for GitLab #320 verification.

Method

  • Inspected full MR diff (single file, documentation).
  • Traced changed content for attacker-controlled input reaching security-sensitive sinks (injection, authz, SSRF, XSS, shell execution, secret exposure, EVM contract surfaces).
  • Checked prior MR notes/discussions: none present.

Outcome

FINDINGS: 0 medium+

Security review: no medium+ findings on this diff.

This MR modifies manual QA checklist prose and pass criteria only. It does not change application code, indexer/API handlers, shell scripts, smart contracts, dependencies, or runtime configuration. Existing curl -sfI http://127.0.0.1:5173/... asset-check steps are unchanged (local dev smoke only). No new attack surface, permission boundary, or secret-handling behavior is introduced.

Inline threads: none (no findings to anchor).

## Security review — MR !495 **Commit reviewed:** `cd838666b341bdd6500171cca5ec42d7988f0409` **Scope:** `docs/testing/manual-qa-checklists.md` only — route IA cross-link updates (`/arena` → `/`, `/arena/protocol` AUDIT surface, removal of `ArenaSubnav` / decision-row references) for GitLab #320 verification. ### Method - Inspected full MR diff (single file, documentation). - Traced changed content for attacker-controlled input reaching security-sensitive sinks (injection, authz, SSRF, XSS, shell execution, secret exposure, EVM contract surfaces). - Checked prior MR notes/discussions: none present. ### Outcome **FINDINGS: 0** medium+ Security review: **no medium+ findings** on this diff. This MR modifies manual QA checklist prose and pass criteria only. It does not change application code, indexer/API handlers, shell scripts, smart contracts, dependencies, or runtime configuration. Existing `curl -sfI http://127.0.0.1:5173/...` asset-check steps are unchanged (local dev smoke only). No new attack surface, permission boundary, or secret-handling behavior is introduced. **Inline threads:** none (no findings to anchor).
PlasticDigits (Migrated from gitlab.com) merged commit 2ff23f39d9 into main 2026-06-14 13:28:46 +00:00
PlasticDigits commented 2026-06-14 13:28:48 +00:00 (Migrated from gitlab.com)

mentioned in commit 2ff23f39d9

mentioned in commit 2ff23f39d9321c192bb91d79fd446bc93a15cbce
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega!495
No description provided.