Verify #320: reconcile remaining design and manual QA doc drift #494

2026-06-14T12:15:38Z

PlasticDigits commented

2026-06-14 12:15:38 +00:00

(Migrated from gitlab.com)

Summary

Verification of GitLab #320 found most product, pause, indexer, and content-audit docs already aligned with shipped code. This MR fixes residual drift in docs/frontend/design.md and docs/testing/manual-qa-checklists.md:

Play surface route / (not /arena) with podium carousel on play and four-card grid on AUDIT only
Removed ArenaSubnav / decision-row chrome documented as not shipped
First-buy CRED bonus 1100e18 (was stale 150 CRED in manual QA §268)

Acceptance checklist

Criterion	Command / review	Result
Progression/CRED constants match `TimeArena.sol`	`grep FIRST_BUY_CRED_BONUS docs/product/.md` → 1100e18; `grep MAX_PLAYER_LEVEL docs/product/.md` → 5; manual QA §268 updated	PASS
Route IA consistent across product + audit docs	`LaunchGate.tsx` review; `cd frontend && npm test -- frontendContentAudit arenaCommandConsoleStatic`; `design.md` + `manual-qa-checklists.md` §298/§294/§68 routes	PASS (after MR)
Pause doc matches `_requireLive()`	`grep claimWarBowFlag docs/operations/pause-and-final-signoff.md` → `paused`; `TimeArena.sol` `claimWarBowFlag` calls `_requireLiveAndAutoroll()`	PASS
Indexer design lists implemented routes/events	`grep last-buy-epoch-pricing docs/indexer/design.md`; `grep warbow/latest-bp docs/indexer/design.md`; cursor pagination note	PASS
Doc anchors	`bash scripts/check-doc-anchors.sh`	PASS
Content audit tests	`cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic arenaSimplePlaySurface`	PASS
No contradictory CRED bonus across specs	No 150 CRED / 150e18 in product or QA docs after this MR	PASS (after MR)
Ops docs do not instruct unpaused actions while paused	`pause-and-final-signoff.md` + `final-signoff-and-value-movement.md`	PASS

Test plan

bash scripts/check-doc-anchors.sh
cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic arenaSimplePlaySurface

Manual: compared LaunchGate.tsx routes to frontend-content-audit.md and updated design.md / manual QA checklists.

Follow-ups

Historical invariants (INV-FRONTEND-266-ARENA-ROUTES, INV-FRONTEND-291-ARENA-COMMAND-CONSOLE) still mention /arena play route and decision row — consider a separate pass to update invariant summary rows without changing test semantics.

## Summary Verification of GitLab #320 found most product, pause, indexer, and content-audit docs already aligned with shipped code. This MR fixes residual drift in `docs/frontend/design.md` and `docs/testing/manual-qa-checklists.md`: - Play surface route **`/`** (not `/arena`) with podium carousel on play and four-card grid on AUDIT only - Removed **`ArenaSubnav`** / decision-row chrome documented as not shipped - First-buy CRED bonus **`1100e18`** (was stale **150 CRED** in manual QA §268) ## Acceptance checklist | Criterion | Command / review | Result | |-----------|------------------|--------| | Progression/CRED constants match `TimeArena.sol` | `grep FIRST_BUY_CRED_BONUS docs/product/*.md` → **1100e18**; `grep MAX_PLAYER_LEVEL docs/product/*.md` → **5**; manual QA §268 updated | **PASS** | | Route IA consistent across product + audit docs | `LaunchGate.tsx` review; `cd frontend && npm test -- frontendContentAudit arenaCommandConsoleStatic`; `design.md` + `manual-qa-checklists.md` §298/§294/§68 routes | **PASS** (after MR) | | Pause doc matches `_requireLive()` | `grep claimWarBowFlag docs/operations/pause-and-final-signoff.md` → **`paused`**; `TimeArena.sol` `claimWarBowFlag` calls `_requireLiveAndAutoroll()` | **PASS** | | Indexer design lists implemented routes/events | `grep last-buy-epoch-pricing docs/indexer/design.md`; `grep warbow/latest-bp docs/indexer/design.md`; cursor pagination note | **PASS** | | Doc anchors | `bash scripts/check-doc-anchors.sh` | **PASS** | | Content audit tests | `cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic arenaSimplePlaySurface` | **PASS** | | No contradictory CRED bonus across specs | No **150 CRED** / **150e18** in product or QA docs after this MR | **PASS** (after MR) | | Ops docs do not instruct unpaused actions while paused | `pause-and-final-signoff.md` + `final-signoff-and-value-movement.md` | **PASS** | ## Test plan ```bash bash scripts/check-doc-anchors.sh cd frontend && npm test -- surfaceContent frontendContentAudit arenaCommandConsoleStatic arenaSimplePlaySurface ``` Manual: compared `LaunchGate.tsx` routes to `frontend-content-audit.md` and updated `design.md` / manual QA checklists. ## Follow-ups - Historical invariants (`INV-FRONTEND-266-ARENA-ROUTES`, `INV-FRONTEND-291-ARENA-COMMAND-CONSOLE`) still mention `/arena` play route and decision row — consider a separate pass to update invariant summary rows without changing test semantics.

PlasticDigits commented

2026-06-14 12:17:12 +00:00

(Migrated from gitlab.com)

Security review — MR !494

Commit reviewed: 358bbbe0d7eb1fb712ff854c81f62efeec4dd186
Diff refs: base_sha ee36ffe698ff4051686fe05f7691c9c3feaf69c9 → head_sha 358bbbe0d7eb1fb712ff854c81f62efeec4dd186

Scope

Documentation-only reconciliation for GitLab #320:

docs/frontend/design.md — play route / (was /arena), podium carousel vs four-card grid, removed ArenaSubnav / decision-row chrome
docs/testing/manual-qa-checklists.md — FIRST_BUY_CRED_BONUS 1100e18 (was stale 150 CRED), route references / vs /arena

No Solidity, indexer, frontend executable, script, or dependency changes in this diff.

Method

Full MR diff reviewed; attacker-controlled input paths (SQL, shell, SSRF, authz, XSS, EVM sinks) not applicable — no runtime code touched.
Doc claims spot-checked against shipped code: LaunchGate.tsx index / + legacy /arena → / redirect; TimeArena.sol FIRST_BUY_CRED_BONUS = 1100e18.
Prior MR security threads: none.

Outcome

FINDINGS: 0 medium, high, or critical.

Security review: no medium+ findings on this diff. Doc updates reduce QA/spec drift (correct bonus constant and route IA) and do not introduce or expose exploitable behavior.

Inline threads: none (no findings to anchor).

## Security review — MR !494 **Commit reviewed:** `358bbbe0d7eb1fb712ff854c81f62efeec4dd186` **Diff refs:** `base_sha` `ee36ffe698ff4051686fe05f7691c9c3feaf69c9` → `head_sha` `358bbbe0d7eb1fb712ff854c81f62efeec4dd186` ### Scope Documentation-only reconciliation for GitLab #320: - `docs/frontend/design.md` — play route `/` (was `/arena`), podium carousel vs four-card grid, removed `ArenaSubnav` / decision-row chrome - `docs/testing/manual-qa-checklists.md` — `FIRST_BUY_CRED_BONUS` **1100e18** (was stale **150 CRED**), route references `/` vs `/arena` No Solidity, indexer, frontend executable, script, or dependency changes in this diff. ### Method - Full MR diff reviewed; attacker-controlled input paths (SQL, shell, SSRF, authz, XSS, EVM sinks) not applicable — no runtime code touched. - Doc claims spot-checked against shipped code: `LaunchGate.tsx` index `/` + legacy `/arena` → `/` redirect; `TimeArena.sol` `FIRST_BUY_CRED_BONUS = 1100e18`. - Prior MR security threads: none. ### Outcome **FINDINGS: 0** medium, high, or critical. Security review: **no medium+ findings** on this diff. Doc updates reduce QA/spec drift (correct bonus constant and route IA) and do not introduce or expose exploitable behavior. **Inline threads:** none (no findings to anchor).

PlasticDigits (Migrated from gitlab.com) merged commit a178a9ac37 into main

2026-06-14 12:27:42 +00:00

PlasticDigits commented

2026-06-14 12:27:43 +00:00

(Migrated from gitlab.com)

mentioned in commit a178a9ac37

mentioned in commit a178a9ac37d6033f7ce69c10e69cb52c0687f6b4

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega!494

Rows
Columns