code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

docs(#294): verification QA evidence alignment #443

Merged
PlasticDigits merged 1 commit from cursor/gitlab-issue-verification-7222 into main 2026-06-08 05:19:03 +00:00
Conversation 4 Commits 1 Files changed 4 +15 -8
PlasticDigits commented 2026-06-07 12:15:45 +00:00 (Migrated from gitlab.com)

Summary

Verification agent pass for GitLab #294 (shared UX primitives glass redesign). Implementation on main (commit d7e23c9) meets acceptance criteria; this MR only aligns QA docs/invariants with the post-#291 command-console layout and current Playwright specs.

Acceptance checklist

Criterion Command / evidence Result
Shared primitives native across routes cd frontend && npm run typecheck && npm run lint && npm test (564 tests) PASS
Shared primitives E2E smoke cd frontend && CI=1 npm run test:e2e -- --workers=5 e2e/arena.spec.ts e2e/referrals-surface.spec.ts (10 tests) PASS
Wallet profile sections readable WalletProfileModalSections.test.tsx (8 tests) PASS
Address blockie + last 6 hex SharedUxPrimitives.test.tsx, LiveBuyRow.test.tsx PASS
Chain gate component + copy chainMismatchWriteGuard.test.ts; ChainMismatchWriteBarrier.tsx glass CSS PASS (static)
Wrong-network Rabby gate (#95) bash scripts/verify-rabby-chain-mismatch.sh FAIL — Playwright/Rabby browser closed during requestSwitchChain (infra; re-run on Desktop QA)
Legacy hero buy modals E2E e2e/arena-live-buys-modals.spec.ts SKIP — targets pre-#291 hero strip; not a #294 gate (docs updated)
Glass CSS on wallet profile / modals / gates frontend/src/index.css (--yo-glass-*, .wallet-profile-modal__panel, .modal-panel, .chain-write-gate__card) PASS (static review)

Doc changes

  • docs/testing/manual-qa-checklists.md §294: protocol activity feed replaces hero buy-modals checklist row; E2E gate uses arena.spec.ts + referrals-surface.spec.ts.
  • docs/testing/invariants-and-business-logic.md: INV-FRONTEND-294-SHARED-PRIMITIVES evidence row updated.
  • docs/frontend/arena-views.md §294: note legacy ArenaBuyModals retired with #291.
  • docs/frontend/design.md §294: add E2E evidence links.
## Summary Verification agent pass for [GitLab #294](https://gitlab.com/PlasticDigits/yieldomega/-/work_items/294) (shared UX primitives glass redesign). Implementation on `main` (commit `d7e23c9`) meets acceptance criteria; this MR only aligns QA docs/invariants with the post-#291 command-console layout and current Playwright specs. ## Acceptance checklist | Criterion | Command / evidence | Result | |-----------|-------------------|--------| | Shared primitives native across routes | `cd frontend && npm run typecheck && npm run lint && npm test` (564 tests) | **PASS** | | Shared primitives E2E smoke | `cd frontend && CI=1 npm run test:e2e -- --workers=5 e2e/arena.spec.ts e2e/referrals-surface.spec.ts` (10 tests) | **PASS** | | Wallet profile sections readable | `WalletProfileModalSections.test.tsx` (8 tests) | **PASS** | | Address blockie + last 6 hex | `SharedUxPrimitives.test.tsx`, `LiveBuyRow.test.tsx` | **PASS** | | Chain gate component + copy | `chainMismatchWriteGuard.test.ts`; `ChainMismatchWriteBarrier.tsx` glass CSS | **PASS** (static) | | Wrong-network Rabby gate (#95) | `bash scripts/verify-rabby-chain-mismatch.sh` | **FAIL** — Playwright/Rabby browser closed during `requestSwitchChain` (infra; re-run on Desktop QA) | | Legacy hero buy modals E2E | `e2e/arena-live-buys-modals.spec.ts` | **SKIP** — targets pre-#291 hero strip; not a #294 gate (docs updated) | | Glass CSS on wallet profile / modals / gates | `frontend/src/index.css` (`--yo-glass-*`, `.wallet-profile-modal__panel`, `.modal-panel`, `.chain-write-gate__card`) | **PASS** (static review) | ## Doc changes - `docs/testing/manual-qa-checklists.md` §294: protocol activity feed replaces hero buy-modals checklist row; E2E gate uses `arena.spec.ts` + `referrals-surface.spec.ts`. - `docs/testing/invariants-and-business-logic.md`: `INV-FRONTEND-294-SHARED-PRIMITIVES` evidence row updated. - `docs/frontend/arena-views.md` §294: note legacy `ArenaBuyModals` retired with #291. - `docs/frontend/design.md` §294: add E2E evidence links.
PlasticDigits commented 2026-06-07 12:15:57 +00:00 (Migrated from gitlab.com)

mentioned in issue #294

mentioned in issue #294
ghost1 commented 2026-06-07 12:18:23 +00:00 (Migrated from gitlab.com)

Security review

Commit reviewed: a20dd5bbbac6a6e214f6fd80676d3c4a74f7c0fe
Scope: MR !443 — docs-only QA evidence alignment for GitLab #294 (4 files: docs/frontend/arena-views.md, docs/frontend/design.md, docs/testing/invariants-and-business-logic.md, docs/testing/manual-qa-checklists.md).

Outcome

FINDINGS: 0 (no medium, high, or critical issues on this diff)

Summary

This MR updates documentation and manual QA checklists to reflect the post-#291 command-console layout: legacy ArenaBuyModals references are retired, E2E gate specs point to e2e/arena.spec.ts and e2e/referrals-surface.spec.ts, and invariant evidence rows are aligned. No executable code, configuration, dependencies, or secrets are modified.

Reviewed attack surfaces (injection, authn/authz, SSRF, XSS sinks, secret leakage, unsafe deserialization, supply-chain) — none introduced or exposed by these markdown-only edits.

Inline threads

None — no findings to anchor on specific diff lines.

Automated security review (cursor/mr-security-review)

## Security review **Commit reviewed:** `a20dd5bbbac6a6e214f6fd80676d3c4a74f7c0fe` **Scope:** MR !443 — docs-only QA evidence alignment for GitLab #294 (4 files: `docs/frontend/arena-views.md`, `docs/frontend/design.md`, `docs/testing/invariants-and-business-logic.md`, `docs/testing/manual-qa-checklists.md`). ### Outcome **FINDINGS: 0** (no medium, high, or critical issues on this diff) ### Summary This MR updates documentation and manual QA checklists to reflect the post-#291 command-console layout: legacy `ArenaBuyModals` references are retired, E2E gate specs point to `e2e/arena.spec.ts` and `e2e/referrals-surface.spec.ts`, and invariant evidence rows are aligned. **No executable code, configuration, dependencies, or secrets are modified.** Reviewed attack surfaces (injection, authn/authz, SSRF, XSS sinks, secret leakage, unsafe deserialization, supply-chain) — none introduced or exposed by these markdown-only edits. ### Inline threads None — no findings to anchor on specific diff lines. --- *Automated security review (cursor/mr-security-review)*
PlasticDigits commented 2026-06-08 05:19:03 +00:00 (Migrated from gitlab.com)

mentioned in commit c5859b48a4

mentioned in commit c5859b48a444e44ec5c6f8c63a2c829e3e36c889
PlasticDigits (Migrated from gitlab.com) merged commit c5859b48a4 into main 2026-06-08 05:19:03 +00:00
PlasticDigits commented 2026-06-08 08:45:14 +00:00 (Migrated from gitlab.com)

mentioned in commit 553ac7e455

mentioned in commit 553ac7e455b7a3ac815397f45b126673fe45ff0e
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega!443
No description provided.