code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

docs: trim remaining historical timecurve mentions in satellite docs (#284) #417

Merged
PlasticDigits merged 1 commit from cursor/trim-timecurve-satellite-docs-474d into main 2026-06-03 14:01:26 +00:00
Conversation 3 Commits 1 Files changed 12 +68 -21
PlasticDigits commented 2026-06-03 13:55:04 +00:00 (Migrated from gitlab.com)

Summary

Addresses GitLab #284: follow-up to #263 / #276 to reduce confusing historical timecurve vocabulary in satellite documentation (no runtime changes).

What changed

  • Cross-links to indexer live podiums now use #arena-podiums-http (anchor already existed in docs/indexer/design.md).
  • Buy wallet-session drift invariant anchor renamed to #arena-buy-wallet-session-drift-gitlab-144; all docs/ and indexer/README.md callers updated.
  • Manual QA #95 / #194 steps use current DOM testids: arena-simple-chain-write-gate, arena-simple-buy-charm.
  • QA onboarding labels timecurve-bot as the legacy CLI binary name for bots/timearena (per issue constraints).
  • New CI gate bash scripts/check-doc-timecurve-satellite.sh forbids stale write-gate testids and pre-rename anchor links in docs/ / skills/.
  • Documented INV-DOCS-284-* in docs/testing/invariants-and-business-logic.md; cross-linked from guardrails skill, strategy, and ci docs.

Intentionally unchanged (per issue)

  • Legacy /timecurve → /arena redirect notes, denylist TimeCurve rows, retired idx_timecurve_* / GET /v1/timecurve/* retirement sentences, timecurve-bot command examples, and historical art path 404 checks.

Acceptance checklist

Criterion Verification Result
Satellite docs use /arena, GET /v1/arena/*, idx_arena_* as primary vocabulary; retired timecurve only in explicit legacy/retired sentences Review diff + rg -n 'timecurve|idx_timecurve' docs/ --glob '*.md' PASS
No broken markdown anchors bash scripts/check-doc-anchors.sh PASS
P0 retired ops terms gate bash scripts/check-doc-retired-terms.sh PASS
Satellite TimeCurve|FeeRouter budget (#276) bash scripts/check-doc-satellite-retired-count.sh PASS
New timecurve satellite gate (#284) bash scripts/check-doc-timecurve-satellite.sh PASS
Zero stale timecurve-arena-buy-chain-write-gate in docs rg 'timecurve-arena-buy-chain-write-gate' docs/ PASS (0 hits)
Active cross-links use #arena-podiums-http / #arena-buy-wallet-session-drift-gitlab-144 rg '#timecurve-podiums-http|#timecurve-buy-wallet' docs/ (only denylist in script) PASS
Docs-only: frontend/indexer tests unchanged No code under frontend/src or indexer/src modified SKIP (not required; no runtime edits)

Blockers: none

Issue #284: left open until MR merge.

Third-party verification

bash scripts/check-doc-anchors.sh
bash scripts/check-doc-retired-terms.sh
bash scripts/check-doc-satellite-retired-count.sh
bash scripts/check-doc-timecurve-satellite.sh
rg 'timecurve-arena-buy-chain-write-gate' docs/   # expect no output
rg '#timecurve-podiums-http' docs/ skills/        # expect only scripts/check-doc-timecurve-satellite.sh denylist

Manual spot-check: open docs/testing/manual-qa-checklists.md §95 / §194 and confirm testids match ArenaSimplePage.tsx.

## Summary Addresses GitLab [#284](https://gitlab.com/PlasticDigits/yieldomega/-/issues/284): follow-up to [#263](https://gitlab.com/PlasticDigits/yieldomega/-/issues/263) / [#276](https://gitlab.com/PlasticDigits/yieldomega/-/issues/276) to reduce confusing historical **`timecurve`** vocabulary in satellite documentation (no runtime changes). **What changed** - Cross-links to indexer live podiums now use **`#arena-podiums-http`** (anchor already existed in `docs/indexer/design.md`). - Buy wallet-session drift invariant anchor renamed to **`#arena-buy-wallet-session-drift-gitlab-144`**; all `docs/` and `indexer/README.md` callers updated. - Manual QA [#95](https://gitlab.com/PlasticDigits/yieldomega/-/issues/95) / [#194](https://gitlab.com/PlasticDigits/yieldomega/-/issues/194) steps use current DOM testids: **`arena-simple-chain-write-gate`**, **`arena-simple-buy-charm`**. - QA onboarding labels **`timecurve-bot`** as the **legacy CLI binary name** for `bots/timearena` (per issue constraints). - New CI gate **`bash scripts/check-doc-timecurve-satellite.sh`** forbids stale write-gate testids and pre-rename anchor links in **`docs/`** / **`skills/`**. - Documented **`INV-DOCS-284-*`** in [`docs/testing/invariants-and-business-logic.md`](docs/testing/invariants-and-business-logic.md); cross-linked from guardrails skill, strategy, and ci docs. **Intentionally unchanged (per issue)** - Legacy **`/timecurve` → `/arena`** redirect notes, denylist **`TimeCurve`** rows, retired **`idx_timecurve_*`** / **`GET /v1/timecurve/*`** retirement sentences, **`timecurve-bot`** command examples, and historical art path 404 checks. --- ## Acceptance checklist | Criterion | Verification | Result | |-----------|--------------|--------| | Satellite docs use `/arena`, `GET /v1/arena/*`, `idx_arena_*` as primary vocabulary; retired `timecurve` only in explicit legacy/retired sentences | Review diff + `rg -n 'timecurve\|idx_timecurve' docs/ --glob '*.md'` | **PASS** | | No broken markdown anchors | `bash scripts/check-doc-anchors.sh` | **PASS** | | P0 retired ops terms gate | `bash scripts/check-doc-retired-terms.sh` | **PASS** | | Satellite TimeCurve\|FeeRouter budget (#276) | `bash scripts/check-doc-satellite-retired-count.sh` | **PASS** | | New timecurve satellite gate (#284) | `bash scripts/check-doc-timecurve-satellite.sh` | **PASS** | | Zero stale `timecurve-arena-buy-chain-write-gate` in docs | `rg 'timecurve-arena-buy-chain-write-gate' docs/` | **PASS** (0 hits) | | Active cross-links use `#arena-podiums-http` / `#arena-buy-wallet-session-drift-gitlab-144` | `rg '#timecurve-podiums-http\|#timecurve-buy-wallet' docs/` (only denylist in script) | **PASS** | | Docs-only: frontend/indexer tests unchanged | No code under `frontend/src` or `indexer/src` modified | **SKIP** (not required; no runtime edits) | **Blockers:** none **Issue #284:** left **open** until MR merge. --- ## Third-party verification ```bash bash scripts/check-doc-anchors.sh bash scripts/check-doc-retired-terms.sh bash scripts/check-doc-satellite-retired-count.sh bash scripts/check-doc-timecurve-satellite.sh rg 'timecurve-arena-buy-chain-write-gate' docs/ # expect no output rg '#timecurve-podiums-http' docs/ skills/ # expect only scripts/check-doc-timecurve-satellite.sh denylist ``` Manual spot-check: open [`docs/testing/manual-qa-checklists.md`](docs/testing/manual-qa-checklists.md) §95 / §194 and confirm testids match [`ArenaSimplePage.tsx`](frontend/src/pages/arena/ArenaSimplePage.tsx).
ghost1 commented 2026-06-03 13:59:46 +00:00 (Migrated from gitlab.com)

Security review (automated)

Commit reviewed: e070f55d3ec0ed3de1b0946c3dccecab2d13e96f

Scope: Documentation and CI doc-gate only (#284): markdown anchor/testid vocabulary updates in docs/, skills/, indexer/README.md; new scripts/check-doc-timecurve-satellite.sh (hardcoded rg --fixed-strings patterns); unit-tests.yml runs the new script. No changes to frontend/src, indexer/src, contracts, or runtime auth paths.

Outcome: FINDINGS: 0 (no medium, high, or critical issues on this diff)

Notes: The new check script has no attacker-controlled input; it only scans docs/ and skills/ for retired strings. Doc testid updates align manual QA with current Arena DOM (arena-simple-chain-write-gate, arena-simple-buy-charm) and do not weaken onchain or API security controls.

Inline threads: none (no findings)

--- **Security review** (automated) **Commit reviewed:** `e070f55d3ec0ed3de1b0946c3dccecab2d13e96f` **Scope:** Documentation and CI doc-gate only ([#284](https://gitlab.com/PlasticDigits/yieldomega/-/issues/284)): markdown anchor/testid vocabulary updates in `docs/`, `skills/`, `indexer/README.md`; new `scripts/check-doc-timecurve-satellite.sh` (hardcoded `rg --fixed-strings` patterns); `unit-tests.yml` runs the new script. No changes to `frontend/src`, `indexer/src`, contracts, or runtime auth paths. **Outcome:** `FINDINGS: 0` (no medium, high, or critical issues on this diff) **Notes:** The new check script has no attacker-controlled input; it only scans `docs/` and `skills/` for retired strings. Doc testid updates align manual QA with current Arena DOM (`arena-simple-chain-write-gate`, `arena-simple-buy-charm`) and do not weaken onchain or API security controls. **Inline threads:** none (no findings) ---
PlasticDigits (Migrated from gitlab.com) merged commit a4a889c4ab into main 2026-06-03 14:01:26 +00:00
PlasticDigits commented 2026-06-03 14:01:30 +00:00 (Migrated from gitlab.com)

mentioned in commit a4a889c4ab

mentioned in commit a4a889c4abbbdf8a09dc7aa918db355bfa0a6a39
PlasticDigits commented 2026-06-08 08:45:13 +00:00 (Migrated from gitlab.com)

mentioned in commit bbe00cf3f0

mentioned in commit bbe00cf3f0dfe62888828c43606435bbd658224a
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega!417
No description provided.