code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

Rename timecurve-* Arena CSS and art to arena-* (#280) #408

Merged
PlasticDigits merged 1 commit from cursor/arena-css-naming-280-9ea9 into main 2026-06-03 11:54:46 +00:00
Conversation 2 Commits 1 Files changed 29 +138 -35
PlasticDigits commented 2026-06-03 11:38:49 +00:00 (Migrated from gitlab.com)

Summary

Completes GitLab #280 follow-up to #266: rename lingering timecurve-* CSS classes, data-testids, and public art paths to arena-* for Arena v2 product language. No onchain, indexer, or route behavior changes.

Changes

  • Align TSX/DOM with existing arena-* rules in index.css (agent card, protocol page, buy projected effects).
  • Git-mv podium icons, scene JPEGs (arena-simple.jpg fixes broken timer hero asset), header-arena.png.
  • Add scripts/check-arena-naming.sh + CI scripts-smoke gate.
  • Document INV-FRONTEND-280-ARENA-CSS-NAMING, manual QA §280, arena-views §280, guardrails cross-link.

Verification

Item Command Result
Naming gate bash scripts/check-arena-naming.sh PASS
Typecheck cd frontend && npm run typecheck PASS
Lint cd frontend && npm run lint PASS (warnings only)
Unit tests cd frontend && npm test PASS
Build cd frontend && npm run build PASS

Relates to #266. Closes #280.

## Summary Completes GitLab #280 follow-up to #266: rename lingering `timecurve-*` CSS classes, `data-testid`s, and public art paths to `arena-*` for Arena v2 product language. No onchain, indexer, or route behavior changes. ## Changes - Align TSX/DOM with existing `arena-*` rules in `index.css` (agent card, protocol page, buy projected effects). - Git-mv podium icons, scene JPEGs (`arena-simple.jpg` fixes broken timer hero asset), `header-arena.png`. - Add `scripts/check-arena-naming.sh` + CI `scripts-smoke` gate. - Document `INV-FRONTEND-280-ARENA-CSS-NAMING`, manual QA §280, arena-views §280, guardrails cross-link. ## Verification | Item | Command | Result | |------|---------|--------| | Naming gate | `bash scripts/check-arena-naming.sh` | PASS | | Typecheck | `cd frontend && npm run typecheck` | PASS | | Lint | `cd frontend && npm run lint` | PASS (warnings only) | | Unit tests | `cd frontend && npm test` | PASS | | Build | `cd frontend && npm run build` | PASS | Relates to #266. Closes #280.
ghost1 commented 2026-06-03 11:42:05 +00:00 (Migrated from gitlab.com)

Security review (automation)

Commit reviewed: 79845f7d76c0f6499ee82d7f3fbe794a8e0f5d31
Scope: GitLab MR !408 — rename lingering timecurve-* CSS classes, data-testids, and public art paths to arena-* (#280); adds scripts/check-arena-naming.sh and a scripts-smoke CI step. No onchain, indexer, API, auth, or route-behavior changes in this diff.

Method: Reviewed added/modified paths only (frontend/src/**, frontend/public/art/**, scripts/check-arena-naming.sh, .github/workflows/unit-tests.yml, docs). Traced whether attacker-controlled input reaches new sinks (injection, XSS, SSRF, path traversal, secret leakage, authz bypass).

Outcome: FINDINGS: 0 (no medium, high, or critical issues with a plausible attack path on this diff).

  • XSS / HTML injection: Changes are static className, data-testid, and /art/... literals. ArenaBuyProjectedEffects still renders items as React text children (unchanged); className is only passed as a fixed string from callers.
  • Injection / CI script: check-arena-naming.sh scans repo files via find + rg; no runtime user input; allowlist is a fixed path list for intentional /timecurve redirects and revert strings.
  • Authn/authz / secrets / SSRF / deserialization: Not touched.
  • Supply chain: No new dependencies.

Inline threads: None (no findings to anchor).

Security review: no medium+ findings on this diff.

## Security review (automation) **Commit reviewed:** `79845f7d76c0f6499ee82d7f3fbe794a8e0f5d31` **Scope:** GitLab MR !408 — rename lingering `timecurve-*` CSS classes, `data-testid`s, and public art paths to `arena-*` (#280); adds `scripts/check-arena-naming.sh` and a `scripts-smoke` CI step. No onchain, indexer, API, auth, or route-behavior changes in this diff. **Method:** Reviewed added/modified paths only (`frontend/src/**`, `frontend/public/art/**`, `scripts/check-arena-naming.sh`, `.github/workflows/unit-tests.yml`, docs). Traced whether attacker-controlled input reaches new sinks (injection, XSS, SSRF, path traversal, secret leakage, authz bypass). **Outcome:** **FINDINGS: 0** (no medium, high, or critical issues with a plausible attack path on this diff). - **XSS / HTML injection:** Changes are static `className`, `data-testid`, and `/art/...` literals. `ArenaBuyProjectedEffects` still renders `items` as React text children (unchanged); `className` is only passed as a fixed string from callers. - **Injection / CI script:** `check-arena-naming.sh` scans repo files via `find` + `rg`; no runtime user input; allowlist is a fixed path list for intentional `/timecurve` redirects and revert strings. - **Authn/authz / secrets / SSRF / deserialization:** Not touched. - **Supply chain:** No new dependencies. **Inline threads:** None (no findings to anchor). Security review: **no medium+ findings** on this diff. <!-- cursor-automation-security-review -->
PlasticDigits (Migrated from gitlab.com) merged commit 5a4177b34d into main 2026-06-03 11:54:46 +00:00
PlasticDigits commented 2026-06-03 11:54:47 +00:00 (Migrated from gitlab.com)

mentioned in commit 5a4177b34d

mentioned in commit 5a4177b34d13e3dfd07a02ffb6a41c0b59c1a876
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega!408
No description provided.