QA: Setup missing steps #36

New issue

Closed

opened 2026-04-20 08:28:57 +00:00 by anubhav.pundir7761 · 6 comments

anubhav.pundir7761 commented 2026-04-20 08:28:57 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

Missing Info for setup

Summary
Missing required environment configuration for TimeCurve integration, preventing proper setup and visibility of on-chain data and fee routing.

Context
The application depends on environment variables to fetch live on-chain sale state and display canonical fee sink information. Currently, required variables (VITE_TIMECURVE_ADDRESS, VITE_FEE_ROUTER_ADDRESS) are not configured, which may lead to incomplete or non-functional UI states.

TimeCurve

Set VITE_TIMECURVE_ADDRESS in .env (see .env.example) to read live onchain sale state.

Canonical fee sinks (read-only)

Fee router: set VITE_FEE_ROUTER_ADDRESS to show sink destinations.

# Missing Info for setup **Summary**\ Missing required environment configuration for TimeCurve integration, preventing proper setup and visibility of on-chain data and fee routing. **Context**\ The application depends on environment variables to fetch live on-chain sale state and display canonical fee sink information. Currently, required variables (`VITE_TIMECURVE_ADDRESS`, `VITE_FEE_ROUTER_ADDRESS`) are not configured, which may lead to incomplete or non-functional UI states. # TimeCurve Set `VITE_TIMECURVE_ADDRESS` in `.env` (see `.env.example`) to read live onchain sale state. ### Canonical fee sinks (read-only) Fee router: set `VITE_FEE_ROUTER_ADDRESS` to show sink destinations.

anubhav.pundir7761 commented 2026-04-20 08:32:44 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

changed title from qa setup missing steps to QA: Setup missing steps

<p>changed title from <code class="idiff"><span class="idiff left right deletion">qa s</span>etup missing steps</code> to <code class="idiff"><span class="idiff left right addition">QA: S</span>etup missing steps</code></p>

anubhav.pundir7761 commented 2026-04-20 08:32:44 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

changed the description

changed the description

anubhav.pundir7761 commented 2026-04-20 08:38:56 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

changed the description

changed the description

PlasticDigits commented 2026-04-21 03:48:48 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

Implemented documentation and tooling to close the gap behind missing `VITE_TIMECURVE_ADDRESS` / `VITE_FEE_ROUTER_ADDRESS` during QA onboarding (merged to `main`).

Docs

• `docs/testing/e2e-anvil.md` — full `VITE_*` table now includes FeeRouter, referral registry, and when to set `VITE_INDEXER_URL`; notes Vite restart after env changes.
• `docs/qa/QA-onboarding-gitlab-issue-body.md` & `docs/qa/YO-TimeCurve-QA-Checklist.md` — new A1a (`make check-frontend-env`), acceptance bullets for non-empty TimeCurve + FeeRouter vars, restart `npm run dev` if the stack finished after dev started.
• `scripts/qa/README.md` — `write-frontend-env-local.sh --urls-only` explicitly documented as clearing all contract addresses (common footgun).

Automation

• `scripts/check-frontend-vite-env.sh` — validates merged `frontend/.env` + `frontend/.env.local` (deploy addresses + RPC + chain id).
• `make check-frontend-env` — Makefile target; `start-local-anvil-stack.sh` “Next:” output mentions it.

@anubhav.pundir7761 please pull latest `main`, run the local stack (or QA laptop flow), then `make check-frontend-env` before `npm run dev`. If that matches what you needed, please confirm here and close this issue.

Implemented documentation and tooling to close the gap behind missing \`VITE_TIMECURVE_ADDRESS\` / \`VITE_FEE_ROUTER_ADDRESS\` during QA onboarding (merged to \`main\`). **Docs** - \`docs/testing/e2e-anvil.md\` — full \`VITE_*\` table now includes FeeRouter, referral registry, and when to set \`VITE_INDEXER_URL\`; notes Vite restart after env changes. - \`docs/qa/QA-onboarding-gitlab-issue-body.md\` & \`docs/qa/YO-TimeCurve-QA-Checklist.md\` — new **A1a** (\`make check-frontend-env\`), acceptance bullets for non-empty TimeCurve + FeeRouter vars, restart \`npm run dev\` if the stack finished after dev started. - \`scripts/qa/README.md\` — \`write-frontend-env-local.sh --urls-only\` explicitly documented as clearing all contract addresses (common footgun). **Automation** - \`scripts/check-frontend-vite-env.sh\` — validates merged \`frontend/.env\` + \`frontend/.env.local\` (deploy addresses + RPC + chain id). - \`make check-frontend-env\` — Makefile target; \`start-local-anvil-stack.sh\` “Next:” output mentions it. @anubhav.pundir7761 please pull latest \`main\`, run the local stack (or QA laptop flow), then \`make check-frontend-env\` before \`npm run dev\`. If that matches what you needed, please confirm here and close this issue.

Brouie commented 2026-04-21 07:53:56 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

@PlasticDigits the env vars VITE_TIMECURVE_ADDRESS and VITE_FEE_ROUTER_ADDRESS are not missing — they're populated as part of the local-stack setup.

The correct flow per scripts/qa/README.md and issue #35 onboarding:

1. bash scripts/start-local-anvil-stack.sh from repo root (starts anvil, deploys contracts, writes .deploy/local.env with canonical addresses)
2. bash scripts/qa/write-frontend-env-local.sh (populates frontend/.env.local including the two VITE_* vars from .deploy/local.env)
3. cd frontend && npm run dev

Re-verified this flow today on 52b7f04 for #5 Anvil E2E — e2e-anvil.sh drives the same path and passes 3/3 (see #5 note). Env population is automatic, not a missing setup step.

If the contributor was on a fresh clone and only ran npm run dev without the stack, the .env.local file wouldn't exist yet — that's expected behavior, not a defect.

Closing as not-a-bug / operator error.

@PlasticDigits the env vars `VITE_TIMECURVE_ADDRESS` and `VITE_FEE_ROUTER_ADDRESS` are not missing — they're populated as part of the local-stack setup. The correct flow per `scripts/qa/README.md` and issue #35 onboarding: 1. `bash scripts/start-local-anvil-stack.sh` from repo root (starts anvil, deploys contracts, writes `.deploy/local.env` with canonical addresses) 2. `bash scripts/qa/write-frontend-env-local.sh` (populates `frontend/.env.local` including the two VITE_* vars from `.deploy/local.env`) 3. `cd frontend && npm run dev` Re-verified this flow today on 52b7f04 for #5 Anvil E2E — `e2e-anvil.sh` drives the same path and passes 3/3 (see #5 note). Env population is automatic, not a missing setup step. If the contributor was on a fresh clone and only ran `npm run dev` without the stack, the .env.local file wouldn't exist yet — that's expected behavior, not a defect. Closing as not-a-bug / operator error.

PlasticDigits (Migrated from gitlab.com) closed this issue 2026-04-21 13:25:27 +00:00

Brouie commented 2026-04-22 01:18:36 +00:00 (Migrated from gitlab.com)

• Copy link
• Copy Markdown

@PlasticDigits onboarding addressed on 52b7f04 via check-frontend-vite-env.sh + make check-frontend-env + docs updates (QA-onboarding, TimeCurve checklist, e2e-anvil, qa README, start script). This covers the env-confusion failure mode that prompted #36. Can be closed.

@PlasticDigits onboarding addressed on 52b7f04 via check-frontend-vite-env.sh + make check-frontend-env + docs updates (QA-onboarding, TimeCurve checklist, e2e-anvil, qa README, start script). This covers the env-confusion failure mode that prompted #36. Can be closed.

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

cac-design-issue-544

renovate/configure

No results found.

Labels

Clear labels   

agent:fix_bugfix

  

agent:fix_conflicts

  

agent:fix_security

  

agent:gap_analysis

  

agent:implement

  

agent:open_issues

  

agents

  

agent:security_audit

  

agent:verify

  

area

timecurve

  

arena

  

arena-v2

  

audit

  

block:feature_review

  

block:security

  

bug

  

contracts

  

design

  

devops

  

docs

Documentation

  

documentation

  

enhancement

  

epic

Epic / umbrella issue

  

feature

  

frontend

  

indexer

  

low priority

Low priority, investigate other issues first

  

megaeth

  

operations

  

ops

Deploy and operations

  

performance

  

QA

  

qa checklist

  

referrals

  

removal

Legacy removal

  

security

  

smart-contracts

  

tech-debt

  

testing

  

time-arena

TimeArena v2 revamp

  

timecurve

  

visual-qa

No labels

agent:fix_bugfix

agent:fix_conflicts

agent:fix_security

agent:gap_analysis

agent:implement

agent:open_issues

agents

agent:security_audit

agent:verify

area

timecurve

arena

arena-v2

audit

block:feature_review

block:security

bug

contracts

design

devops

docs

documentation

enhancement

epic

feature

frontend

indexer

low priority

megaeth

operations

ops

performance

QA

qa checklist

referrals

removal

security

smart-contracts

tech-debt

testing

time-arena

timecurve

visual-qa

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

code/yieldomega#36

No description provided.