code/yieldomega
Watch
4
0
Fork
You've already forked yieldomega
 0
Code Issues 1 Pull requests 1 Projects Releases Packages Wiki Activity

Add frontend UX unit tests for #331 visual features #339

New issue
Closed
opened 2026-06-19 04:27:52 +00:00 by PlasticDigits · 5 comments
PlasticDigits commented 2026-06-19 04:27:52 +00:00 (Migrated from gitlab.com)

Parent

Gap analysis follow-up from #331.

Current codebase

  • Strong frontend unit coverage for mechanics (timeArenaUx.test.ts, carousel locks, head-shake nonce, buy projected effects) — 694 Vitest tests passing.
  • Gap analysis noted weak coverage for progression glance, battle-on-open, and new #331 visual behaviors.
  • Parent approval: Frontend UX unit tests for existing features and new visual ones — must run after all visual #331 child issues are closed.

Why needed

Consolidate regression tests once visual work lands (next-level locks, level-up popover, buy toasts, while-you-were-away modal, level history in profile). Satisfies parent SYSTEM requirement: full unit tests with happy/sad paths.

Constraints / guardrails

  • Blocked on closing visual child issues from #331:
    • Next-level lock policy
    • Level-up confetti popover (L2+)
    • Post-buy effect toasts
    • While You Were Away modal
    • Wallet level history section (frontend portion)
  • Do not duplicate exhaustive mechanic tests already in timeArenaUx.test.ts / arenaBuyProjectedEffects.test.ts — focus on wiring + render + state transitions.
  • Indexer-first display invariants (#301).
  • No new product scope beyond approved #331 items.

Relevant files

Path Focus
frontend/src/pages/arena/ArenaSimplePage.test.tsx Play surface integration
frontend/src/lib/arenaProgression.test.ts Lock policy helpers
frontend/src/components/WalletProfileModalSections.test.tsx Level history section
New component tests Toast stack, level-up popover, away modal
frontend/src/pages/arena/indexerFirstDisplay.test.ts Indexer-first wiring

Recommended direction

  1. Add/extend tests per closed visual issue (table in MR linking each test file to child issue).
  2. Cover sad paths: indexer off → no away modal; reduced motion; L1 no celebration; empty level history.
  3. Update frontend-content-audit.md #331 rows if applicable (coordinate with E2E issue).

Acceptance criteria

  • Each closed #331 visual child has ≥1 focused Vitest file or describe block.
  • Happy + sad path cases documented in test names.
  • cd frontend && npm run typecheck && npm run lint && npm test — all pass.
  • No snapshot-only tests without behavioral asserts.

Test plan

Command Path
cd frontend && npm run typecheck && npm run lint && npm test All frontend/src/**/*.test.ts(x)

Attack / abuse test plan

  • Tests use mocked indexer responses; include malformed empty payloads and offline states.

Verification criteria

  • MR lists mapping: child issue → test file(s) → PASS.
  • Depends on visual issues merged first.

Dependencies

Do not start until all #331 VISUAL child issues are closed.

## Parent Gap analysis follow-up from [#331](https://gitlab.com/PlasticDigits/yieldomega/-/issues/331). ## Current codebase - Strong frontend unit coverage for mechanics (`timeArenaUx.test.ts`, carousel locks, head-shake nonce, buy projected effects) — **694** Vitest tests passing. - Gap analysis noted weak coverage for progression glance, battle-on-open, and new #331 visual behaviors. - Parent approval: **Frontend UX unit tests** for existing features **and** new visual ones — **must run after all visual #331 child issues are closed**. ## Why needed Consolidate regression tests once visual work lands (next-level locks, level-up popover, buy toasts, while-you-were-away modal, level history in profile). Satisfies parent **SYSTEM** requirement: full unit tests with happy/sad paths. ## Constraints / guardrails - **Blocked on** closing visual child issues from #331: - Next-level lock policy - Level-up confetti popover (L2+) - Post-buy effect toasts - While You Were Away modal - Wallet level history section (frontend portion) - Do not duplicate exhaustive mechanic tests already in `timeArenaUx.test.ts` / `arenaBuyProjectedEffects.test.ts` — focus on **wiring + render + state transitions**. - Indexer-first display invariants ([#301](https://gitlab.com/PlasticDigits/yieldomega/-/issues/301)). - No new product scope beyond approved #331 items. ## Relevant files | Path | Focus | |------|-------| | `frontend/src/pages/arena/ArenaSimplePage.test.tsx` | Play surface integration | | `frontend/src/lib/arenaProgression.test.ts` | Lock policy helpers | | `frontend/src/components/WalletProfileModalSections.test.tsx` | Level history section | | New component tests | Toast stack, level-up popover, away modal | | `frontend/src/pages/arena/indexerFirstDisplay.test.ts` | Indexer-first wiring | ## Recommended direction 1. Add/extend tests per closed visual issue (table in MR linking each test file to child issue). 2. Cover sad paths: indexer off → no away modal; reduced motion; L1 no celebration; empty level history. 3. Update `frontend-content-audit.md` #331 rows if applicable (coordinate with E2E issue). ## Acceptance criteria - [ ] Each closed #331 visual child has ≥1 focused Vitest file or describe block. - [ ] Happy + sad path cases documented in test names. - [ ] `cd frontend && npm run typecheck && npm run lint && npm test` — all pass. - [ ] No snapshot-only tests without behavioral asserts. ## Test plan | Command | Path | |---------|------| | `cd frontend && npm run typecheck && npm run lint && npm test` | All `frontend/src/**/*.test.ts(x)` | ## Attack / abuse test plan - Tests use mocked indexer responses; include malformed empty payloads and offline states. ## Verification criteria - MR lists mapping: child issue → test file(s) → PASS. - Depends on visual issues merged first. ## Dependencies **Do not start until all #331 VISUAL child issues are closed.**
PlasticDigits commented 2026-06-19 04:28:09 +00:00 (Migrated from gitlab.com)

mentioned in issue #331

mentioned in issue #331
PlasticDigits commented 2026-06-19 10:59:42 +00:00 (Migrated from gitlab.com)

mentioned in merge request !514

mentioned in merge request !514
PlasticDigits commented 2026-06-19 11:03:17 +00:00 (Migrated from gitlab.com)

mentioned in commit bbf6bbb3f7

mentioned in commit bbf6bbb3f7a14a5750d8247263a0b9ef2e9796bd
PlasticDigits commented 2026-06-19 11:07:40 +00:00 (Migrated from gitlab.com)

Verification — #339 (frontend UX unit tests for #331 visual features)

Branch: main @ bbf6bbb3 (MR issue-339-frontend-ux-unit-tests already merged)
Verifier: Cloud agent QA pass

Acceptance criteria

Criterion Result How verified
Each closed #331 visual child has ≥1 focused Vitest file or describe block PASS Mapping table below
Happy + sad path cases documented in test names PASS Spot-checked sad-path names: indexer-off WYWA (TimeArenaPage, arenaVisualUxHooks), reduced motion / L1 no celebration (LevelUpCelebrationPopover, arenaLevelUpCelebration), empty level history (#336), empty toast list (#337), malformed WYWA payload (#338)
cd frontend && npm run typecheck && npm run lint && npm test PASS typecheck exit 0 · lint 0 errors (3 pre-existing warnings) · 743/743 Vitest tests
No snapshot-only tests without behavioral asserts PASS rg '\.toMatchSnapshot|toMatchInlineSnapshot' frontend/src/**/*.test.* — no matches

Child issue → test file(s) → PASS

Child Test file(s) / describe block PASS
#334 Next-level lock policy arenaProgression.test.ts, ArenaSimplePodiumSection.test.tsx, ArenaTimerPodiumCarousel.test.tsx, ArenaSimplePage.test.tsx (#331 visual feature wiring) ✓
#335 Level-up confetti popover (L2+) arenaLevelUpCelebration.test.ts, LevelUpCelebrationPopover.test.tsx, arenaVisualUxHooks.test.ts, ArenaSimplePage.test.tsx ✓
#336 Wallet level history WalletProfileModalSections.test.tsx ✓
#337 Post-buy effect toasts arenaBuyEffectToastLines.test.ts, ArenaEffectToastStack.test.tsx, mobileBuyEffectToastLayout.test.ts, arenaVisualUxHooks.test.ts, ArenaSimplePage.test.tsx ✓
#338 While You Were Away modal whileYouWereAwayActivity.test.ts, arenaSessionClose.test.ts, WhileYouWereAwayModal.test.tsx, indexerApi.test.ts, arenaVisualUxHooks.test.ts, TimeArenaPage.test.tsx ✓

Attack / abuse plan

Check Result
Mocked indexer responses with malformed/empty payloads PASS — whileYouWereAwayActivity.test.ts (not-a-number, empty epochs)
Offline / indexer-off states PASS — arenaVisualUxHooks.test.ts (indexerBaseUrl unset), TimeArenaPage.test.tsx (no modal when hook state null)

Indexer-first invariant (#301)

SKIP — not in #339 scope; existing indexerFirstDisplay.test.ts unchanged and still passes in full suite.

Dependency note

Visual child #337 remains open for its own agent:verify pass (screenshots/E2E). #339 unit-test coverage for #337 is present on main; #339 does not block on #337 closure.

Follow-ups

  • #340 — Anvil E2E play-feel coverage for #331 visual features (complements this unit suite).

Closing as verified on main.

## Verification — #339 (frontend UX unit tests for #331 visual features) **Branch:** `main` @ `bbf6bbb3` (MR `issue-339-frontend-ux-unit-tests` already merged) **Verifier:** Cloud agent QA pass ### Acceptance criteria | Criterion | Result | How verified | |-----------|--------|--------------| | Each closed #331 visual child has ≥1 focused Vitest file or describe block | **PASS** | Mapping table below | | Happy + sad path cases documented in test names | **PASS** | Spot-checked sad-path names: indexer-off WYWA (`TimeArenaPage`, `arenaVisualUxHooks`), reduced motion / L1 no celebration (`LevelUpCelebrationPopover`, `arenaLevelUpCelebration`), empty level history (#336), empty toast list (#337), malformed WYWA payload (#338) | | `cd frontend && npm run typecheck && npm run lint && npm test` | **PASS** | typecheck exit 0 · lint 0 errors (3 pre-existing warnings) · **743/743** Vitest tests | | No snapshot-only tests without behavioral asserts | **PASS** | `rg '\.toMatchSnapshot\|toMatchInlineSnapshot' frontend/src/**/*.test.*` — no matches | ### Child issue → test file(s) → PASS | Child | Test file(s) / describe block | PASS | |-------|------------------------------|------| | **#334** Next-level lock policy | `arenaProgression.test.ts`, `ArenaSimplePodiumSection.test.tsx`, `ArenaTimerPodiumCarousel.test.tsx`, `ArenaSimplePage.test.tsx` (`#331 visual feature wiring`) | ✓ | | **#335** Level-up confetti popover (L2+) | `arenaLevelUpCelebration.test.ts`, `LevelUpCelebrationPopover.test.tsx`, `arenaVisualUxHooks.test.ts`, `ArenaSimplePage.test.tsx` | ✓ | | **#336** Wallet level history | `WalletProfileModalSections.test.tsx` | ✓ | | **#337** Post-buy effect toasts | `arenaBuyEffectToastLines.test.ts`, `ArenaEffectToastStack.test.tsx`, `mobileBuyEffectToastLayout.test.ts`, `arenaVisualUxHooks.test.ts`, `ArenaSimplePage.test.tsx` | ✓ | | **#338** While You Were Away modal | `whileYouWereAwayActivity.test.ts`, `arenaSessionClose.test.ts`, `WhileYouWereAwayModal.test.tsx`, `indexerApi.test.ts`, `arenaVisualUxHooks.test.ts`, `TimeArenaPage.test.tsx` | ✓ | ### Attack / abuse plan | Check | Result | |-------|--------| | Mocked indexer responses with malformed/empty payloads | **PASS** — `whileYouWereAwayActivity.test.ts` (`not-a-number`, empty epochs) | | Offline / indexer-off states | **PASS** — `arenaVisualUxHooks.test.ts` (`indexerBaseUrl` unset), `TimeArenaPage.test.tsx` (no modal when hook state null) | ### Indexer-first invariant (#301) **SKIP** — not in #339 scope; existing `indexerFirstDisplay.test.ts` unchanged and still passes in full suite. ### Dependency note Visual child **#337** remains open for its own `agent:verify` pass (screenshots/E2E). #339 unit-test coverage for #337 is present on `main`; #339 does not block on #337 closure. ### Follow-ups - **#340** — Anvil E2E play-feel coverage for #331 visual features (complements this unit suite). Closing as verified on `main`.
PlasticDigits (Migrated from gitlab.com) closed this issue 2026-06-19 11:07:41 +00:00
PlasticDigits commented 2026-06-19 13:31:43 +00:00 (Migrated from gitlab.com)

mentioned in issue #340

mentioned in issue #340
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
cac-design-issue-544
renovate/configure
No results found.
Labels
Clear labels   
agent:fix_bugfix

   
agent:fix_conflicts

   
agent:fix_security

   
agent:gap_analysis

   
agent:implement

   
agent:open_issues

   
agents

   
agent:security_audit

   
agent:verify
  
area
timecurve

  
arena

   
arena-v2

   
audit

   
block:feature_review

   
block:security

   
bug

   
contracts

   
design

   
devops

   
docs
Documentation

  
documentation

   
enhancement

   
epic
Epic / umbrella issue

  
feature

   
frontend

   
indexer

   
low priority
Low priority, investigate other issues first

  
megaeth

   
operations

   
ops
Deploy and operations

  
performance

   
QA

   
qa checklist

   
referrals

   
removal
Legacy removal

  
security

   
smart-contracts

   
tech-debt

   
testing

   
time-arena
TimeArena v2 revamp

  
timecurve

   
visual-qa
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/yieldomega#339
No description provided.