Mobile: music UI overlaps top menu card #103
Labels
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:open_issues
agents
agent:security_audit
agent:verify
area
timecurve
arena
arena-v2
audit
block:feature_review
block:security
bug
contracts
design
devops
docs
documentation
enhancement
epic
feature
frontend
indexer
low priority
megaeth
operations
ops
performance
QA
qa checklist
referrals
removal
security
smart-contracts
tech-debt
testing
time-arena
timecurve
visual-qa
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
code/yieldomega#103
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
On mobile view, the music player overlaps slightly with the top menu card.
Screenshot
Steps to reproduce
Expected behavior
Music should sit fully above the top menu card with no visual overlap.
Actual behavior
Music overlaps slightly with the top menu card.
Recommended fix
Add extra padding at the top in the mobile layout so the music clears the top menu card.
Acceptance criteria
mentioned in commit cl8y-bridge-monorepo@1b7a55147cdc780d91b9b85d08bb6ddba8f566c3
GL-126 fix merged to
main(commit1b7a551)@Brouie — please verify on a real phone / mobile emulation when you have a moment. Issue left open until you confirm.
What changed
<main>now usespt-6below themdbreakpoint (waspt-3);md:and up still usemd:pt-4/md:pb-8(unchanged tablet/desktop rhythm per acceptance criteria).top-6vsmd:top-2) soblur-3xldoes not crowd the nav edge.packages/frontend/src/components/layout/layoutShellClasses.ts(documented as INV-MOB1 indocs/FRONTEND_BRIDGE_INVARIANTS.md; agent skillskills/agent-frontend-mobile-layout.md).Verification checklist
md+): vertical spacing matches pre-fix (no extra top gap vs before cl8y-bridge-monorepo#126).npm run test:run -- src/components/layout/layoutShellClasses.test.tsinpackages/frontend(Vitest guard on the Tailwind tokens).If anything still clips on a specific embed or experience route, note viewport + URL and we can tune only the
<mdtokens inlayoutShellClasses.ts.moved from cl8y-bridge-monorepo#126
mentioned in commit cl8y-bridge-monorepo@05d37aaebeca1438e4ee1cb7ac52f9d47604a800
mentioned in issue cl8y-bridge-monorepo#126
mentioned in commit cl8y-bridge-monorepo@ae28b7b69155da80f94079432f6a00dec0185b85
mentioned in commit
320021e460GitLab #103 — mobile dock clearance merged (INV-AUDIO-103)
This MR/advance fixes Work item #103 on
main(320021e).What changed
max-width: 720px):.app-headernow usesmargin-top: max(0.75rem, calc(env(safe-area-inset-top, 0px) + 4.5rem))so the fixed Blockie Hills dock (.album-player-dock, z-index 1050) sits above the bordered nav card with a visible gap — no overlap on typical phones.top/righton the dock stay as in #68; tablet/desktop (min-width: 721px) keepsmargin-top: 1remon the header.MOBILE_HEADER_TOP_CLEARANCE_BELOW_SAFE_AREA_REMinfrontend/src/audio/mobileAlbumDockLayout.tsmust stay aligned with the+ 4.5remterm infrontend/src/index.css; Vitest guards parity (mobileAlbumDockLayout.test.ts).docs/testing/invariants-and-business-logic.md(INV-AUDIO-103),manual-qa-checklists.md§103,sound-effects-recommendations.md§8,timecurve-views.md; contributor skillskills/contributor-mobile-album-dock/SKILL.md.Verification checklist for @Brouie
≥721px): Header top spacing matches previous baseline (no accidental mobile-only regression).cd frontend && npm ci && npm run test -- src/audio/mobileAlbumDockLayout.test.tsIssue left open pending your confirmation on a real device. Thanks!
/cc @Brouie
mentioned in issue #100
mentioned in issue #107
mentioned in commit
33d8d07331mentioned in commit
7ec88284a2verified on
320021e(INV-AUDIO-103 fix). devtools mobile viewport at 390×844 (iPhone 12 Pro):passes the narrow-mobile and ~390×844 acceptance criteria. tablet/desktop unchanged per the existing media-query gating in index.css line 3157.