chore: leftover CODEOWNERS S3 (protection GET + plant-check) #3
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
code/tradair-landing#3
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Leftover-complete for ADR 0001 after merge of successor product PR
{successor}. Merged #2 (
0197f8c14c,2026-09-21T13:18:55Z) does not complete ADR 0001. Remaining work is S0
docs + S2 README pointer + this S3 tracker. This issue does not reopen
#2. Opened in code/tradair-landing before successor merge.
Dated GET by repo admin of
code/tradair-landing(distinct fromthe S2 pusher) of this repo's
mainprotection rule equals the sixT2 protection flags (T2-2, T2-8, T2-3, T2-9, T2-10, T2-5) in
docs/architecture.md. Admin GET .../branch_protections (unauthenticated
is 401). The GET is a read, not a #297 grant; in-repo CI cannot do it.
Attest the JSON here. Not copied from code/hello. Not the
public GET .../branches/main slice. A GET recorded before a later
template re-copy does not count. Not proven by CODEOWNERS absence
on main.
After S1 is on
main: dedicated plant-check PR {n} changingonly docs/_codeowners-plant-check.txt (never src/, public/,
package.json, addresses, ABIs, or legal pages); draft: false; title
not WIP; no manual reviewer request. GET immediately after open; if
both plant signals empty, wait 30s and re-GET. Pass iff
requested_reviewers_teams length 0 AND no review with official == true,
state == "REQUEST_REVIEW", team.name == "maintainers" (optional
team.id == 4). Do not require team.organization on reviews. Record {n}
and the two JSON bodies, then close without merge immediately. Merging
{n} fails leftover-complete. Not #2, not #1, not the next natural PR.
T2-1 last: test -f fails on CODEOWNERS, docs/CODEOWNERS,
.gitea/CODEOWNERS, .forgejo/CODEOWNERS. Recorded after items 1 and 2.
Four-path absence alone (already true on
0197f8c) is not leftover-complete.Successor product PR for S0+S2: #5 (head
issue/2, tip documents merged #2 does not complete ADR 0001). S3 leftover-complete remains on this issue after #5 merges.