code/hello
Watch
4
0
Fork
You've already forked hello
 1
Code Issues 7 Pull requests 5 Projects Releases Packages Wiki Activity

lab: HMAC admission DoR — README link (issue 6) #18

Open
PlasticDigits wants to merge 2 commits from issue/6 into main
pull from: issue/6
merge into: code:main
Conversation 3 Commits 2 Files changed 3 +221
PlasticDigits commented 2026-09-22 08:15:24 +00:00
Owner

Summary

Implements the post-review slice for #6 / ADR 0001:

  • Land docs/adr/0001-hmac-admission-dor-lab.md and docs/architecture.md (design commit 9d1c72f).
  • Add one README sentence linking docs/architecture.md.
  • No workflow, scanner, secret, or runtime changes.

Fixes #6

Acceptance criteria

Criterion Status
ADR 0001 + architecture map on branch done
README links docs/architecture.md done
docs/architecture.md links ADR 0001 done (design)
Issue title still lab: … verified open issue
Issue body Given / When / Then verified open issue
No HMAC/SQLite/webhook secret in tree done
Woodpecker workflow unchanged done

Validation

Check Result
grep README → architecture link pass
grep architecture → ADR 0001 pass
gitleaks v8.30.0 (pinned tarball, .gitleaks.toml) pass
opengrep / trivy-fs not run locally (no container runtime); Woodpecker PR context required
Controller / admission replay out of scope (parent control plane); fixture title/body unchanged

Gaps / follow-up

  • PR CI: ci/woodpecker/pr/woodpecker on this tip.
  • ADR 0001 status remains Proposed until a human records design acceptance on main (independent review is not this PR’s authority).
  • Parent invariants / skills: no code/hello repo copies; admission behavior unchanged.

Test plan

  • Woodpecker scanners green on this PR
  • After merge: README link resolves on main
## Summary Implements the post-review slice for [#6](https://git.cl8y.com/code/hello/issues/6) / [ADR 0001](docs/adr/0001-hmac-admission-dor-lab.md): - Land `docs/adr/0001-hmac-admission-dor-lab.md` and `docs/architecture.md` (design commit `9d1c72f`). - Add one README sentence linking [docs/architecture.md](docs/architecture.md). - No workflow, scanner, secret, or runtime changes. Fixes #6 ## Acceptance criteria | Criterion | Status | | --- | --- | | ADR 0001 + architecture map on branch | done | | README links `docs/architecture.md` | done | | `docs/architecture.md` links ADR 0001 | done (design) | | Issue title still `lab:` … | verified open issue | | Issue body Given / When / Then | verified open issue | | No HMAC/SQLite/webhook secret in tree | done | | Woodpecker workflow unchanged | done | ## Validation | Check | Result | | --- | --- | | `grep` README → architecture link | pass | | `grep` architecture → ADR 0001 | pass | | gitleaks v8.30.0 (pinned tarball, `.gitleaks.toml`) | pass | | opengrep / trivy-fs | not run locally (no container runtime); **Woodpecker PR context required** | | Controller / admission replay | out of scope (parent control plane); fixture title/body unchanged | ## Gaps / follow-up - PR CI: `ci/woodpecker/pr/woodpecker` on this tip. - ADR 0001 status remains **Proposed** until a human records design acceptance on `main` (independent review is not this PR’s authority). - Parent invariants / skills: no `code/hello` repo copies; admission behavior unchanged. ## Test plan - [ ] Woodpecker scanners green on this PR - [ ] After merge: README link resolves on `main`
The smoke repo must keep the fixture admit-eligible without growing a verifier, secret, or job runner.

Co-authored-by: Cursor <cursoragent@cursor.com>
docs: link architecture map from README (issue 6)
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
b2e249b428 
Implementation slice after accepted ADR 0001: one README sentence
pointing at docs/architecture.md; no runtime or workflow changes.

Fixes #6
PlasticDigits commented 2026-09-22 08:15:28 +00:00
Author
Owner

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue
PlasticDigits commented 2026-09-22 09:00:52 +00:00
Author
Owner

drain skip: default autoland requires tip ACCEPT (#77)

drain skip: default autoland requires tip ACCEPT (#77)
PlasticDigits commented 2026-09-29 20:14:29 +00:00
Author
Owner

drain skip: default autoland requires tip ACCEPT (#77)

drain skip: default autoland requires tip ACCEPT (#77)
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
Required
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin "issue/6:issue/6"
git switch "issue/6"
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent:implement
agent status

  
agent:implement:done
agent status

  
agent:implement:failed
agent status

  
agent:implement:working
agent status

  
agent:review
agent status

  
agent:review:done
agent status

  
agent:review:working
agent status

  
ready
agent status

No labels
agent:implement
agent:implement:done
agent:implement:failed
agent:implement:working
agent:review
agent:review:done
agent:review:working
ready
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/hello!18
No description provided.