code/cl8y-otc-hub
Watch
4
0
Fork
You've already forked cl8y-otc-hub
 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity

fix: implement ADR 0001 — remove catch-all CODEOWNERS #4

Merged
PlasticDigits merged 3 commits from issue/3 into main 2026-09-21 21:06:35 +00:00
Conversation 2 Commits 3 Files changed 4 +386 -6
PlasticDigits commented 2026-09-21 20:56:06 +00:00
Owner

Summary

Completes #3 / ADR 0001 after pull #3 merged without landing Outcome 1 (main still had root CODEOWNERS). Design from b620bcc is on the branch; this commit applies implement slices 1 and 3.

  • Slice 1: delete root CODEOWNERS (no files at docs/, .gitea/, or .forgejo/ paths).
  • Slice 2: design already on base (docs/adr/0001-remove-catchall-codeowners.md, docs/architecture.md); ADR status → Accepted.
  • Slice 3: Woodpecker no-catchall-codeowners (alpine:3.20, four test ! -f lines); gitleaks + tree unchanged.

Merge plane unchanged: no direct main, required ci/woodpecker/pr/woodpecker, no force_merge.

Fixes #3

Acceptance criteria

Criterion Status
No CODEOWNERS at four Forgejo lookup paths on tip Done
.woodpecker.yml slice 3 step + existing steps Done
architecture.md merge table matches Outcome 1 Done (design + implement note)
No force_merge: true product-doc advice Done (none added)
No frontend / protection PATCH / CAC edits Done

Validation

  • Local: no-catchall-codeowners + tree shell checks passed on tip.
  • gitleaks: not run locally (binary absent); Woodpecker step unchanged.
  • Post-land plant oracle (non-WIP PR after merge): operator glance, not verified here.
  • Forgejo protection attestation vs live GET: not re-verified (401 without token).

Gaps

  • Woodpecker PR + push contexts pending on this PR.
  • Leftover official CODEOWNERS requests on closed #3 / open #2 may persist until merge or expiry (ADR rollout).
## Summary Completes [#3](https://git.cl8y.com/code/cl8y-otc-hub/issues/3) / ADR 0001 after pull `#3` merged without landing Outcome 1 (`main` still had root `CODEOWNERS`). Design from `b620bcc` is on the branch; this commit applies implement slices 1 and 3. - **Slice 1:** delete root `CODEOWNERS` (no files at `docs/`, `.gitea/`, or `.forgejo/` paths). - **Slice 2:** design already on base (`docs/adr/0001-remove-catchall-codeowners.md`, `docs/architecture.md`); ADR status → Accepted. - **Slice 3:** Woodpecker `no-catchall-codeowners` (`alpine:3.20`, four `test ! -f` lines); `gitleaks` + `tree` unchanged. Merge plane unchanged: no direct `main`, required `ci/woodpecker/pr/woodpecker`, no `force_merge`. Fixes #3 ## Acceptance criteria | Criterion | Status | | --- | --- | | No CODEOWNERS at four Forgejo lookup paths on tip | Done | | `.woodpecker.yml` slice 3 step + existing steps | Done | | `architecture.md` merge table matches Outcome 1 | Done (design + implement note) | | No `force_merge: true` product-doc advice | Done (none added) | | No frontend / protection PATCH / CAC edits | Done | ## Validation - Local: `no-catchall-codeowners` + `tree` shell checks passed on tip. - `gitleaks`: not run locally (binary absent); Woodpecker step unchanged. - Post-land plant oracle (non-WIP PR after merge): **operator glance**, not verified here. - Forgejo protection attestation vs live GET: **not re-verified** (401 without token). ## Gaps - Woodpecker PR + push contexts pending on this PR. - Leftover official CODEOWNERS requests on closed `#3` / open `#2` may persist until merge or expiry (ADR rollout).
docs: record proposed merge-plane for removing catch-all CODEOWNERS
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
f430da1c03 
Forgejo still plants official review from the root catch-all; this ADR
and architecture overview define the product-tree delete without changing
protection or the hub frontend.

Co-authored-by: Cursor <cursoragent@cursor.com>
docs: pin four-path CODEOWNERS absence and non-WIP plant oracle
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
b620bcc2a8 
Close the Forgejo lookup walk so Outcome 1 is no file at all four paths, keep architecture YAML in lockstep with slice 3, and reject WIP as a false plant check.

Co-authored-by: Cursor <cursoragent@cursor.com>
fix: implement ADR 0001 — delete CODEOWNERS and CI guard
All checks were successful
ci/woodpecker/push/woodpecker Pipeline was successful
Details
ci/woodpecker/pr/woodpecker Pipeline was successful
Details
5b26455fd8 
Remove root CODEOWNERS (Outcome 1), add Woodpecker no-catchall-codeowners
four-path assertion, and mark ADR accepted after design review.

Fixes #3
PlasticDigits commented 2026-09-21 20:56:06 +00:00
Author
Owner

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue

drain skip: no occupying job for rebase/fix-pr/CI-wait; remaining continue
PlasticDigits commented 2026-09-21 20:56:21 +00:00
Author
Owner

drain skip: default autoland requires tip ACCEPT (#77)

drain skip: default autoland requires tip ACCEPT (#77)
Sign in to join this conversation.
Reviewers
No reviewers
code/maintainers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
code/cl8y-otc-hub!4
No description provided.