Require deploy trace recording in runbooks (SEC-D12, #410) #930
No reviewers
Labels
No labels
agent:fix_bugfix
agent:fix_conflicts
agent:fix_security
agent:gap_analysis
agent:implement
agent:implement
agent:implement
agent:open_issues
agent:ready
agent:research
agent:security_audit
agent:verify
architecture
backend
blocker:hybrid
blocker:launch
blocker:limit-orders
blocker:v2
block:log_only
block:security
bug
ci
contracts
correctness
deploy
dev
devops
docs
documentation
duplicate
e2e
enhancement
epic
feature
frontend
functional-completion
gas
good first issue
governance
help wanted
high-risk
hooks
hybrid
indexer
infra
infrastructure
integrators
invalid
launch-blocker
limit-orders
localnet
localterra
low priority
missing-implementation
needs-design
ops
performance
priority
high
priority
medium
product
qa
QA
question
ready
ready
research
scripts
security
security-hardening
smartcontracts
tech-debt
testing
ux
UX
v2
verification
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
code/cl8y-dex-terraclassic!930
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "issue-410-deploy-trace-sec-d12"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Addresses #410 (SEC-D12): deploy runbooks now require operators to record git SHA, Terra Classic chain version, contract code IDs,
wasm-checksums.txt, and post-deploy verification output at deploy/migration time.What changed:
docs/runbooks/launch-checklist.mdPhase 1 anddocs/runbooks/wasm-admin-migration.mdPre-flightdocs/deployment-guide.mddocs/templates/deploy-trace.md(for launch tracking issue #391)make check-deploy-trace-docs/make verify-issue-410skills/AGENTS_DEPLOY_TRACE.mddocs/supply-chain-security.md,docs/security-model.md, and related skillsAcceptance checklist (#410)
launch-checklist.mdrecords git SHA, chain version, code IDs, wasm-checksums.txtgrep 'Deploy trace' docs/runbooks/launch-checklist.md+make check-deploy-trace-docswasm-admin-migration.mdPre-flight has same recording itemsgrep 'SEC-D12' docs/runbooks/wasm-admin-migration.md+make check-deploy-trace-docstest -f docs/templates/deploy-trace.mdVerification checklist (third parties)
Manual review:
docs/runbooks/launch-checklist.md→ Phase 1 → Deploy trace (audit record)docs/runbooks/wasm-admin-migration.md→ Pre-flight → Deploy trace (SEC-D12)docs/templates/deploy-trace.md— confirm all required fields (git SHA, chain version, code IDs, wasm-checksums, verification output)Follow-ups
Security review — MR !930
Commit reviewed:
362c040d88633b84904c118b78c4c8947efcbaeeScope: Documentation-only change (SEC-D12 / #410): deploy trace runbook gates,
docs/templates/deploy-trace.md, agent playbook, doc drift guards (scripts/check_deploy_trace_docs.py,scripts/qa/verify-issue-410.sh), Makefile targets. No CosmWasm, indexer, or frontend runtime code modified.Method: Full MR diff review; traced candidate issues (injection, secret leakage, authz, SSRF/XSS, supply-chain) to sinks; ran
make check-deploy-trace-docsandmake verify-issue-410(PASS).Outcome:
FINDINGS: 0medium+Summary: No exploitable vulnerabilities introduced by this diff.
check_deploy_trace_docs.pyandverify-issue-410.shoperate on fixed repo paths with string/grep checks only — no attacker-controlled input, shell interpolation, or network I/O.wasm-checksums.txt, factoryget_config+smoke-pool-swap.shoutput) are public audit metadata or on-chain query results; no instruction to paste private keys, mnemonics, orDATABASE_URL.Inline threads: None (no medium+ findings).
Security review: no medium+ findings on this diff.
added 9 commits
main70ebb188- Merge branch 'main' into issue-410-deploy-trace-sec-d12Compare with previous version
Resolved merge conflicts with
main.Conflict:
Makefile.PHONYline — both branches added new targets.Resolution: Kept deploy-trace targets from this MR (
check-deploy-trace-docs,verify-issue-410) and wrap-mapper smoke targets frommain(smoke-wrap-mapper-pause,verify-issue-396).Checks:
make check-deploy-trace-docsandmake verify-issue-410pass on the merged branch.Security review — MR !930
Commit reviewed:
70ebb1883694c1ff49b9b9e341215dcbbfbe2584Scope: Documentation-only change (SEC-D12 / #410): deploy trace runbook gates,
docs/templates/deploy-trace.md, agent playbook, doc drift guards (scripts/check_deploy_trace_docs.py,scripts/qa/verify-issue-410.sh), Makefile targets. No CosmWasm, indexer, or frontend runtime code modified. Re-reviewed after merge withmain(conflict resolution in.PHONYonly).Method: Full MR diff review against
049471ed2a0714c4aff5b812b4670bcc0499fc75; traced candidate issues (injection, secret leakage, authz, SSRF/XSS, supply-chain) to sinks; ranmake check-deploy-trace-docsandmake verify-issue-410(PASS).Outcome:
FINDINGS: 0medium+Summary: No exploitable vulnerabilities introduced by this diff.
check_deploy_trace_docs.pyandverify-issue-410.shoperate on fixed repo paths with string/grep checks only — no attacker-controlled input, shell interpolation, or network I/O.wasm-checksums.txt, factoryget_config+smoke-pool-swap.shoutput) are public audit metadata or on-chain query results; no instruction to paste private keys, mnemonics, orDATABASE_URL.Prior review: Commit
362c040dhad the same outcome; merge commit70ebb188adds no new security-relevant code paths.Inline threads: None (no medium+ findings).
Security review: no medium+ findings on this diff.
added 11 commits
main6abc30a3- Merge branch 'main' into issue-410-deploy-trace-sec-d12Compare with previous version
Resolved merge conflicts with latest
main.Conflicts:
Makefile—.PHONYandlinttargets (both branches added doc-check targets)docs/security-model.md— operator checklist cross-linksResolution: Kept deploy-trace targets from this MR (
check-deploy-trace-docs,verify-issue-410) and governance emergency rehearsal targets frommain(check-governance-emergency-rehearsal-docs,rehearse-governance-emergency,verify-issue-397). Combined both deploy-trace and emergency-rehearsal links insecurity-model.md.Checks:
make check-deploy-trace-docs,make verify-issue-410, andmake check-governance-emergency-rehearsal-docspass.Security review — MR !930
Commit reviewed:
6abc30a309e9ed8c4d3db8b193b285af7f458585Scope: Documentation-only change (SEC-D12 / #410): deploy trace runbook gates,
docs/templates/deploy-trace.md, agent playbook, doc drift guards (scripts/check_deploy_trace_docs.py,scripts/qa/verify-issue-410.sh), Makefile targets. No CosmWasm, indexer, or frontend runtime code modified. Re-reviewed after merge withmain(current head is merge commit6abc30a3).Method: Full MR diff review against
e9d32c9beb98f4f360388708165014e18b0bd929; traced candidate issues (injection, secret leakage, authz, SSRF/XSS, supply-chain) to sinks; ranmake check-deploy-trace-docsandmake verify-issue-410(PASS).Outcome:
FINDINGS: 0medium+Summary: No exploitable vulnerabilities introduced by this diff.
check_deploy_trace_docs.pyandverify-issue-410.shoperate on fixed repo paths with string/grep checks only — no attacker-controlled input, shell interpolation, or network I/O.wasm-checksums.txt, factoryget_config+smoke-pool-swap.shoutput) are public audit metadata or on-chain query results; no instruction to paste private keys, mnemonics, orDATABASE_URL.Prior review: Commits
362c040dand70ebb188had the same outcome; merge commit6abc30a3adds no new security-relevant code paths beyond conflict resolution in Makefile cross-links.Inline threads: None (no medium+ findings).
Security review: no medium+ findings on this diff.
added 6 commits
mainb177633c- Merge branch 'main' into issue-410-deploy-trace-sec-d12Compare with previous version
Resolved merge conflicts with
maininMakefile:.PHONY: kept bothcheck-emergency-commands-docs(from #399 on main) andcheck-deploy-trace-docs/verify-issue-410(from this MR).linttarget: runs both doc-drift checks.Sanity:
make check-deploy-trace-docsandmake check-emergency-commands-docsboth pass.Security review — MR !930
Commit reviewed:
b177633c326a4a4aa5a87b6c5b85a624985a42acScope: Documentation-only change (SEC-D12 / #410): deploy trace runbook gates,
docs/templates/deploy-trace.md, agent playbook, doc drift guards (scripts/check_deploy_trace_docs.py,scripts/qa/verify-issue-410.sh), Makefile targets. No CosmWasm, indexer, or frontend runtime code modified. Re-reviewed after latest merge withmain(headb177633c).Method: Full MR diff review against
6f4fd29bf704c18cfc9f7c848690c4400cc9d562; traced candidate issues (injection, secret leakage, authz, SSRF/XSS, supply-chain) to sinks; ranmake check-deploy-trace-docsandmake verify-issue-410(PASS).Outcome:
FINDINGS: 0medium+Summary: No exploitable vulnerabilities introduced by this diff.
check_deploy_trace_docs.pyandverify-issue-410.shoperate on fixed repo paths with string/grep checks only — no attacker-controlled input, shell interpolation, or network I/O.wasm-checksums.txt, factoryget_config+smoke-pool-swap.shoutput) are public audit metadata or on-chain query results; no instruction to paste private keys, mnemonics, orDATABASE_URL.Prior review: Commits
362c040d,70ebb188, and6abc30a3had the same outcome; merge commitb177633cadds no new security-relevant code paths beyond conflict resolution in Makefile cross-links.Inline threads: None (no medium+ findings).
Security review: no medium+ findings on this diff.
mentioned in commit
0e2eaa8dcf