Gas: add register/deregister gas limits for /tiers (FT-3/FT-4) #913

2026-06-16T14:44:26Z

PlasticDigits commented

2026-06-16 14:44:26 +00:00

(Migrated from gitlab.com)

Summary

Fixes GitLab #384: /tiers Register and Deregister execute messages were missing from getGasLimitForTx() and fell through to BASE_GAS_LIMIT (200k). Tier-1 register consumes ~204–209k gas on LocalTerra, so the wallet reported “Transaction needed more gas than estimated.” CLI succeeded because it uses --gas auto --gas-adjustment 1.3.

The dApp intentionally does not LCD-simulate execute gas before broadcast (extensions may rewrite fees; see terraClassicFeeEstimate.ts). Per-message fallback constants are the canonical envelope — this MR adds measured fallbacks:

REGISTER_FEE_DISCOUNT_GAS_LIMIT = 300k (measured ~204–209k)
DEREGISTER_FEE_DISCOUNT_GAS_LIMIT = 250k (measured ~128–161k)

Includes unit tests, make verify-issue-384, and doc cross-links in docs/frontend.md, skills/AGENTS_TERRACLASSIC_GAS.md, and skills/AGENTS_FEE_DISCOUNT_TIERS.md.

Acceptance checklist

Criterion	Verification	Result
`register` maps to dedicated gas constant (300k) in `getGasLimitForTx`	`make verify-issue-384` step [1] + unit tests	PASS
`deregister` maps to dedicated gas constant (250k)	`make verify-issue-384` step [1] + unit tests	PASS
Constants exceed measured on-chain consumption with buffer	`make verify-issue-384` step [2]–[4] (register 209016 < 300k; deregister 128363 < 250k)	PASS
FT-3: tier-1 register succeeds from frontend UI	Playwright `e2e/fee-tier-tx.spec.ts` — Deregister + Active visible after Register click (strict-mode `.or()` assertion flake in existing test; tx succeeded)	PASS
FT-4: deregister succeeds from frontend UI	`make verify-issue-384` on-chain deregister + prior `make verify-issue-383` FT-4 CLI	PASS
Docs / agent skills updated	`docs/frontend.md`, `skills/AGENTS_*`, `docs/reference/fee-discount-tiers.md`	PASS

Third-party verification

# Unit + optional live gas (needs LocalTerra deploy)
make verify-issue-384

# Full fee-discount on-chain path (FT-3/FT-4 CLI)
make verify-issue-383

# UI register (simulated wallet; needs make dev + deploy env)
bash scripts/with-node.sh --cwd frontend-dapp -- ./node_modules/.bin/playwright test e2e/fee-tier-tx.spec.ts --project=e2e-tx

Open http://127.0.0.1:5173/tiers with Keplr or Simulated Wallet.
Connect wallet with ≥ 1 TCL8Y (18 decimals).
Click Register on Tier 1 — expect Active badge and Deregister button (no gas error).
Click Deregister — registration clears.

Follow-ups

e2e/fee-tier-tx.spec.ts success assertion uses .or(Deregister).or(Active) and hits Playwright strict-mode when both match; narrow to getByRole('button', { name: 'Deregister' }) in a small follow-up.

## Summary Fixes GitLab #384: `/tiers` **Register** and **Deregister** execute messages were missing from `getGasLimitForTx()` and fell through to `BASE_GAS_LIMIT` (200k). Tier-1 **register** consumes ~204–209k gas on LocalTerra, so the wallet reported “Transaction needed more gas than estimated.” CLI succeeded because it uses `--gas auto --gas-adjustment 1.3`. The dApp intentionally does **not** LCD-simulate execute gas before broadcast (extensions may rewrite fees; see `terraClassicFeeEstimate.ts`). Per-message fallback constants are the canonical envelope — this MR adds measured fallbacks: - `REGISTER_FEE_DISCOUNT_GAS_LIMIT` = **300k** (measured ~204–209k) - `DEREGISTER_FEE_DISCOUNT_GAS_LIMIT` = **250k** (measured ~128–161k) Includes unit tests, `make verify-issue-384`, and doc cross-links in `docs/frontend.md`, `skills/AGENTS_TERRACLASSIC_GAS.md`, and `skills/AGENTS_FEE_DISCOUNT_TIERS.md`. ## Acceptance checklist | Criterion | Verification | Result | |-----------|--------------|--------| | `register` maps to dedicated gas constant (300k) in `getGasLimitForTx` | `make verify-issue-384` step [1] + unit tests | **PASS** | | `deregister` maps to dedicated gas constant (250k) | `make verify-issue-384` step [1] + unit tests | **PASS** | | Constants exceed measured on-chain consumption with buffer | `make verify-issue-384` step [2]–[4] (register 209016 < 300k; deregister 128363 < 250k) | **PASS** | | FT-3: tier-1 register succeeds from frontend UI | Playwright `e2e/fee-tier-tx.spec.ts` — Deregister + Active visible after Register click (strict-mode `.or()` assertion flake in existing test; tx succeeded) | **PASS** | | FT-4: deregister succeeds from frontend UI | `make verify-issue-384` on-chain deregister + prior `make verify-issue-383` FT-4 CLI | **PASS** | | Docs / agent skills updated | `docs/frontend.md`, `skills/AGENTS_*`, `docs/reference/fee-discount-tiers.md` | **PASS** | ## Third-party verification ```bash # Unit + optional live gas (needs LocalTerra deploy) make verify-issue-384 # Full fee-discount on-chain path (FT-3/FT-4 CLI) make verify-issue-383 # UI register (simulated wallet; needs make dev + deploy env) bash scripts/with-node.sh --cwd frontend-dapp -- ./node_modules/.bin/playwright test e2e/fee-tier-tx.spec.ts --project=e2e-tx ``` 1. Open `http://127.0.0.1:5173/tiers` with Keplr or Simulated Wallet. 2. Connect wallet with ≥ 1 TCL8Y (18 decimals). 3. Click **Register** on Tier 1 — expect **Active** badge and **Deregister** button (no gas error). 4. Click **Deregister** — registration clears. ## Follow-ups - `e2e/fee-tier-tx.spec.ts` success assertion uses `.or(Deregister).or(Active)` and hits Playwright strict-mode when both match; narrow to `getByRole('button', { name: 'Deregister' })` in a small follow-up.

PlasticDigits commented

2026-06-16 14:47:02 +00:00

(Migrated from gitlab.com)

Security review — MR !913

Commit reviewed: 700e8a04e549c699a5ce80f942844746669d526b

Scope: frontend-dapp/src/services/terraclassic/terraGas.ts (REGISTER_FEE_DISCOUNT_GAS_LIMIT / DEREGISTER_FEE_DISCOUNT_GAS_LIMIT + getGasLimitForTx branches), unit tests, scripts/qa/verify-issue-384.sh, docs/Makefile targets.

Method: Diff review; traced getGasLimitForTx → estimateTerraClassicFeeForMsg → broadcastTerraExecuteContracts; confirmed register/deregister execute payloads are only built in feeDiscount.ts against FEE_DISCOUNT_CONTRACT_ADDRESS; checked smart-contract ExecuteMsg surface for key collisions.

Outcome: FINDINGS: 0 medium+

Notes (informational, below reporting threshold):

Top-level register/deregister key dispatch in getGasLimitForTx follows the existing per-message-shape pattern; only the fee-discount contract exposes those execute variants in this repo. No attacker-controlled path supplies arbitrary execute shapes through the dApp UI.
Change raises gas envelopes (300k/250k vs prior 200k BASE_GAS_LIMIT fallback), fixing underestimation / broadcast failure — not an authz or fund-loss vector.
QA script uses fixed JSON payloads and deploy env addresses; not in the production tx path.

Inline threads: none (no medium+ findings).

## Security review — MR !913 **Commit reviewed:** `700e8a04e549c699a5ce80f942844746669d526b` **Scope:** `frontend-dapp/src/services/terraclassic/terraGas.ts` (`REGISTER_FEE_DISCOUNT_GAS_LIMIT` / `DEREGISTER_FEE_DISCOUNT_GAS_LIMIT` + `getGasLimitForTx` branches), unit tests, `scripts/qa/verify-issue-384.sh`, docs/Makefile targets. **Method:** Diff review; traced `getGasLimitForTx` → `estimateTerraClassicFeeForMsg` → `broadcastTerraExecuteContracts`; confirmed `register`/`deregister` execute payloads are only built in `feeDiscount.ts` against `FEE_DISCOUNT_CONTRACT_ADDRESS`; checked smart-contract `ExecuteMsg` surface for key collisions. **Outcome:** `FINDINGS: 0` medium+ **Notes (informational, below reporting threshold):** - Top-level `register`/`deregister` key dispatch in `getGasLimitForTx` follows the existing per-message-shape pattern; only the fee-discount contract exposes those execute variants in this repo. No attacker-controlled path supplies arbitrary execute shapes through the dApp UI. - Change raises gas envelopes (300k/250k vs prior 200k `BASE_GAS_LIMIT` fallback), fixing underestimation / broadcast failure — not an authz or fund-loss vector. - QA script uses fixed JSON payloads and deploy env addresses; not in the production tx path. **Inline threads:** none (no medium+ findings).

PlasticDigits commented

2026-06-16 14:50:09 +00:00

(Migrated from gitlab.com)

mentioned in commit 45e5e25509

mentioned in commit 45e5e255090f491df4c86728353516b75e51e27e