fix: make verify-issue-365 portable (#375) #898

2026-06-13T03:56:17Z

PlasticDigits commented

2026-06-13 03:56:17 +00:00

(Migrated from gitlab.com)

Summary

Completes GitLab #375 follow-up for #365 registry outage observability. Docs, cross-links (P5, I10), and scripts/qa/verify-issue-365.sh landed on main in prior work; this MR fixes the remaining portability nit: make verify-issue-365 no longer runs chmod on scripts/setup-cloud-agent-indexer-postgres.sh (which can fail when the file is not owned by the invoking user). Bootstrap still calls make setup-indexer-postgres from inside the verify script when indexer/.env or Postgres is missing.

Acceptance checklist

Criterion	Verification	Result
`docs/integrators.md` registry-outage guidance (unregistered vs LCD outage, health endpoint, on-chain semantics)	Read `docs/integrators.md` § Fee-discount registry outage	PASS (on `main`)
`make verify-issue-365` exists and passes	`make verify-issue-365`	PASS (3/3 after chmod fix)
`docs/testing.md` or `skills/AGENTS_FEE_DISCOUNT_TIERS.md` references `make verify-issue-365`	`rg verify-issue-365 docs/testing.md skills/AGENTS_FEE_DISCOUNT_TIERS.md`	PASS (on `main`)
P5 / I10 accurate and cross-linked to integrators section	`rg 'registry outage' docs/contracts-security-audit.md docs/reference/fee-discount-tiers.md`	PASS (on `main`)
Verification script PASS/FAIL summary, non-zero on failure	`make verify-issue-365`; script exits 1 when a step fails	PASS

Third-party verification

git fetch origin fix/375-verify-issue-365-chmod
git checkout fix/375-verify-issue-365-chmod
make verify-issue-365
# Expect: RESULTS: 3 passed, 0 failed

Manual doc check:

sed -n '/^## Fee-discount registry outage/,/^## /p' docs/integrators.md | head -n -1

Confirm decision table distinguishes registered: false vs LCD errors / fee_discount_registry_ok: false.

Parent: #365
Docs + ladder script merged on main; this MR is the approved make wrapper fix only.

Note

Low Risk
Single Makefile line change to QA tooling only; no runtime, auth, or contract behavior affected.

Overview
make verify-issue-365 no longer runs chmod on scripts/setup-cloud-agent-indexer-postgres.sh before the QA ladder. That file is dropped from the target’s prerequisite chmod list so the Make recipe only marks scripts/qa/verify-issue-365.sh and scripts/with-node.sh executable.

Postgres/indexer bootstrap is unchanged: when indexer/.env or Postgres is missing, scripts/qa/verify-issue-365.sh still invokes make setup-indexer-postgres, which continues to chmod and run the cloud-agent Postgres setup script on that path.

^{Reviewed by Cursor Bugbot for commit 2b5d263965. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary Completes GitLab #375 follow-up for #365 registry outage observability. Docs, cross-links (P5, I10), and `scripts/qa/verify-issue-365.sh` landed on `main` in prior work; this MR fixes the remaining portability nit: `make verify-issue-365` no longer runs `chmod` on `scripts/setup-cloud-agent-indexer-postgres.sh` (which can fail when the file is not owned by the invoking user). Bootstrap still calls `make setup-indexer-postgres` from inside the verify script when `indexer/.env` or Postgres is missing. ## Acceptance checklist | Criterion | Verification | Result | |-----------|--------------|--------| | `docs/integrators.md` registry-outage guidance (unregistered vs LCD outage, health endpoint, on-chain semantics) | Read `docs/integrators.md` § Fee-discount registry outage | PASS (on `main`) | | `make verify-issue-365` exists and passes | `make verify-issue-365` | PASS (3/3 after chmod fix) | | `docs/testing.md` or `skills/AGENTS_FEE_DISCOUNT_TIERS.md` references `make verify-issue-365` | `rg verify-issue-365 docs/testing.md skills/AGENTS_FEE_DISCOUNT_TIERS.md` | PASS (on `main`) | | P5 / I10 accurate and cross-linked to integrators section | `rg 'registry outage' docs/contracts-security-audit.md docs/reference/fee-discount-tiers.md` | PASS (on `main`) | | Verification script PASS/FAIL summary, non-zero on failure | `make verify-issue-365`; script exits 1 when a step fails | PASS | ## Third-party verification ```bash git fetch origin fix/375-verify-issue-365-chmod git checkout fix/375-verify-issue-365-chmod make verify-issue-365 # Expect: RESULTS: 3 passed, 0 failed ``` Manual doc check: ```bash sed -n '/^## Fee-discount registry outage/,/^## /p' docs/integrators.md | head -n -1 ``` Confirm decision table distinguishes `registered: false` vs LCD errors / `fee_discount_registry_ok: false`. ## Related - Parent: #365 - Docs + ladder script merged on `main`; this MR is the approved `make` wrapper fix only.  --- > [!NOTE] > **Low Risk** > Single Makefile line change to QA tooling only; no runtime, auth, or contract behavior affected. > > **Overview** > **`make verify-issue-365`** no longer runs `chmod` on `scripts/setup-cloud-agent-indexer-postgres.sh` before the QA ladder. That file is dropped from the target’s prerequisite `chmod` list so the Make recipe only marks `scripts/qa/verify-issue-365.sh` and `scripts/with-node.sh` executable. > > Postgres/indexer bootstrap is unchanged: when `indexer/.env` or Postgres is missing, `scripts/qa/verify-issue-365.sh` still invokes **`make setup-indexer-postgres`**, which continues to `chmod` and run the cloud-agent Postgres setup script on that path. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 2b5d263965b23a1e50374ba9b51231bfcfbea9c2. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

ghost1 commented

2026-06-13 03:56:24 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2026-06-13 03:56:29 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-13 03:57:39 +00:00

(Migrated from gitlab.com)

Security review — MR !898

Commit reviewed: 2b5d263965b23a1e50374ba9b51231bfcfbea9c2
Scope: Makefile — verify-issue-365 target removes scripts/setup-cloud-agent-indexer-postgres.sh from the prerequisite chmod list (portability fix for #375).

Method

Inspected full MR diff (single-line change).
Traced bootstrap path: scripts/qa/verify-issue-365.sh still invokes make setup-indexer-postgres when indexer/.env or Postgres is missing; that target continues to chmod +x scripts/setup-cloud-agent-indexer-postgres.sh before execution.
When bootstrap is skipped (env + Postgres already present), the setup script is never invoked — removing it from the outer chmod list does not alter runtime behavior.
Checked for injection, authz, secret leakage, SSRF/XSS, path traversal, and supply-chain deltas on the changed surface — none applicable (dev/CI Makefile only; no production runtime, contract, or indexer API changes).

Outcome

FINDINGS: 0 medium+

No inline threads — nothing to annotate on the diff.

Security review: no medium+ findings on this diff.

## Security review — MR !898 **Commit reviewed:** `2b5d263965b23a1e50374ba9b51231bfcfbea9c2` **Scope:** `Makefile` — `verify-issue-365` target removes `scripts/setup-cloud-agent-indexer-postgres.sh` from the prerequisite `chmod` list (portability fix for #375). ### Method - Inspected full MR diff (single-line change). - Traced bootstrap path: `scripts/qa/verify-issue-365.sh` still invokes `make setup-indexer-postgres` when `indexer/.env` or Postgres is missing; that target continues to `chmod +x scripts/setup-cloud-agent-indexer-postgres.sh` before execution. - When bootstrap is skipped (env + Postgres already present), the setup script is never invoked — removing it from the outer `chmod` list does not alter runtime behavior. - Checked for injection, authz, secret leakage, SSRF/XSS, path traversal, and supply-chain deltas on the changed surface — none applicable (dev/CI Makefile only; no production runtime, contract, or indexer API changes). ### Outcome **FINDINGS: 0** medium+ No inline threads — nothing to annotate on the diff. Security review: no medium+ findings on this diff.

PlasticDigits commented

2026-06-13 04:23:00 +00:00

(Migrated from gitlab.com)

mentioned in commit b23c1c51cf

mentioned in commit b23c1c51cf4bdf5efa7551fff5e45388c2f9581e