fix(frontend): type limit-book prefetch getNextPageParam so tsc -b passes #863

Merged
Brouie merged 1 commit from qa/build-tsc-prefetch-implicit-any into main 2026-06-11 05:43:10 +00:00
Brouie commented 2026-06-11 02:14:09 +00:00 (Migrated from gitlab.com)

npm run build (tsc -b) is red on main: TS7006 implicit any on the getNextPageParam param in tradePairPrefetch.ts:43, introduced with the #354 prefetchInfiniteQuery fix (35e38e5). CI doesn't run tsc -b, so it slipped through.

One-line fix: annotate the param as IndexerLimitBookPageResponse (same import idiom as limitBookPagination.ts — the type isn't re-exported from the indexer client).

Verified at this branch:

  • npm run build green (tsc -b + vite build), dist has 0 sourcemaps
  • tradePairPrefetch.test.ts 3/3 + tradePairPrefetch.infiniteSeed.test.tsx 1/1

Found during the #337 sweep — details in the note there. Companion MR fixes the two red SwapPage tests from the same sweep.

npm run build (tsc -b) is red on main: TS7006 implicit any on the getNextPageParam param in tradePairPrefetch.ts:43, introduced with the #354 prefetchInfiniteQuery fix (35e38e5). CI doesn't run tsc -b, so it slipped through. One-line fix: annotate the param as IndexerLimitBookPageResponse (same import idiom as limitBookPagination.ts — the type isn't re-exported from the indexer client). Verified at this branch: - npm run build green (tsc -b + vite build), dist has 0 sourcemaps - tradePairPrefetch.test.ts 3/3 + tradePairPrefetch.infiniteSeed.test.tsx 1/1 Found during the #337 sweep — details in the note there. Companion MR fixes the two red SwapPage tests from the same sweep.
Brouie commented 2026-06-11 04:58:09 +00:00 (Migrated from gitlab.com)

mentioned in issue #337

mentioned in issue #337
PlasticDigits (Migrated from gitlab.com) merged commit b03c8992b9 into main 2026-06-11 05:43:11 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
code/cl8y-dex-terraclassic!863
No description provided.