docs(frontend): #357 deep-link QA pair source clarification #862

Merged

PlasticDigits merged 1 commit from local1/357-impl-deep-link into main

2026-06-10 11:19:10 +00:00

PlasticDigits commented

2026-06-10 11:09:40 +00:00

(Migrated from gitlab.com)

Summary

Core #357 fix is on main (1aeaf2c): shouldAutoPickDefaultTradePair prevents default-pick from racing known :pairAddr deep links on mount.

This MR adds agent/QA guidance: manual repro must use current factory LCD pairs (getAllPairsPaginated), not stale indexer-only addresses — otherwise unknown-pair handling applies (correct) and can be mistaken for the snap-back bug.

Verified in browser: /trade/<factory pairs[1]> stays on EMBER/JADE after pairs resolve.

Test plan

npx vitest run src/pages/TradePage.test.tsx -t 357 src/utils/__tests__/tradePairRoute.test.ts
Fresh tab: /trade/<non-default factory pair from LCD> — URL stable after load
Bare /trade still auto-navigates to first factory pair

Note

Low Risk
Playbook text only; no runtime or test changes.

Overview
Documentation-only update to the agent playbook for trade pair deep links (GitLab #357).

The Known pair deep link manual repro step now states that QA must use a pair from current factory LCD (getAllPairsPaginated), not indexer-only addresses. Stale indexer rows missing from the factory list should trigger unknown pair handling—not be read as the #357 URL snap-back bug.

No application code changes in this MR; the runtime fix (shouldAutoPickDefaultTradePair) is already on main.

^{Reviewed by Cursor Bugbot for commit f63957a171. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary Core #357 fix is on `main` (`1aeaf2c`): `shouldAutoPickDefaultTradePair` prevents default-pick from racing known `:pairAddr` deep links on mount. This MR adds agent/QA guidance: manual repro must use **current factory LCD pairs** (`getAllPairsPaginated`), not stale indexer-only addresses — otherwise unknown-pair handling applies (correct) and can be mistaken for the snap-back bug. Verified in browser: `/trade/<factory pairs[1]>` stays on EMBER/JADE after pairs resolve. ## Test plan - [ ] `npx vitest run src/pages/TradePage.test.tsx -t 357 src/utils/__tests__/tradePairRoute.test.ts` - [ ] Fresh tab: `/trade/<non-default factory pair from LCD>` — URL stable after load - [ ] Bare `/trade` still auto-navigates to first factory pair  --- > [!NOTE] > **Low Risk** > Playbook text only; no runtime or test changes. > > **Overview** > **Documentation-only** update to the agent playbook for trade pair deep links ([GitLab #357](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/357)). > > The **Known pair deep link** manual repro step now states that QA must use a pair from **current factory LCD** (`getAllPairsPaginated`), not indexer-only addresses. Stale indexer rows missing from the factory list should trigger [unknown pair](#trade-page-unknown-pair-link) handling—not be read as the #357 URL snap-back bug. > > No application code changes in this MR; the runtime fix (`shouldAutoPickDefaultTradePair`) is already on `main`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit f63957a17102b847efc70597ff29457cf095194e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

Rows
Columns