code/cl8y-dex-terraclassic

Fork 0

fix(frontend): sticky limit submit on trade ticket (#348) #859

Merged

PlasticDigits merged 2 commits from local1/348-impl-ticket-fold into main

2026-06-10 05:33:39 +00:00

PlasticDigits commented

2026-06-10 03:45:41 +00:00

(Migrated from gitlab.com)

Fixes #348

Note

Low Risk
Layout-only trade ticket UX with an E2E guard; no auth, chain, or order logic changes.

Overview
Fixes #348 so the Place limit submit control stays in view on desktop trade layouts without scrolling the whole ticket.

TradeOrderTicket stops scrolling the entire card: the main body scrolls (flex-1 + overflow-y-auto) while the limit submit (and related tx alerts) sit in a sticky bottom bar (trade-limit-submit-sticky). Long helper copy in the ticket header and limit section is hidden lg:block to save vertical space on smaller breakpoints. Post-place “View order” / “Place another” actions move below the sticky bar instead of inside it.

A Playwright case at 1280×720 asserts trade-limit-submit is visible and its bottom edge fits within trade-desktop-workspace.

^{Reviewed by Cursor Bugbot for commit 07236b0f95. Bugbot is set up for automated code reviews on this repo. Configure here.}

Fixes #348  --- > [!NOTE] > **Low Risk** > Layout-only trade ticket UX with an E2E guard; no auth, chain, or order logic changes. > > **Overview** > Fixes **#348** so the **Place limit** submit control stays in view on desktop trade layouts without scrolling the whole ticket. > > **`TradeOrderTicket`** stops scrolling the entire card: the main body scrolls (`flex-1` + `overflow-y-auto`) while the limit **submit** (and related tx alerts) sit in a **sticky bottom** bar (`trade-limit-submit-sticky`). Long helper copy in the ticket header and limit section is **`hidden lg:block`** to save vertical space on smaller breakpoints. Post-place “View order” / “Place another” actions move **below** the sticky bar instead of inside it. > > A **Playwright** case at **1280×720** asserts `trade-limit-submit` is visible and its bottom edge fits within `trade-desktop-workspace`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 07236b0f9513a71c83a60163ea24f1a1a5af1c63. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

PlasticDigits commented

2026-06-10 03:45:43 +00:00

(Migrated from gitlab.com)

mentioned in issue #348

ghost1 commented

2026-06-10 03:45:48 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2026-06-10 03:45:56 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2026-06-10 03:47:13 +00:00

(Migrated from gitlab.com)

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issue.}

^{Reviewed by Cursor Bugbot for commit 889ca34fd2. Configure here.}

Cursor Bugbot has reviewed your changes and found 1 potential issue.  <a href="https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9BTExfSU5fQ1VSU09SIiwiZGF0YSI6eyJyZWRpc0tleSI6ImJ1Z2JvdC1tdWx0aToxMjgyMjNlNC1mOGQwLTQxYjctYWM3Yy05NmNmYmYxMDU2ZTciLCJlbmNyeXB0aW9uS2V5IjoiZ2JIX0JNNlFwV0NFTHpmQnhtMWxCeDB0eVpXcUlqZGx1NG9pcE1JQkpWcyIsImJyYW5jaCI6ImxvY2FsMS8zNDgtaW1wbC10aWNrZXQtZm9sZCIsInJlcG9Pd25lciI6IlBsYXN0aWNEaWdpdHMiLCJyZXBvTmFtZSI6ImNsOHktZGV4LXRlcnJhY2xhc3NpYyJ9fQ" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-cursor-light.png"><img alt="Fix All in Cursor" width="115" height="28" src="https://cursor.com/assets/images/fix-in-cursor-dark.png"></picture></a>   <sup>Bugbot Autofix is [ON](https://www.cursor.com/dashboard/bugbot). A cloud agent has been kicked off to fix the reported issue. </sup>  <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 889ca34fd29b188f93bfa36ece8b4c010adee98c. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

ghost1 commented

2026-06-10 03:47:14 +00:00

(Migrated from gitlab.com)

E2E assert ignores page chrome

Medium Severity

The new Playwright check compares the limit submit button’s bottom edge to the full viewport height (720), but on /trade the desktop workspace sits below the page title, copy, and pair selector. The submit control is pinned to the bottom of the ticket column inside that workspace, so its screen position is typically below 720 even when the sticky ticket fix works and no ticket scrolling is needed.

^{Reviewed by Cursor Bugbot for commit 889ca34fd2. Configure here.}

### E2E assert ignores page chrome **Medium Severity**  The new Playwright check compares the limit submit button’s bottom edge to the full viewport height (`720`), but on `/trade` the desktop workspace sits below the page title, copy, and pair selector. The submit control is pinned to the bottom of the ticket column inside that workspace, so its screen position is typically below `720` even when the sticky ticket fix works and no ticket scrolling is needed.    <div><a href="https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OjM4ODZiZDg5LTgxNDktNDYzZi1hNzRiLTc4MTUyYzk1MWUzMyIsImVuY3J5cHRpb25LZXkiOiJuZlpiYVZqUG5lMXJuMjRFMHAwQ3A0VVE0TUp4VEpyNVNPb1NtU0JZMUVJIiwiYnJhbmNoIjoibG9jYWwxLzM0OC1pbXBsLXRpY2tldC1mb2xkIiwicmVwb093bmVyIjoiUGxhc3RpY0RpZ2l0cyIsInJlcG9OYW1lIjoiY2w4eS1kZXgtdGVycmFjbGFzc2ljIn19" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-cursor-light.png"><img alt="Fix in Cursor" width="115" height="28" src="https://cursor.com/assets/images/fix-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9XRUIiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OjM4ODZiZDg5LTgxNDktNDYzZi1hNzRiLTc4MTUyYzk1MWUzMyIsImVuY3J5cHRpb25LZXkiOiJuZlpiYVZqUG5lMXJuMjRFMHAwQ3A0VVE0TUp4VEpyNVNPb1NtU0JZMUVJIiwiYnJhbmNoIjoibG9jYWwxLzM0OC1pbXBsLXRpY2tldC1mb2xkIiwicmVwb093bmVyIjoiUGxhc3RpY0RpZ2l0cyIsInJlcG9OYW1lIjoiY2w4eS1kZXgtdGVycmFjbGFzc2ljIiwicHJOdW1iZXIiOjE0MSwiY29tbWl0U2hhIjoiODg5Y2EzNGZkMjliMTg4ZjkzYmZhMzZlY2U4YjRjMDEwYWRlZTk4YyIsInByb3ZpZGVyIjoiZ2l0bGFiIiwiaG9zdG5hbWUiOiJnaXRsYWIuY29tIn19" target="_blank" rel="noopener noreferrer"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/fix-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/fix-in-web-light.png"><img alt="Fix in Web" width="99" height="28" src="https://cursor.com/assets/images/fix-in-web-dark.png"></picture></a></div> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 889ca34fd29b188f93bfa36ece8b4c010adee98c. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

ghost1 commented

2026-06-10 03:49:29 +00:00

(Migrated from gitlab.com)

changed this line in version 2 of the diff

changed this line in [version 2 of the diff](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/141/diffs?diff_id=1843484307&start_sha=889ca34fd29b188f93bfa36ece8b4c010adee98c#276e9c5c98d9ac39cad8cbb14c34a487599c4820_52_54)

ghost1 commented

2026-06-10 03:49:29 +00:00

(Migrated from gitlab.com)

added 1 commit

07236b0f - fix(e2e): compare limit submit to workspace, not viewport (#348)

Compare with previous version

added 1 commit <ul><li>07236b0f - fix(e2e): compare limit submit to workspace, not viewport (#348)</li></ul> [Compare with previous version](/PlasticDigits/cl8y-dex-terraclassic/-/merge_requests/141/diffs?diff_id=1843484307&start_sha=889ca34fd29b188f93bfa36ece8b4c010adee98c)

ghost1 commented

2026-06-10 03:49:41 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2026-06-10 03:49:50 +00:00

(Migrated from gitlab.com)

resolved all threads

PlasticDigits commented

2026-06-10 05:33:40 +00:00

(Migrated from gitlab.com)

mentioned in commit 933135423d