fix(frontend): type+Enter commits pair search hit (#350) #853

Merged

PlasticDigits merged 1 commit from local1/350-impl-enter-commit-search-hit into main

2026-06-10 05:31:38 +00:00

PlasticDigits commented

2026-06-10 03:34:35 +00:00

(Migrated from gitlab.com)

Fixes #350 — typed pair search Enter no longer reverts to current pair.

Note

Low Risk
Localized UX fix in pair combobox option ordering and active index; covered by a targeted Vitest regression test.

Overview
Fixes #350 so Enter after typing in the trading pair combobox selects the first search result, not the pair already on screen.

PairSearchSelect now only prepends the current pair when the debounced query is empty (so Enter with no typing can still re-confirm the selection). With a typed query it skips that prepend and sets the keyboard highlight to index 0 when the list opens or updates, so Enter commits the top hit.

Adds PairSearchSelect.issue350.test.tsx (mocked indexer, type jade, Enter → second pair) and documents the rule in AGENTS_FRONTEND_PORTAL_LISTBOX_KEYBOARD.md.

^{Reviewed by Cursor Bugbot for commit b0f83914b1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Fixes #350 — typed pair search Enter no longer reverts to current pair.  --- > [!NOTE] > **Low Risk** > Localized UX fix in pair combobox option ordering and active index; covered by a targeted Vitest regression test. > > **Overview** > Fixes **#350** so **Enter** after typing in the trading pair combobox selects the **first search result**, not the pair already on screen. > > **`PairSearchSelect`** now only prepends the current pair when the debounced query is **empty** (so Enter with no typing can still re-confirm the selection). With a **typed** query it skips that prepend and sets the keyboard highlight to **index 0** when the list opens or updates, so Enter commits the top hit. > > Adds **`PairSearchSelect.issue350.test.tsx`** (mocked indexer, type `jade`, Enter → second pair) and documents the rule in **`AGENTS_FRONTEND_PORTAL_LISTBOX_KEYBOARD.md`**. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b0f83914b1241b320f222959c69b7ebca269869d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

Rows
Columns