fix(e2e): add min_return slippage floor to pure-book park hybrid swaps (#339) #842

Closed

Brouie wants to merge 1 commit from qa/339-seed-park-min-return into main

Brouie commented

2026-06-09 02:14:32 +00:00

(Migrated from gitlab.com)

What

scripts/e2e-seed-expired-parked-claim-all.sh and scripts/qa/verify-issue-309.sh execute a pure-book hybrid swap (pool_input:"0", book_input>0) with no belief_price and no min_return. The #334 L9 guard (BookHybridRequiresSlippageFloor) rejects that on execute, so the park swap reverts and no orders park — which breaks limit-orders-claim-all-tx.spec.ts and the #292 strict e2e-tx phase.

Fix

Add min_return:"1" to the Cw20HookMsg::Swap in both harnesses. min_return over belief_price — a scripted terrad path has no oracle, and the floor is all the guard needs (matches the guardrail in #339 and the verify-issue-285.sh fix in !835). #334 is untouched on-chain; harness-only.

Verified live

Ran e2e-seed-expired-parked-claim-all.sh end to end: the park swap that used to revert executes clean, and both expired bids land at lifecycle_status=parked_expired in one tx — restoring the >=2 parked_expired rows the claim-all helper polls for. verify-issue-309.sh got the same one-line floor (not re-run in full; same contract path).

Relates to #339.

## What `scripts/e2e-seed-expired-parked-claim-all.sh` and `scripts/qa/verify-issue-309.sh` execute a pure-book hybrid swap (`pool_input:"0"`, `book_input>0`) with no `belief_price` and no `min_return`. The #334 L9 guard (`BookHybridRequiresSlippageFloor`) rejects that on execute, so the park swap reverts and no orders park — which breaks `limit-orders-claim-all-tx.spec.ts` and the #292 strict `e2e-tx` phase. ## Fix Add `min_return:"1"` to the `Cw20HookMsg::Swap` in both harnesses. `min_return` over `belief_price` — a scripted terrad path has no oracle, and the floor is all the guard needs (matches the guardrail in #339 and the `verify-issue-285.sh` fix in !835). #334 is untouched on-chain; harness-only. ## Verified live Ran `e2e-seed-expired-parked-claim-all.sh` end to end: the park swap that used to revert executes clean, and both expired bids land at `lifecycle_status=parked_expired` in one tx — restoring the >=2 `parked_expired` rows the claim-all helper polls for. `verify-issue-309.sh` got the same one-line floor (not re-run in full; same contract path). Relates to #339.

Rows
Columns

fix(e2e): add min_return slippage floor to pure-book park hybrid swaps (#339) #842

What

Fix

Verified live

Pull request closed