docs: cross-link #337 master QA checklist + Cloud Agent E2E guardrail #833

2026-06-07T13:13:25Z

PlasticDigits commented

2026-06-07 13:13:25 +00:00

(Migrated from gitlab.com)

Summary

Verification of GitLab #337 (Automation Verification Engineer master Local/QA executable checklist).

Build: 20826ea (branch); stack deployed at 038a457

Doc changes (discoverability + guardrails)

Cross-link #337 from docs/qa-onboarding.md, docs/qa-invariants.md, docs/testing.md, docs/runbooks/launch-checklist.md, scripts/qa/README.md
Add Cloud Agent sg docker -c 'CI=1 make test-e2e' guardrail to docs/testing.md (REG-00-06 / LT11–LT12)

Checklist structure verification

Check	Result	Evidence
Header reference docs (6)	PASS	All paths exist
Make targets referenced (25)	PASS	All defined in `Makefile`
E2E spec files cited in checklist	PASS	30 specs under `frontend-dapp/e2e/`

INF-00 (stack provisioning)

Item	Result	Command / output
INF-00-01 Fresh bootstrap	PASS	`make setup-cloud-localterra` → OK; `.env.local`, `indexer/.env`, stamp written
INF-00-02 Q1 deploy verify	PASS	`make qa-verify-deploy` exit 0; stamp `038a457`
INF-00-04 Postgres PG-1	PASS	`DATABASE_URL` user `cl8y_legal`; `make test-indexer-integration` all green
INF-00-05 Node 24 / Vite	PASS	`make dev` on Node v24.16.0; `:5173` serves

REG-00 (automated regression gates)

Item	Result	Command / output
REG-00-01 Contracts	PASS	`make test-contracts`
REG-00-02 Frontend unit	PASS	893 tests (148 files)
REG-00-03 Indexer lib	PASS	134 tests
REG-00-04 Indexer integration	PASS	Serialized suite green
REG-00-05 Charts integration	FAIL	`make test-charts-integration` — host `psql` missing (script exits before docker exec fallback on this VM)
REG-00-06 E2E strict	PARTIAL	`sg docker -c 'CI=1 make test-e2e'` — smoke 101 passed / 4 failed (navigation mobile chip, pool pair count strict mode, trade-book-edit, trade-page-initial-load); tx project not reached
REG-00-07 Indexer outage E2E	FAIL	`make test-e2e-indexer-outage` — indexer on `:3001` from tmux `indexer-dev` could not be stopped
REG-00-08 Issue verifiers	PARTIAL	`verify-issue-295` PASS; `verify-issue-324` PASS; `verify-issue-293` FAIL (3 USTC-C asset rows — checklist documents `make setup-cloud-localterra --fresh`); `verify-issue-285` FAIL (hybrid swap/indexer sync)
REG-00-09 Fee tier docs	PASS	`make check-fee-discount-tier-docs`
REG-00-10 Lint	PASS	`make lint-contracts`; `make lint-frontend` (5 warnings, 0 errors)

ONC-00

Item	Result	Command
ONC-00-01 smoke-pool-swap	PASS	`PAIR_ADDR=$(grep pair_address .qa-deploy-stamp \| cut -d= -f2) bash scripts/smoke-pool-swap.sh`

LR-00 launch readiness

Not 100% — checklist correctly identifies prerequisites; remaining failures are environment/product gaps documented in #337 (fresh volumes for #293, stop indexer before REG-00-07, E2E selector flakes). Full manual sections (WL wallet matrix, WC mobile, etc.) require human sign-off per issue template.

Acceptance mapping

Checklist is executable: make targets, doc links, and QA scripts resolve — PASS
Cross-links from referenced docs: added in this MR — PASS
Automated gates sample: REG-00 mostly green; failures documented with remediation paths already in #337

Note

Low Risk
Markdown-only discoverability and operator notes; no runtime, contract, or application code changes.

Overview
Documentation-only PR that makes GitLab #337 (master Local/QA executable verification checklist) easy to find from the main QA/testing entry points, and adds Cloud Agent E2E run guidance.

#337 cross-links are added at the top or in “Related docs” in docs/qa-onboarding.md, docs/qa-invariants.md, docs/testing.md, docs/runbooks/launch-checklist.md, and scripts/qa/README.md, with short notes tying sections to gates like INF-00-02, Q1, REG-00, and LR-00.

Cloud Agent VM guardrail in docs/testing.md: run strict E2E as sg docker -c 'CI=1 make test-e2e' when host :1317 hangs (points to LT11 / LT12), install Playwright Chromium via ./node_modules/.bin/playwright install chromium, and keep 1 worker for the tx project vs 5 for smoke.

^{Reviewed by Cursor Bugbot for commit 20826eaf42. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary Verification of [GitLab #337](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/work_items/337) (Automation Verification Engineer master Local/QA executable checklist). **Build:** `20826ea` (branch); stack deployed at `038a457` ### Doc changes (discoverability + guardrails) - Cross-link #337 from `docs/qa-onboarding.md`, `docs/qa-invariants.md`, `docs/testing.md`, `docs/runbooks/launch-checklist.md`, `scripts/qa/README.md` - Add Cloud Agent `sg docker -c 'CI=1 make test-e2e'` guardrail to `docs/testing.md` (REG-00-06 / LT11–LT12) ### Checklist structure verification | Check | Result | Evidence | |-------|--------|----------| | Header reference docs (6) | **PASS** | All paths exist | | Make targets referenced (25) | **PASS** | All defined in `Makefile` | | E2E spec files cited in checklist | **PASS** | 30 specs under `frontend-dapp/e2e/` | ### INF-00 (stack provisioning) | Item | Result | Command / output | |------|--------|------------------| | INF-00-01 Fresh bootstrap | **PASS** | `make setup-cloud-localterra` → OK; `.env.local`, `indexer/.env`, stamp written | | INF-00-02 Q1 deploy verify | **PASS** | `make qa-verify-deploy` exit 0; stamp `038a457` | | INF-00-04 Postgres PG-1 | **PASS** | `DATABASE_URL` user `cl8y_legal`; `make test-indexer-integration` all green | | INF-00-05 Node 24 / Vite | **PASS** | `make dev` on Node v24.16.0; `:5173` serves | ### REG-00 (automated regression gates) | Item | Result | Command / output | |------|--------|------------------| | REG-00-01 Contracts | **PASS** | `make test-contracts` | | REG-00-02 Frontend unit | **PASS** | 893 tests (148 files) | | REG-00-03 Indexer lib | **PASS** | 134 tests | | REG-00-04 Indexer integration | **PASS** | Serialized suite green | | REG-00-05 Charts integration | **FAIL** | `make test-charts-integration` — host `psql` missing (script exits before docker exec fallback on this VM) | | REG-00-06 E2E strict | **PARTIAL** | `sg docker -c 'CI=1 make test-e2e'` — smoke **101 passed / 4 failed** (navigation mobile chip, pool pair count strict mode, trade-book-edit, trade-page-initial-load); tx project not reached | | REG-00-07 Indexer outage E2E | **FAIL** | `make test-e2e-indexer-outage` — indexer on `:3001` from tmux `indexer-dev` could not be stopped | | REG-00-08 Issue verifiers | **PARTIAL** | `verify-issue-295` **PASS**; `verify-issue-324` **PASS**; `verify-issue-293` **FAIL** (3 USTC-C asset rows — checklist documents `make setup-cloud-localterra --fresh`); `verify-issue-285` **FAIL** (hybrid swap/indexer sync) | | REG-00-09 Fee tier docs | **PASS** | `make check-fee-discount-tier-docs` | | REG-00-10 Lint | **PASS** | `make lint-contracts`; `make lint-frontend` (5 warnings, 0 errors) | ### ONC-00 | Item | Result | Command | |------|--------|---------| | ONC-00-01 smoke-pool-swap | **PASS** | `PAIR_ADDR=$(grep pair_address .qa-deploy-stamp \| cut -d= -f2) bash scripts/smoke-pool-swap.sh` | ### LR-00 launch readiness **Not 100%** — checklist correctly identifies prerequisites; remaining failures are environment/product gaps documented in #337 (fresh volumes for #293, stop indexer before REG-00-07, E2E selector flakes). Full manual sections (WL wallet matrix, WC mobile, etc.) require human sign-off per issue template. ## Acceptance mapping - **Checklist is executable:** make targets, doc links, and QA scripts resolve — **PASS** - **Cross-links from referenced docs:** added in this MR — **PASS** - **Automated gates sample:** REG-00 mostly green; failures documented with remediation paths already in #337  --- > [!NOTE] > **Low Risk** > Markdown-only discoverability and operator notes; no runtime, contract, or application code changes. > > **Overview** > Documentation-only PR that makes GitLab **#337** (master Local/QA executable verification checklist) easy to find from the main QA/testing entry points, and adds Cloud Agent E2E run guidance. > > **#337 cross-links** are added at the top or in “Related docs” in `docs/qa-onboarding.md`, `docs/qa-invariants.md`, `docs/testing.md`, `docs/runbooks/launch-checklist.md`, and `scripts/qa/README.md`, with short notes tying sections to gates like **INF-00-02**, **Q1**, **REG-00**, and **LR-00**. > > **Cloud Agent VM guardrail** in `docs/testing.md`: run strict E2E as `sg docker -c 'CI=1 make test-e2e'` when host `:1317` hangs (points to **LT11** / **LT12**), install Playwright Chromium via `./node_modules/.bin/playwright install chromium`, and keep **1 worker** for the tx project vs **5** for smoke. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 20826eaf42072fb2aacd7317ef043d7c38e8f485. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

ghost1 commented

2026-06-07 13:13:33 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2026-06-07 13:13:38 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-07 13:14:16 +00:00

(Migrated from gitlab.com)

Security review

Commit reviewed: 20826eaf42072fb2aacd7317ef043d7c38e8f485
Scope: Markdown-only diff — cross-links to GitLab #337 in five QA/testing docs plus a Cloud Agent E2E operator note in docs/testing.md (sg docker -c 'CI=1 make test-e2e', Playwright install path, worker counts).
Outcome: FINDINGS: 0 (no medium, high, or critical)

Analysis

No runtime / application / contract / indexer changes — attack surface unchanged.
Added content is static markdown: internal GitLab work-item links and existing LocalTerra E2E guidance already documented in AGENTS.md / docs/localterra-sdk53.md (LT11–LT12).
No secrets, credentials, or env values introduced.
No new dependencies or CI/script execution paths.
No user-controlled input sinks — docs are not rendered from attacker-controlled data.

Prior threads

No prior security-review inline findings on this MR; nothing to re-report.

Inline comments: none (no medium+ findings).

## Security review **Commit reviewed:** `20826eaf42072fb2aacd7317ef043d7c38e8f485` **Scope:** Markdown-only diff — cross-links to GitLab #337 in five QA/testing docs plus a Cloud Agent E2E operator note in `docs/testing.md` (`sg docker -c 'CI=1 make test-e2e'`, Playwright install path, worker counts). **Outcome:** **FINDINGS: 0** (no medium, high, or critical) ### Analysis - **No runtime / application / contract / indexer changes** — attack surface unchanged. - **Added content** is static markdown: internal GitLab work-item links and existing LocalTerra E2E guidance already documented in `AGENTS.md` / `docs/localterra-sdk53.md` (LT11–LT12). - **No secrets, credentials, or env values** introduced. - **No new dependencies** or CI/script execution paths. - **No user-controlled input sinks** — docs are not rendered from attacker-controlled data. ### Prior threads No prior security-review inline findings on this MR; nothing to re-report. **Inline comments:** none (no medium+ findings).

koves1 commented

2026-06-07 13:26:06 +00:00

(Migrated from gitlab.com)

🤖 AI Triage: Approved. Good to see documentation being kept up to date and interconnected.

🤖 **AI Triage:** Approved. Good to see documentation being kept up to date and interconnected.