docs(#292): LT12 Playwright install + verification prerequisites #831

2026-06-06T09:56:24Z

PlasticDigits commented

2026-06-06 09:56:24 +00:00

(Migrated from gitlab.com)

Summary

Verification QA for GitLab #292 on Cloud Agent VM. SDK 53 / terrad v4 chain, deploy, contracts, indexer, and QA verify deploy all pass. Strict E2E and one frontend unit test fail due to separate tracked issues (#293, #186, #178, #179, #259).

This MR adds documentation guardrails discovered during verification.

Changes

LT12 invariant: install Playwright Chromium via locked frontend-dapp/node_modules/.bin/playwright, not bare npx playwright (version mismatch caused 105/106 smoke failures on first E2E run)
Document (cd indexer && cargo build --release) before e2e-start-indexer.sh on fresh VMs
Add #292 acceptance status table separating SDK 53 scope vs separate issues

Acceptance checklist

Criterion	Command	Result
1. Fresh stack + deploy on new digest	`make reset && make start && make wait-healthy && make build-optimized && make deploy-local`	PASS — terrad 4.0.1, 25 pairs, 60 swaps
2. `make test`	`make test-contracts` + `make test-frontend`	PARTIAL — contracts 438/438; frontend 892/893 (#293)
3. Strict E2E	`deploy-local` → `e2e-start-indexer.sh` → `sg docker -c 'CI=1 make test-e2e'`	FAIL — smoke 102/106 (#186, #178, #179); e2e-tx 32/38 when run directly
4. QA verify deploy	`make test-qa-verify-deploy`	PASS
Indexer integration	`make test-indexer-integration`	PASS
Host LCD	`make test-localterra-host-curl`	PASS

Issue #292 remains open pending criteria 2–3.

Note

Low Risk
Documentation-only updates to agent and LocalTerra SDK 53 runbooks; no application, CI, or infrastructure code changes.

Overview
Documents #292 verification guardrails from Cloud Agent QA—no runtime or CI workflow changes.

Adds LT12: install Playwright Chromium through locked frontend-dapp ./node_modules/.bin/playwright, not bare npx playwright, to avoid Chromium revision mismatches that break E2E launches.

Expands strict E2E steps with (cd indexer && cargo build --release) before e2e-start-indexer.sh on fresh VMs, CI=1 for Cloud Agent make test-e2e, and cross-links LT11 / LT12 in AGENTS.md, docs/localterra-sdk53.md, and skills/AGENTS_E2E_STRICT_CHAIN.md.

Introduces a #292 acceptance status table that separates in-scope SDK 53 / terrad v4 checks from out-of-scope or mixed failures tracked in other issues (#293, #186, #178, #179).

^{Reviewed by Cursor Bugbot for commit e368223068. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary Verification QA for [GitLab #292](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/292) on Cloud Agent VM. SDK 53 / terrad v4 chain, deploy, contracts, indexer, and QA verify deploy all pass. Strict E2E and one frontend unit test fail due to separate tracked issues (#293, #186, #178, #179, #259). This MR adds documentation guardrails discovered during verification. ## Changes - **LT12** invariant: install Playwright Chromium via locked `frontend-dapp/node_modules/.bin/playwright`, not bare `npx playwright` (version mismatch caused 105/106 smoke failures on first E2E run) - Document `(cd indexer && cargo build --release)` before `e2e-start-indexer.sh` on fresh VMs - Add #292 acceptance status table separating SDK 53 scope vs separate issues ## Acceptance checklist | Criterion | Command | Result | |-----------|---------|--------| | 1. Fresh stack + deploy on new digest | `make reset && make start && make wait-healthy && make build-optimized && make deploy-local` | **PASS** — terrad 4.0.1, 25 pairs, 60 swaps | | 2. `make test` | `make test-contracts` + `make test-frontend` | **PARTIAL** — contracts 438/438; frontend 892/893 ([#293](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/293)) | | 3. Strict E2E | `deploy-local` → `e2e-start-indexer.sh` → `sg docker -c 'CI=1 make test-e2e'` | **FAIL** — smoke 102/106 ([#186](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/186), [#178](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/178), [#179](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/179)); e2e-tx 32/38 when run directly | | 4. QA verify deploy | `make test-qa-verify-deploy` | **PASS** | | Indexer integration | `make test-indexer-integration` | **PASS** | | Host LCD | `make test-localterra-host-curl` | **PASS** | Issue **#292** remains open pending criteria 2–3.  --- > [!NOTE] > **Low Risk** > Documentation-only updates to agent and LocalTerra SDK 53 runbooks; no application, CI, or infrastructure code changes. > > **Overview** > Documents **#292** verification guardrails from Cloud Agent QA—no runtime or CI workflow changes. > > Adds **LT12**: install Playwright Chromium through locked `frontend-dapp` `./node_modules/.bin/playwright`, not bare `npx playwright`, to avoid Chromium revision mismatches that break E2E launches. > > Expands strict E2E steps with `(cd indexer && cargo build --release)` before `e2e-start-indexer.sh` on fresh VMs, `CI=1` for Cloud Agent `make test-e2e`, and cross-links **LT11** / **LT12** in `AGENTS.md`, `docs/localterra-sdk53.md`, and `skills/AGENTS_E2E_STRICT_CHAIN.md`. > > Introduces a **#292 acceptance status** table that separates in-scope SDK 53 / terrad v4 checks from out-of-scope or mixed failures tracked in other issues (#293, #186, #178, #179). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit e3682230688701ef9d8d301a2112a3b40dc7c49e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

ghost1 commented

2026-06-06 09:56:31 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2026-06-06 09:56:37 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-06 09:57:26 +00:00

(Migrated from gitlab.com)

Security review

Commit reviewed: e3682230688701ef9d8d301a2112a3b40dc7c49e

Scope: Documentation-only changes to AGENTS.md, docs/localterra-sdk53.md, and skills/AGENTS_E2E_STRICT_CHAIN.md. Adds LT12 Playwright install invariant, indexer release-build prerequisite, #292 acceptance status table, and CI=1 Cloud Agent E2E note.

Outcome: FINDINGS: 0 medium+

Security review: no medium+ findings on this diff.

Analysis:

No application, contract, indexer, frontend, or CI configuration code modified.
No secrets, credentials, or sensitive deployment artifacts introduced.
LT12 guidance to use locked ./node_modules/.bin/playwright instead of bare npx playwright reduces supply-chain drift risk in dev/QA environments; no exploitable attack surface added.
Documented shell commands are static operator instructions, not attacker-controlled execution paths.

No inline threads (no findings).

## Security review **Commit reviewed:** `e3682230688701ef9d8d301a2112a3b40dc7c49e` **Scope:** Documentation-only changes to `AGENTS.md`, `docs/localterra-sdk53.md`, and `skills/AGENTS_E2E_STRICT_CHAIN.md`. Adds LT12 Playwright install invariant, indexer release-build prerequisite, #292 acceptance status table, and `CI=1` Cloud Agent E2E note. **Outcome:** `FINDINGS: 0` medium+ Security review: no medium+ findings on this diff. **Analysis:** - No application, contract, indexer, frontend, or CI configuration code modified. - No secrets, credentials, or sensitive deployment artifacts introduced. - LT12 guidance to use locked `./node_modules/.bin/playwright` instead of bare `npx playwright` reduces supply-chain drift risk in dev/QA environments; no exploitable attack surface added. - Documented shell commands are static operator instructions, not attacker-controlled execution paths. No inline threads (no findings).

PlasticDigits commented

2026-06-06 12:23:12 +00:00

(Migrated from gitlab.com)

mentioned in commit 03b3a44dac

mentioned in commit 03b3a44dac4d2d119d7b39571a6a4820a5a8c916