docs(#302): close route-display scope after #329 fallback label #824

2026-06-06T07:02:09Z

PlasticDigits commented

2026-06-06 07:02:09 +00:00

(Migrated from gitlab.com)

Summary

Documentation follow-up for GitLab #302. Feature work is already on main:

Change	MR / commit
`/trade` market route row (`trade-market-route-summary`)	!758 — `5505b8a`
`/swap` client BFS fallback label (`swap-route-source-client-fallback`)	#329 — `e924ac1`

This MR updates skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md — renames stale "Open scope" to "Closed scope" after #329 merged.

Verification checklist

Acceptance item	Command / step	Result
Multi-hop route on `/trade` when indexer supplies path	`TradeMarketOrderPanel` → `computeSwapRouteDisplay`; `npm run test:run -- swapRouteDisplay.test.ts`	PASS (`5505b8a` on main)
Route displayed on `/swap`	`npm run test:run -- swapRouteDisplay.test.ts SwapPage.test.tsx`	PASS
Client BFS fallback indicator on `/swap`	`SwapPage.test.tsx` tests `swap-route-source-client-fallback`; `deriveSwapSubmitRouteSource` unit tests	PASS (`e924ac1` on main)
Fallback on `/trade`	N/A (`clientRoute: null`)	SKIP
Explainability / best route	Token arrow + `SWAP_CLIENT_BFS_FALLBACK_COPY`; no separate rationale (P2 descoped)	PASS
`/limits` routing	N/A per issue	SKIP
`make lint-frontend`	0 errors (5 pre-existing warnings)	PASS
`npx tsc -b`	clean	PASS
LocalTerra browser	Not run (no `.env.local` this session); covered by unit tests + prior verify on `main`	SKIP

Third-party verification

export PATH="$HOME/.nvm/versions/node/$(cat .nvmrc)/bin:$PATH"
make lint-frontend
cd frontend-dapp && npx tsc -b
npm run test:run -- swapRouteDisplay.test.ts routeOperations.test.ts SwapPage.test.tsx

Optional manual (make setup-cloud-localterra):

/swap with indexer unavailable → route row + swap-route-source-client-fallback.
/trade/:pair Market tab, hybrid on, amount 1 → trade-market-route-summary inside trade-market-quote.

Related: #302

## Summary Documentation follow-up for [GitLab #302](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/work_items/302). **Feature work is already on `main`:** | Change | MR / commit | |--------|-------------| | `/trade` market route row (`trade-market-route-summary`) | !758 — `5505b8a` | | `/swap` client BFS fallback label (`swap-route-source-client-fallback`) | #329 — `e924ac1` | This MR updates `skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md` — renames stale "Open scope" to "Closed scope" after #329 merged. ## Verification checklist | Acceptance item | Command / step | Result | |-----------------|----------------|--------| | Multi-hop route on `/trade` when indexer supplies path | `TradeMarketOrderPanel` → `computeSwapRouteDisplay`; `npm run test:run -- swapRouteDisplay.test.ts` | **PASS** (`5505b8a` on main) | | Route displayed on `/swap` | `npm run test:run -- swapRouteDisplay.test.ts SwapPage.test.tsx` | **PASS** | | Client BFS fallback indicator on `/swap` | `SwapPage.test.tsx` tests `swap-route-source-client-fallback`; `deriveSwapSubmitRouteSource` unit tests | **PASS** (`e924ac1` on main) | | Fallback on `/trade` | N/A (`clientRoute: null`) | **SKIP** | | Explainability / best route | Token arrow + `SWAP_CLIENT_BFS_FALLBACK_COPY`; no separate rationale (P2 descoped) | **PASS** | | `/limits` routing | N/A per issue | **SKIP** | | `make lint-frontend` | 0 errors (5 pre-existing warnings) | **PASS** | | `npx tsc -b` | clean | **PASS** | | LocalTerra browser | Not run (no `.env.local` this session); covered by unit tests + prior verify on `main` | **SKIP** | ### Third-party verification ```bash export PATH="$HOME/.nvm/versions/node/$(cat .nvmrc)/bin:$PATH" make lint-frontend cd frontend-dapp && npx tsc -b npm run test:run -- swapRouteDisplay.test.ts routeOperations.test.ts SwapPage.test.tsx ``` Optional manual (`make setup-cloud-localterra`): 1. `/swap` with indexer unavailable → route row + `swap-route-source-client-fallback`. 2. `/trade/:pair` Market tab, hybrid on, amount `1` → `trade-market-route-summary` inside `trade-market-quote`. Related: #302

ghost1 commented

2026-06-06 07:02:18 +00:00

(Migrated from gitlab.com)

changed the description

ghost1 commented

2026-06-06 07:02:24 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-06 07:02:46 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-06 07:02:47 +00:00

(Migrated from gitlab.com)

mentioned in issue #302

PlasticDigits commented

2026-06-06 07:06:35 +00:00

(Migrated from gitlab.com)

Security review

Commit reviewed: 3258f310261f6f2a56577d38b53a4163178d0f5b
Scope: 1 file — skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md (documentation only; renames "Open scope" → "Closed scope" and updates #302/#329 status bullets).

Outcome: FINDINGS: 0 medium+

Summary: Security review: no medium+ findings on this diff.

This MR touches only agent/developer documentation (markdown). No executable code, configuration, dependencies, auth paths, or user-facing runtime behavior are changed. There are no attacker-controlled inputs, sinks, or trust-boundary changes to evaluate.

Inline threads: none (no findings).

Automated security review (cursor/mr-security-review).

## Security review **Commit reviewed:** `3258f310261f6f2a56577d38b53a4163178d0f5b` **Scope:** 1 file — `skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md` (documentation only; renames "Open scope" → "Closed scope" and updates #302/#329 status bullets). **Outcome:** `FINDINGS: 0` medium+ **Summary:** Security review: no medium+ findings on this diff. This MR touches only agent/developer documentation (markdown). No executable code, configuration, dependencies, auth paths, or user-facing runtime behavior are changed. There are no attacker-controlled inputs, sinks, or trust-boundary changes to evaluate. **Inline threads:** none (no findings). --- *Automated security review (cursor/mr-security-review).*

PlasticDigits commented

2026-06-06 07:10:08 +00:00

(Migrated from gitlab.com)

mentioned in commit 7aeb50ba58

mentioned in commit 7aeb50ba587a954b7bb597cc30b6d179609b8d6b