docs(#321): document /trade trade-market-route-summary in swap route skill (#302) #788

2026-06-05T10:07:05Z

PlasticDigits commented

2026-06-05 10:07:05 +00:00

(Migrated from gitlab.com)

Summary

Closes documentation gap for GitLab #321 / #302: the shared computeSwapRouteDisplay helper powers both Swap (swap-route-summary) and Trade market (trade-market-route-summary), but the agent skill and frontend docs only described the swap surface.

What changed:

Extended skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md with subtitle, trade code map, when-route-appears table, and /trade manual regression steps.
Added market route preview row to docs/frontend.md#trade-page-market-context.
Cross-linked #302 in docs/swap-max-spread-ux.md invariant #6.
One-line pointer in AGENTS.md.

Issue: https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/work_items/321

Acceptance checklist

Criterion	Verification	Result
Skill documents both testids with file paths and #302	Read skill code map + cross-links	PASS
Skill explains shared `computeSwapRouteDisplay` + indexer precedence	Product invariant section	PASS
Manual regression includes `/trade` market step	Checklist steps 5-8	PASS
`docs/frontend.md` links skill for trade market route	trade-page-market-context row	PASS
No swap-only contradictory text	Doc review	PASS

Verification (third parties)

Check	Command / step	Result
Unit tests	`cd frontend-dapp && npm run test:run -- swapRouteDisplay.test.ts`	PASS (4/4)
Docs drift	`python3 scripts/check_fee_discount_tier_docs.py`	PASS
Trade manual QA	Local stack market tab hybrid on	SKIP (documented in skill)

Note

Low Risk
Markdown and agent playbook updates only; no application code, contracts, or runtime behavior changes.

Overview
Docs-only — closes the gap where trade-market-route-summary on /trade market quotes was implemented but agent/docs still described route preview as swap-only (#321 / #302).

skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md is retitled and expanded to cover Swap and Trade market: shared computeSwapRouteDisplay, execution-aligned submit rules per surface, a code map for TradeMarketOrderPanel + testids, a when the route row appears table, and manual regression steps 5–8 for the Market tab.

docs/frontend.md adds a Market quote — route preview (#302) invariant under trade market context and links the skill from third-party context.

docs/swap-max-spread-ux.md updates frontend invariant #6 and related links to include Trade market trade-market-route-summary.

AGENTS.md adds a one-line playbook pointer to the skill.

^{Reviewed by Cursor Bugbot for commit 5d3917c4dc. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary Closes documentation gap for GitLab **#321** / **#302**: the shared `computeSwapRouteDisplay` helper powers both Swap (`swap-route-summary`) and Trade market (`trade-market-route-summary`), but the agent skill and frontend docs only described the swap surface. **What changed:** - Extended `skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md` with subtitle, trade code map, when-route-appears table, and `/trade` manual regression steps. - Added market route preview row to `docs/frontend.md#trade-page-market-context`. - Cross-linked **#302** in `docs/swap-max-spread-ux.md` invariant #6. - One-line pointer in `AGENTS.md`. Issue: https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/work_items/321 ## Acceptance checklist | Criterion | Verification | Result | |-----------|--------------|--------| | Skill documents both testids with file paths and #302 | Read skill code map + cross-links | PASS | | Skill explains shared `computeSwapRouteDisplay` + indexer precedence | Product invariant section | PASS | | Manual regression includes `/trade` market step | Checklist steps 5-8 | PASS | | `docs/frontend.md` links skill for trade market route | trade-page-market-context row | PASS | | No swap-only contradictory text | Doc review | PASS | ## Verification (third parties) | Check | Command / step | Result | |-------|----------------|--------| | Unit tests | `cd frontend-dapp && npm run test:run -- swapRouteDisplay.test.ts` | PASS (4/4) | | Docs drift | `python3 scripts/check_fee_discount_tier_docs.py` | PASS | | Trade manual QA | Local stack market tab hybrid on | SKIP (documented in skill) |  --- > [!NOTE] > **Low Risk** > Markdown and agent playbook updates only; no application code, contracts, or runtime behavior changes. > > **Overview** > **Docs-only** — closes the gap where **`trade-market-route-summary`** on `/trade` market quotes was implemented but agent/docs still described route preview as swap-only ([#321](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/work_items/321) / [#302](https://gitlab.com/PlasticDigits/cl8y-dex-terraclassic/-/issues/302)). > > **`skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md`** is retitled and expanded to cover **Swap and Trade market**: shared **`computeSwapRouteDisplay`**, execution-aligned submit rules per surface, a **code map** for `TradeMarketOrderPanel` + testids, a **when the route row appears** table, and manual regression steps **5–8** for the Market tab. > > **`docs/frontend.md`** adds a **Market quote — route preview (#302)** invariant under trade market context and links the skill from third-party context. > > **`docs/swap-max-spread-ux.md`** updates frontend invariant **#6** and related links to include Trade market **`trade-market-route-summary`**. > > **`AGENTS.md`** adds a one-line playbook pointer to the skill. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 5d3917c4dca3550ff4111c7309fd0b47955f9fe8. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

ghost1 commented

2026-06-05 10:07:11 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-05 10:07:13 +00:00

(Migrated from gitlab.com)

mentioned in issue #321

ghost1 commented

2026-06-05 10:07:19 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-05 10:08:09 +00:00

(Migrated from gitlab.com)

Security review

Commit reviewed: 5d3917c4dca3550ff4111c7309fd0b47955f9fe8
Scope: 4 files — AGENTS.md, docs/frontend.md, docs/swap-max-spread-ux.md, skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md (documentation / agent playbook only; no application, contract, indexer, or dependency changes).

Method: Full MR diff review for injection, authn/authz, secret leakage, SSRF/XSS/CSRF surfaces, unsafe deserialization, and supply-chain deltas. Referenced implementation paths (TradeMarketOrderPanel, computeSwapRouteDisplay) were checked only to confirm docs describe existing behavior; no new runtime sinks introduced by this diff.

Outcome: FINDINGS: 0 medium+ — NONE

Inline threads: None (no findings to anchor).

Security review: no medium+ findings on this diff.

## Security review **Commit reviewed:** `5d3917c4dca3550ff4111c7309fd0b47955f9fe8` **Scope:** 4 files — `AGENTS.md`, `docs/frontend.md`, `docs/swap-max-spread-ux.md`, `skills/AGENTS_FRONTEND_SWAP_ROUTE_DISPLAY.md` (documentation / agent playbook only; no application, contract, indexer, or dependency changes). **Method:** Full MR diff review for injection, authn/authz, secret leakage, SSRF/XSS/CSRF surfaces, unsafe deserialization, and supply-chain deltas. Referenced implementation paths (`TradeMarketOrderPanel`, `computeSwapRouteDisplay`) were checked only to confirm docs describe existing behavior; no new runtime sinks introduced by this diff. **Outcome:** `FINDINGS: 0` medium+ — **NONE** **Inline threads:** None (no findings to anchor). --- Security review: no medium+ findings on this diff.

PlasticDigits commented

2026-06-05 10:36:23 +00:00

(Migrated from gitlab.com)

mentioned in commit 637f4e7712

mentioned in commit 637f4e7712a4e9a4a419dece89ae032c54f47ad9