fix(deploy): set pair_creation_fee_uluna=0 for local factory instantiate (#276) #770

Merged

PlasticDigits merged 1 commit from cursor/fix-local-deploy-pair-fee-345b into main

2026-06-05 06:02:24 +00:00

PlasticDigits commented

2026-06-05 05:52:32 +00:00

(Migrated from gitlab.com)

Summary

Unblocks make deploy-local / make start-qa after factory #276 pair-creation fee landed on main (default 100 LUNC per CreatePair).

Local seed instantiates the factory and creates 20+ pairs in one run without attaching uluna on each create_pair. Instantiate with pair_creation_fee_uluna: "0" for LocalTerra dev/QA only.

Verification checklist

Acceptance item	Result	Command / output
`deploy-local` completes pair creation phase	PASS	`sg docker -c 'make reset-qa'` → all 20 pairs created; stamp `git_sha=01e3569`
QA verify-deploy green	PASS	`[qa-verify-deploy] OK — deployed pair schema matches current tree`
Indexer healthy	PASS	`curl http://127.0.0.1:3001/health` → `{"status":"ok"}`
Frontend dev starts	PASS	`make dev` → Vite on `:5173`
#303 browser QA — Swap/Trade/Limits fraction buttons 25/50/75/100% + Max	PASS	Chrome QA on `http://127.0.0.1:5173/` — buttons visible; Swap 25% click filled amount
#303 browser QA — Pool provide-liquidity	PASS (scope)	Max + 50% only per MR !759
#303 browser QA — Keplr wallet connect	FAIL	Keplr extension loadable; Cloud Agent Chrome cannot complete mnemonic import / extension popup

GitLab #276 — pair creation fee
GitLab #303 — fraction preset buttons (merged !759)

Note

Low Risk
Single-line change to local deploy script instantiate JSON only; no contract or production config changes.

Overview
Restores local/QA deploy after factory #276 started charging uluna on each CreatePair (default 100 LUNC on main).

deploy-dex-local.sh now instantiates the factory with pair_creation_fee_uluna: "0" so the seed run can create 20+ pairs via plain create_pair executes without attaching LUNC on every tx. A short comment ties this to #276 and local dev only—production-style fees are unchanged elsewhere.

^{Reviewed by Cursor Bugbot for commit 01e35696b7. Bugbot is set up for automated code reviews on this repo. Configure here.}

## Summary Unblocks `make deploy-local` / `make start-qa` after factory **#276** pair-creation fee landed on `main` (default **100 LUNC** per `CreatePair`). Local seed instantiates the factory and creates **20+ pairs** in one run without attaching uluna on each `create_pair`. Instantiate with `pair_creation_fee_uluna: "0"` for LocalTerra dev/QA only. ## Verification checklist | Acceptance item | Result | Command / output | |-----------------|--------|------------------| | `deploy-local` completes pair creation phase | **PASS** | `sg docker -c 'make reset-qa'` → all 20 pairs created; stamp `git_sha=01e3569` | | QA verify-deploy green | **PASS** | `[qa-verify-deploy] OK — deployed pair schema matches current tree` | | Indexer healthy | **PASS** | `curl http://127.0.0.1:3001/health` → `{"status":"ok"}` | | Frontend dev starts | **PASS** | `make dev` → Vite on `:5173` | | **#303 browser QA** — Swap/Trade/Limits fraction buttons 25/50/75/100% + Max | **PASS** | Chrome QA on `http://127.0.0.1:5173/` — buttons visible; Swap 25% click filled amount | | **#303 browser QA** — Pool provide-liquidity | **PASS** (scope) | Max + 50% only per MR !759 | | **#303 browser QA** — Keplr wallet connect | **FAIL** | Keplr extension loadable; Cloud Agent Chrome cannot complete mnemonic import / extension popup | ## Related - GitLab **#276** — pair creation fee - GitLab **#303** — fraction preset buttons (merged !759)  --- > [!NOTE] > **Low Risk** > Single-line change to local deploy script instantiate JSON only; no contract or production config changes. > > **Overview** > Restores **local/QA deploy** after factory **#276** started charging **uluna** on each `CreatePair` (default **100 LUNC** on `main`). > > `deploy-dex-local.sh` now instantiates the factory with **`pair_creation_fee_uluna: "0"`** so the seed run can create **20+ pairs** via plain `create_pair` executes without attaching LUNC on every tx. A short comment ties this to **#276** and local dev only—production-style fees are unchanged elsewhere. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 01e35696b70274ad47b003053b4b5f77e02643c1. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup>

Rows
Columns