docs(qa): verify GitLab #276 pair-creation fee invariants and deploy path #762

2026-06-05T03:52:35Z

PlasticDigits commented

2026-06-05 03:52:35 +00:00

(Migrated from gitlab.com)

Summary

Verified GitLab #276 (permissionless CreatePair one-per-block griefing). On-chain fix shipped in MR !754 (100 LUNC governance-settable creation fee to treasury). This MR closes verification gaps found during QA:

Docs / invariants: Document pair_creation_fee_uluna, SetPairCreationFee, and new audit invariant F2 in security-model.md, contracts-terraclassic.md, and contracts-security-audit.md. Update deployment-guide.md with --amount on create_pair.
Local deploy: deploy-dex-local.sh instantiates factory with pair_creation_fee_uluna=0 so seed scripts keep working without attaching uluna on every pair.
E2E seed: e2e-seed-wrap-pairs.sh queries factory config and attaches the creation fee when non-zero.
Automation: Add scripts/qa/verify-issue-276.sh and make verify-issue-276.

Verification checklist (acceptance → command/output)

Acceptance item	Result	How verified
A single sender cannot indefinitely block other senders from creating pairs at zero marginal cost	PASS	Default 100 LUNC fee; sustained one-per-block griefing costs fee every block
100 LUNC creation fee transferred to treasury on `CreatePair`	PASS	`create_pair_charges_fee_to_treasury_and_gov_can_set_it`
Empty / underpaid attachment rejected	PASS	Same test: empty funds → error containing `uluna`
Governance can raise fee (`SetPairCreationFee`)	PASS	Same test: gov sets 500M uluna; `Config` query reflects new fee
Non-governance blocked from changing fee	PASS	Same test: user `SetPairCreationFee` → `Unauthorized`
One-per-block gate still enforced (regression)	PASS	`test_create_pair_one_per_block_then_next_block_ok`
Full contract suite green	PASS	`make test-contracts` → 0 failures
Docs / invariants cross-linked (#276, F2)	PASS (this MR)	`make verify-issue-276`
Local deploy path not broken by default fee	PASS (this MR)	`deploy-dex-local.sh` sets `pair_creation_fee_uluna=0`
On-chain live deploy smoke	SKIP	Docker unavailable in Cloud Agent VM this session
Frontend `createPair` attaches fee	SKIP (follow-up)	Deferred in MR !754

Automated verification: make verify-issue-276 → PASS: 5 FAIL: 0

Follow-ups

Frontend: attach uluna fee in createPair and surface on CreatePair page.
Optional live check after make deploy-local on a non-zero-fee deployment.

## Summary Verified GitLab **#276** (permissionless `CreatePair` one-per-block griefing). On-chain fix shipped in MR !754 (100 LUNC governance-settable creation fee to treasury). This MR closes verification gaps found during QA: - **Docs / invariants:** Document `pair_creation_fee_uluna`, `SetPairCreationFee`, and new audit invariant **F2** in `security-model.md`, `contracts-terraclassic.md`, and `contracts-security-audit.md`. Update `deployment-guide.md` with `--amount` on `create_pair`. - **Local deploy:** `deploy-dex-local.sh` instantiates factory with `pair_creation_fee_uluna=0` so seed scripts keep working without attaching uluna on every pair. - **E2E seed:** `e2e-seed-wrap-pairs.sh` queries factory config and attaches the creation fee when non-zero. - **Automation:** Add `scripts/qa/verify-issue-276.sh` and `make verify-issue-276`. ## Verification checklist (acceptance → command/output) | Acceptance item | Result | How verified | |-----------------|--------|--------------| | A single sender cannot indefinitely block other senders from creating pairs at **zero marginal cost** | **PASS** | Default **100 LUNC** fee; sustained one-per-block griefing costs fee every block | | 100 LUNC creation fee transferred to treasury on `CreatePair` | **PASS** | `create_pair_charges_fee_to_treasury_and_gov_can_set_it` | | Empty / underpaid attachment rejected | **PASS** | Same test: empty funds → error containing `uluna` | | Governance can raise fee (`SetPairCreationFee`) | **PASS** | Same test: gov sets 500M uluna; `Config` query reflects new fee | | Non-governance blocked from changing fee | **PASS** | Same test: user `SetPairCreationFee` → `Unauthorized` | | One-per-block gate still enforced (regression) | **PASS** | `test_create_pair_one_per_block_then_next_block_ok` | | Full contract suite green | **PASS** | `make test-contracts` → 0 failures | | Docs / invariants cross-linked (#276, F2) | **PASS** (this MR) | `make verify-issue-276` | | Local deploy path not broken by default fee | **PASS** (this MR) | `deploy-dex-local.sh` sets `pair_creation_fee_uluna=0` | | On-chain live deploy smoke | **SKIP** | Docker unavailable in Cloud Agent VM this session | | Frontend `createPair` attaches fee | **SKIP** (follow-up) | Deferred in MR !754 | **Automated verification:** `make verify-issue-276` → `PASS: 5 FAIL: 0` ## Follow-ups - Frontend: attach uluna fee in `createPair` and surface on CreatePair page. - Optional live check after `make deploy-local` on a non-zero-fee deployment.

PlasticDigits commented

2026-06-05 03:52:43 +00:00

(Migrated from gitlab.com)

changed the description

PlasticDigits commented

2026-06-05 03:54:46 +00:00

(Migrated from gitlab.com)

Security review (automated)

Commit reviewed: 6ba08a4fb55372feec805e7524c4dd048bf1b3b3

Scope: MR diff vs main — docs/invariants for GitLab #276 (pair-creation fee F2), make verify-issue-276, local deploy pair_creation_fee_uluna=0, e2e-seed-wrap-pairs.sh fee attachment, and bundled frontend UX (fraction presets #303, limit-ladder crossing guard, market route summary).

Method: Reviewed added/modified paths only; traced untrusted input to sinks (shell, XSS, authz). On-chain fee enforcement (execute_create_pair, SetPairCreationFee) unchanged in this MR.

Outcome: FINDINGS: 0 medium+

Inline threads: None (no qualifying issues on this diff).

Notes (informational, below reporting threshold)

deploy-dex-local.sh sets pair_creation_fee_uluna=0 for local ergonomics; production/migrated factories retain the default fee per existing contract logic — not a production authz bypass.
e2e-seed-wrap-pairs.sh reads fee from factory Config via LCD/jq and passes --amount …uluna; value is governance/on-chain config, quoted in bash — no new attacker-controlled injection surface in this change.
Frontend guard messages and route text render via React text nodes (no dangerouslySetInnerHTML); ladder crossing checks are client-side UX hardening with on-chain validation unchanged.

## Security review (automated) **Commit reviewed:** `6ba08a4fb55372feec805e7524c4dd048bf1b3b3` **Scope:** MR diff vs `main` — docs/invariants for GitLab #276 (pair-creation fee F2), `make verify-issue-276`, local deploy `pair_creation_fee_uluna=0`, `e2e-seed-wrap-pairs.sh` fee attachment, and bundled frontend UX (fraction presets #303, limit-ladder crossing guard, market route summary). **Method:** Reviewed added/modified paths only; traced untrusted input to sinks (shell, XSS, authz). On-chain fee enforcement (`execute_create_pair`, `SetPairCreationFee`) unchanged in this MR. **Outcome:** **FINDINGS: 0** medium+ **Inline threads:** None (no qualifying issues on this diff). ### Notes (informational, below reporting threshold) - `deploy-dex-local.sh` sets `pair_creation_fee_uluna=0` for local ergonomics; production/migrated factories retain the default fee per existing contract logic — not a production authz bypass. - `e2e-seed-wrap-pairs.sh` reads fee from factory `Config` via LCD/jq and passes `--amount …uluna`; value is governance/on-chain config, quoted in bash — no new attacker-controlled injection surface in this change. - Frontend guard messages and route text render via React text nodes (no `dangerouslySetInnerHTML`); ladder crossing checks are client-side UX hardening with on-chain validation unchanged.

PlasticDigits commented

2026-06-05 04:30:33 +00:00

(Migrated from gitlab.com)

mentioned in issue #303