fix(frontend): confirmed language for on-chain tx success alerts (#304) #755

Merged

Brouie merged 1 commit from qa/304-confirmed-tx-language into main

2026-06-05 03:23:33 +00:00

Brouie commented

2026-06-05 03:03:45 +00:00

(Migrated from gitlab.com)

Follow-up on #304 (the language half).

The /trade market, /trade limit, /limits, and ladder success alerts read "... submitted." even though they fire only after pollTx confirms code == 0 — the tx is already on-chain — while /swap and /pool already say "successful" / "provided". Switched the four to confirmed language: "Market swap confirmed." / "Limit order placed." / "Ladder placed.".

One addition to your list: there's a 4th occurrence you didn't catch — LimitOrdersPage.tsx:597 ("Limit order submitted.") — fixed it too for consistency. tsc -b clean.

Not in this MR (flagged): the separate intermediate broadcast → confirming state (part 1 of #304). terraBroadcast.ts runs broadcastTx then pollTx as sequential awaits in one mutationFn, so isPending covers sign-through-confirm with no hook to switch to a "Confirming…" label. That's a broadcast-pattern change worth doing on its own. Visual confirmation is yours (browser). No closing keyword.

Follow-up on #304 (the language half). The `/trade` market, `/trade` limit, `/limits`, and ladder success alerts read "... submitted." even though they fire only after `pollTx` confirms `code == 0` — the tx is already on-chain — while `/swap` and `/pool` already say "successful" / "provided". Switched the four to confirmed language: "Market swap confirmed." / "Limit order placed." / "Ladder placed.". One addition to your list: there's a 4th occurrence you didn't catch — `LimitOrdersPage.tsx:597` ("Limit order submitted.") — fixed it too for consistency. `tsc -b` clean. Not in this MR (flagged): the separate **intermediate broadcast → confirming state** (part 1 of #304). `terraBroadcast.ts` runs `broadcastTx` then `pollTx` as sequential awaits in one `mutationFn`, so `isPending` covers sign-through-confirm with no hook to switch to a "Confirming…" label. That's a broadcast-pattern change worth doing on its own. Visual confirmation is yours (browser). No closing keyword.

Rows
Columns